[analysis_server] Migrate signature computers to new element model

Change-Id: I72d5c9f841d9f85b7f9597a309b14ba4b7e0d3a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391800
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: DanTup

pkg/analysis_server/analyzer_use_new_elements.txt

@@ -42,6 +42,8 @@ lib/src/computer/computer_highlights.dart
 lib/src/computer/computer_outline.dart
 lib/src/computer/computer_overrides.dart
 lib/src/computer/computer_selection_ranges.dart
+lib/src/computer/computer_signature.dart
+lib/src/computer/computer_type_arguments_signature.dart
 lib/src/context_manager.dart
 lib/src/domain_analysis_flags.dart
 lib/src/domains/analysis/occurrences.dart

pkg/analysis_server/lib/src/computer/computer_signature.dart

@@ -6,7 +6,7 @@ import 'package:analysis_server/src/computer/computer_documentation.dart';
 import 'package:analysis_server/src/protocol_server.dart' hide Element;
 import 'package:analysis_server/src/utilities/extensions/ast.dart';
 import 'package:analyzer/dart/ast/ast.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/dart/ast/element_locator.dart';
 import 'package:analyzer/src/dart/ast/utilities.dart';
@@ -40,33 +40,35 @@ class DartUnitSignatureComputer {
       return null;
     }
     String? name;
-    Element? element;
-    List<ParameterElement>? parameters;
+    Element2? element;
+    List<FormalParameterElement>? parameters;
     var parent = argumentList.parent;
     if (parent is MethodInvocation) {
       name = parent.methodName.name;
-      element = ElementLocator.locate(parent);
-      parameters = element is FunctionTypedElement ? element.parameters : null;
+      element = ElementLocator.locate2(parent);
+      parameters =
+          element is FunctionTypedElement2 ? element.formalParameters : null;
     } else if (parent is InstanceCreationExpression) {
       name = parent.constructorName.type.qualifiedName;
       var constructorName = parent.constructorName.name;
       if (constructorName != null) {
         name += '.${constructorName.name}';
       }
-      element = ElementLocator.locate(parent);
-      parameters = element is FunctionTypedElement ? element.parameters : null;
+      element = ElementLocator.locate2(parent);
+      parameters =
+          element is FunctionTypedElement2 ? element.formalParameters : null;
     } else if (parent
         case FunctionExpressionInvocation(function: Identifier function)) {
       name = function.name;
 
       if (function.staticType case FunctionType functionType) {
         // Standard function expression.
-        element = function.staticElement;
-        parameters = functionType.parameters;
-      } else if (parent.staticElement case ExecutableElement staticElement) {
+        element = function.element;
+        parameters = functionType.formalParameters;
+      } else if (parent.element case ExecutableElement2 executableElement) {
         // Callable class instance (where we'll look at the `call` method).
-        element = staticElement;
-        parameters = staticElement.parameters;
+        element = executableElement;
+        parameters = executableElement.formalParameters;
       }
     }
 
@@ -76,7 +78,7 @@ class DartUnitSignatureComputer {
 
     _argumentList = argumentList;
     var convertedParameters = parameters.map((p) => _convertParam(p)).toList();
-    var dartdoc = _documentationComputer.computePreferred(
+    var dartdoc = _documentationComputer.computePreferred2(
       element,
       documentationPreference,
     );
@@ -88,7 +90,7 @@ class DartUnitSignatureComputer {
     );
   }
 
-  ParameterInfo _convertParam(ParameterElement param) {
+  ParameterInfo _convertParam(FormalParameterElement param) {
     return ParameterInfo(
         param.isOptionalNamed
             ? ParameterKind.OPTIONAL_NAMED

pkg/analysis_server/lib/src/computer/computer_type_arguments_signature.dart

@@ -7,7 +7,7 @@ import 'package:analysis_server/src/computer/computer_documentation.dart';
 import 'package:analysis_server/src/lsp/dartdoc.dart';
 import 'package:analysis_server/src/lsp/mapping.dart';
 import 'package:analyzer/dart/ast/ast.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/src/dart/ast/element_locator.dart';
 import 'package:analyzer/src/dart/ast/utilities.dart';
 import 'package:analyzer/src/dartdoc/dartdoc_directive_info.dart';
@@ -43,27 +43,27 @@ class DartTypeArgumentsSignatureComputer {
       return null;
     }
     var parent = argumentList.parent;
-    Element? element;
+    Element2? element;
     if (parent is NamedType) {
-      element = parent.element;
+      element = parent.element2;
     } else if (parent is MethodInvocation) {
-      element = ElementLocator.locate(parent.methodName);
+      element = ElementLocator.locate2(parent.methodName);
     }
-    if (element is! TypeParameterizedElement ||
-        element.typeParameters.isEmpty) {
+    if (element is! TypeParameterizedElement2 ||
+        element.typeParameters2.isEmpty) {
       return null;
     }
 
     _argumentList = argumentList;
 
-    var label = element.getDisplayString();
-    var documentation = _documentationComputer.computePreferred(
+    var label = element.displayString2();
+    var documentation = _documentationComputer.computePreferred2(
         element, documentationPreference);
 
     return _toSignatureHelp(
       label,
       cleanDartdoc(documentation),
-      element.typeParameters,
+      element.typeParameters2,
     );
   }
 
@@ -85,11 +85,11 @@ class DartTypeArgumentsSignatureComputer {
   lsp.SignatureHelp? _toSignatureHelp(
     String label,
     String? documentation,
-    List<TypeParameterElement> typeParameters,
+    List<TypeParameterElement2> typeParameters,
   ) {
     var parameters = typeParameters
         .map((param) => lsp.ParameterInformation(
-              label: param.getDisplayString(),
+              label: param.displayString2(),
             ))
         .toList();