[messages] Move removedLint.

Moves the `removedLint` constant from the generated file
`pkg/linter/lib/src/lint_codes.g.dart` (where it was a static const
inside the `LinterLintCode` class) to the handwritten file
`pkg/linter/lib/src/diagnostic.dart` (where it is a top level
constant), and adjusts usages.

This paves the way for a follow-up CL that will remove the generated
file `pkg/linter/lib/src/lint_codes.g.dart` entirely.

Change-Id: I6a6a69641554f98b19b1e1c4ef488439da21cca5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/461780
Commit-Queue: Paul Berry <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: stereotype441

pkg/linter/lib/src/diagnostic.dart

@@ -6,3 +6,13 @@ import 'analyzer.dart';
 import 'diagnostic.dart' as diag;
 
 part 'package:linter/src/diagnostic.g.dart';
+
+/// A lint code that removed lints can specify as their `lintCode`.
+///
+/// Avoid other usages as it should be made unnecessary and removed.
+const LintCode removedLint = LinterLintCode(
+  name: 'removed_lint',
+  problemMessage: 'Removed lint.',
+  expectedTypes: [],
+  uniqueName: 'LintCode.removed_lint',
+);

pkg/linter/lib/src/lint_codes.g.dart

@@ -1103,16 +1103,6 @@ class LinterLintCode extends LintCodeWithExpectedTypes {
   static const LinterLintWithoutArguments removeDeprecationsInBreakingVersions =
       diag.removeDeprecationsInBreakingVersions;
 
-  /// A lint code that removed lints can specify as their `lintCode`.
-  ///
-  /// Avoid other usages as it should be made unnecessary and removed.
-  static const LintCode removedLint = LinterLintCode(
-    name: 'removed_lint',
-    problemMessage: 'Removed lint.',
-    expectedTypes: [],
-    uniqueName: 'LintCode.removed_lint',
-  );
-
   /// No parameters.
   static const LinterLintWithoutArguments requireTrailingCommas =
       diag.requireTrailingCommas;

pkg/linter/lib/src/rules/always_require_non_null_named_parameters.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/analysis_rule/rule_state.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';
+import '../diagnostic.dart' as diag;
 
 const _desc = r'Specify `@required` on named parameters without defaults.';
 
@@ -19,5 +20,5 @@ class AlwaysRequireNonNullNamedParameters extends AnalysisRule {
       );
 
   @override
-  DiagnosticCode get diagnosticCode => LinterLintCode.removedLint;
+  DiagnosticCode get diagnosticCode => diag.removedLint;
 }

pkg/linter/lib/src/rules/avoid_as.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/analysis_rule/rule_state.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';
+import '../diagnostic.dart' as diag;
 
 const _desc = r'Avoid using `as`.';
 
@@ -19,5 +20,5 @@ class AvoidAs extends AnalysisRule {
       );
 
   @override
-  DiagnosticCode get diagnosticCode => LinterLintCode.removedLint;
+  DiagnosticCode get diagnosticCode => diag.removedLint;
 }

pkg/linter/lib/src/rules/avoid_returning_null.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/analysis_rule/rule_state.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';
+import '../diagnostic.dart' as diag;
 
 const _desc =
     r'Avoid returning null from members whose return type is bool, double, int,'
@@ -21,5 +22,5 @@ class AvoidReturningNull extends AnalysisRule {
       );
 
   @override
-  DiagnosticCode get diagnosticCode => LinterLintCode.removedLint;
+  DiagnosticCode get diagnosticCode => diag.removedLint;
 }

pkg/linter/lib/src/rules/avoid_returning_null_for_future.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/analysis_rule/rule_state.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';
+import '../diagnostic.dart' as diag;
 
 const _desc = r'Avoid returning null for Future.';
 
@@ -19,5 +20,5 @@ class AvoidReturningNullForFuture extends AnalysisRule {
       );
 
   @override
-  DiagnosticCode get diagnosticCode => LinterLintCode.removedLint;
+  DiagnosticCode get diagnosticCode => diag.removedLint;
 }

pkg/linter/lib/src/rules/avoid_unstable_final_fields.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/analysis_rule/rule_state.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';
+import '../diagnostic.dart' as diag;
 
 const _desc =
     r'Avoid overriding a final field to return '
@@ -21,5 +22,5 @@ class AvoidUnstableFinalFields extends AnalysisRule {
       );
 
   @override
-  DiagnosticCode get diagnosticCode => LinterLintCode.removedLint;
+  DiagnosticCode get diagnosticCode => diag.removedLint;
 }

pkg/linter/lib/src/rules/enable_null_safety.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/analysis_rule/rule_state.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';
+import '../diagnostic.dart' as diag;
 
 const _desc = r'Do use sound null safety.';
 
@@ -19,5 +20,5 @@ class EnableNullSafety extends AnalysisRule {
       );
 
   @override
-  DiagnosticCode get diagnosticCode => LinterLintCode.removedLint;
+  DiagnosticCode get diagnosticCode => diag.removedLint;
 }

pkg/linter/lib/src/rules/invariant_booleans.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/analysis_rule/rule_state.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';
+import '../diagnostic.dart' as diag;
 
 const _desc =
     r'Conditions should not unconditionally evaluate to `true` or to `false`.';
@@ -20,5 +21,5 @@ class InvariantBooleans extends AnalysisRule {
       );
 
   @override
-  DiagnosticCode get diagnosticCode => LinterLintCode.removedLint;
+  DiagnosticCode get diagnosticCode => diag.removedLint;
 }

pkg/linter/lib/src/rules/iterable_contains_unrelated_type.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/analysis_rule/rule_state.dart';
 import 'package:analyzer/error/error.dart';
 
 import '../analyzer.dart';
+import '../diagnostic.dart' as diag;
 
 const _desc =
     r'Invocation of `Iterable<E>.contains` with references of'
@@ -21,5 +22,5 @@ class IterableContainsUnrelatedType extends AnalysisRule {
       );
 
   @override
-  DiagnosticCode get diagnosticCode => LinterLintCode.removedLint;
+  DiagnosticCode get diagnosticCode => diag.removedLint;
 }