Fine. Don't attempt to read per file results in _produceErrors().

The whole library result is either there, or not.

Eventually we will stop writing them too.

Change-Id: I6fa8db65c8f922709f67cbc6e236fb852e2a5832
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/443742
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -1452,7 +1452,7 @@ class AnalysisDriver {
         if (withFineDependencies && requirements != null) {
           requirements.removeReqForLibs({library.file.uri});
 
-          performance.run('writeResolvedLibrary', (_) {
+          performance.run('writeResolvedLibrary', (performance) {
             var mapSink = BufferedSink();
             mapSink.writeMap(
               fileResultBytesMap,
@@ -1470,6 +1470,7 @@ class AnalysisDriver {
             requirements.write(sink);
             sink.writeUint8List(mapBytes);
             var allBytes = sink.takeBytes();
+            performance.getDataInt('bytes').add(allBytes.length);
 
             var key = library.resolvedKey;
             _byteStore.putGet(key, allBytes);
@@ -2088,50 +2089,50 @@ class AnalysisDriver {
           }
           return;
         }
-      }
+      } else {
+        // Check if we have cached errors for all library files.
+        List<(FileState, String, Uint8List)>? forAllFiles = [];
+        for (var file in library.files) {
+          // If the file is priority, we need the resolved unit.
+          // So, the cached errors is not enough.
+          if (priorityFiles.contains(file.path)) {
+            forAllFiles = null;
+            break;
+          }
 
-      // Check if we have cached errors for all library files.
-      List<(FileState, String, Uint8List)>? forAllFiles = [];
-      for (var file in library.files) {
-        // If the file is priority, we need the resolved unit.
-        // So, the cached errors is not enough.
-        if (priorityFiles.contains(file.path)) {
-          forAllFiles = null;
-          break;
-        }
+          var signature = _getResolvedUnitSignature(library, file);
+          var key = _getResolvedUnitKey(signature);
 
-        var signature = _getResolvedUnitSignature(library, file);
-        var key = _getResolvedUnitKey(signature);
+          var bytes = _byteStore.get(key);
+          if (bytes == null) {
+            forAllFiles = null;
+            break;
+          }
 
-        var bytes = _byteStore.get(key);
-        if (bytes == null) {
-          forAllFiles = null;
-          break;
+          // Will not be `null` here.
+          forAllFiles?.add((file, signature, bytes));
         }
 
-        // Will not be `null` here.
-        forAllFiles?.add((file, signature, bytes));
-      }
+        // If we have results for all library files, produce them.
+        if (forAllFiles != null) {
+          for (var (file, signature, bytes) in forAllFiles) {
+            // We have the result for this file.
+            _fileTracker.fileWasAnalyzed(file.path);
 
-      // If we have results for all library files, produce them.
-      if (forAllFiles != null) {
-        for (var (file, signature, bytes) in forAllFiles) {
-          // We have the result for this file.
-          _fileTracker.fileWasAnalyzed(file.path);
+            // Don't produce the result if the signature is the same.
+            if (_lastProducedSignatures[file.path] == signature) {
+              continue;
+            }
 
-          // Don't produce the result if the signature is the same.
-          if (_lastProducedSignatures[file.path] == signature) {
-            continue;
+            // Produce the result from bytes.
+            var result = _createErrorsResultFromBytes(file, library, bytes);
+            _lastProducedSignatures[file.path] = signature;
+            _errorsRequestedFiles.completeAll(file.path, result);
+            _scheduler.eventsController.add(result);
           }
-
-          // Produce the result from bytes.
-          var result = _createErrorsResultFromBytes(file, library, bytes);
-          _lastProducedSignatures[file.path] = signature;
-          _errorsRequestedFiles.completeAll(file.path, result);
-          _scheduler.eventsController.add(result);
+          // We produced all results for the library.
+          return;
         }
-        // We produced all results for the library.
-        return;
       }
 
       performance.run('analyzeFile', (performance) {