[analyzer] Dot shorthands: Handle constructor tearoffs.

Since `DotShorthandPropertyAccess` can be a tearoff or a static getter, I updated the logic to handle constructor tearoffs before trying to find a getter.

co19 tests passing and unit tests added.

Bug: #59835
Change-Id: Idbd9f98058d9b66347a825840f80c0e607f6b305
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427520
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/analyzer/lib/src/dart/resolver/property_element_resolver.dart

@@ -56,29 +56,21 @@ class PropertyElementResolver with ScopeHelpers {
     // `FutureOr<S>`.
     context = _resolver.typeSystem.futureOrBase(context);
 
-    // TODO(kallentu): Support other context types
     if (context is InterfaceTypeImpl) {
       var identifier = node.propertyName;
-      if (identifier.name == 'new') {
-        var element = context.lookUpConstructor2(
-          identifier.name,
-          _definingLibrary,
-        );
-        // We didn't resolve to any static getter or static field using the
-        // context type.
-        if (element == null) {
-          errorReporter.atNode(
-            node,
-            CompileTimeErrorCode.DOT_SHORTHAND_UNDEFINED_GETTER,
-            arguments: [node.propertyName.name, context.getDisplayString()],
-          );
-          return PropertyElementResolverResult();
-        }
+      // Find constructor tearoffs.
+      var element = context.lookUpConstructor2(
+        identifier.name,
+        _definingLibrary,
+      );
+      if (element != null) {
         return PropertyElementResolverResult(
           readElementRequested2: element,
           getType: element.returnType,
         );
       }
+
+      // Didn't find any constructor tearoffs, look for static getters.
       var contextElement = context.element3;
       return _resolveTargetInterfaceElement(
         typeReference: contextElement,

pkg/analyzer/test/src/dart/resolution/dot_shorthand_property_access_test.dart

@@ -370,7 +370,7 @@ void main() {
   print(c);
 }
 ''',
-      [error(CompileTimeErrorCode.DOT_SHORTHAND_UNDEFINED_GETTER, 48, 4)],
+      [error(CompileTimeErrorCode.DOT_SHORTHAND_UNDEFINED_GETTER, 49, 3)],
     );
   }
 
@@ -512,7 +512,35 @@ DotShorthandPropertyAccess
 ''');
   }
 
-  test_object_new() async {
+  test_tearOff_constructor() async {
+    await assertNoErrorsInCode(r'''
+class C1 {
+  C1.id();
+
+  @override
+  bool operator ==(Object other) => identical(C1.id, other);
+}
+
+main() {
+  bool x = C1.id() == .id;
+  print(x);
+}
+''');
+
+    var identifier = findNode.singleDotShorthandPropertyAccess;
+    assertResolvedNodeText(identifier, r'''
+DotShorthandPropertyAccess
+  period: .
+  propertyName: SimpleIdentifier
+    token: id
+    element: <testLibraryFragment>::@class::C1::@constructor::id#element
+    staticType: C1 Function()
+  correspondingParameter: <testLibraryFragment>::@class::C1::@method::==::@parameter::other#element
+  staticType: C1 Function()
+''');
+  }
+
+  test_tearOff_constructor_new() async {
     await assertNoErrorsInCode('''
 void main() {
   Object o = .new;