[ddc] Refactor function invocation visitors

`visitFunctionInvocation()` and `visitLocalFunctionInvocation()` now
emit code directly.

Towards reducing the variety of code that flows through
`_emitMethodCall()` so hot reload soundness checks can be added when
they are appropriate.

Change-Id: I11e7fef6a454509a18f570bc2a316e81b9e09f2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422365
Reviewed-by: Nate Biggs <[email protected]>
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>

Author: nshahan

pkg/dev_compiler/lib/src/kernel/compiler.dart

@@ -5268,7 +5268,17 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
 
   @override
   js_ast.Expression visitFunctionInvocation(FunctionInvocation node) {
-    return _emitMethodCall(node.receiver, null, node.arguments, node);
+    assert(node.name.text == 'call');
+    var function = _visitExpression(node.receiver);
+    var arguments = _emitArgumentList(node.arguments);
+    if (node.functionType == null) {
+      // A `null` here implies the receiver is typed as `Function`. There isn't
+      // any more type information available at compile time to know this
+      // invocation is sound so a dynamic call will handle the checks at
+      // runtime.
+      return _emitDynamicInvoke(function, null, arguments, node.arguments);
+    }
+    return js_ast.Call(function, arguments);
   }
 
   @override
@@ -5292,11 +5302,10 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
 
   @override
   js_ast.Expression visitLocalFunctionInvocation(LocalFunctionInvocation node) {
-    return _emitMethodCall(
-        VariableGet(node.variable)..fileOffset = node.fileOffset,
-        null,
-        node.arguments,
-        node);
+    assert(node.name.text == 'call');
+    final localName = VariableGet(node.variable)..fileOffset = node.fileOffset;
+    return js_ast.Call(
+        _visitExpression(localName), _emitArgumentList(node.arguments));
   }
 
   @override

pkg/dev_compiler/lib/src/kernel/compiler_new.dart

@@ -5717,7 +5717,17 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
 
   @override
   js_ast.Expression visitFunctionInvocation(FunctionInvocation node) {
-    return _emitMethodCall(node.receiver, null, node.arguments, node);
+    assert(node.name.text == 'call');
+    var function = _visitExpression(node.receiver);
+    var arguments = _emitArgumentList(node.arguments);
+    if (node.functionType == null) {
+      // A `null` here implies the receiver is typed as `Function`. There isn't
+      // any more type information available at compile time to know this
+      // invocation is sound so a dynamic call will handle the checks at
+      // runtime.
+      return _emitDynamicInvoke(function, null, arguments, node.arguments);
+    }
+    return js_ast.Call(function, arguments);
   }
 
   @override
@@ -5741,11 +5751,10 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
 
   @override
   js_ast.Expression visitLocalFunctionInvocation(LocalFunctionInvocation node) {
-    return _emitMethodCall(
-        VariableGet(node.variable)..fileOffset = node.fileOffset,
-        null,
-        node.arguments,
-        node);
+    assert(node.name.text == 'call');
+    final localName = VariableGet(node.variable)..fileOffset = node.fileOffset;
+    return js_ast.Call(
+        _visitExpression(localName), _emitArgumentList(node.arguments));
   }
 
   @override