Skip to content

Commit 901c424

Browse files
keertipCommit Queue
authored andcommitted
Remove dead code in leagacy CompletionHandler.
Change-Id: Ie5e47d38d7aca02dc495d28bac81910f87630e52 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442702 Commit-Queue: Keerti Parthasarathy <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent 4447eb8 commit 901c424

File tree

1 file changed

+0
-39
lines changed

1 file changed

+0
-39
lines changed

pkg/analysis_server/lib/src/handler/legacy/completion_get_suggestions2.dart

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import 'package:analysis_server/src/request_handler_mixin.dart';
1313
import 'package:analysis_server/src/services/completion/completion_performance.dart';
1414
import 'package:analysis_server/src/services/completion/dart/candidate_suggestion.dart';
1515
import 'package:analysis_server/src/services/completion/dart/completion_manager.dart';
16-
import 'package:analysis_server/src/services/completion/dart/suggestion_builder.dart';
1716
import 'package:analysis_server/src/services/completion/yaml/analysis_options_generator.dart';
1817
import 'package:analysis_server/src/services/completion/yaml/fix_data_generator.dart';
1918
import 'package:analysis_server/src/services/completion/yaml/pubspec_generator.dart';
@@ -63,44 +62,6 @@ class CompletionGetSuggestions2Handler extends CompletionHandler
6362
});
6463
}
6564

66-
/// Computes completion results for [request] and append them to the stream.
67-
///
68-
/// Clients should not call this method directly as it is
69-
/// automatically called when a client listens to the stream returned by
70-
/// 'results'. Subclasses should override this method, append at least one
71-
/// result to the controller, and close the controller stream once complete.
72-
Future<List<CompletionSuggestionBuilder>> computeSuggestions({
73-
required CompletionBudget budget,
74-
required OperationPerformanceImpl performance,
75-
required DartCompletionRequest request,
76-
required int maxSuggestions,
77-
NotImportedSuggestions? notImportedSuggestions,
78-
required bool useFilter,
79-
}) async {
80-
//
81-
// Compute completions generated by server.
82-
//
83-
var suggestions = <CompletionSuggestionBuilder>[];
84-
await performance.runAsync('computeSuggestions', (performance) async {
85-
var manager = DartCompletionManager(
86-
budget: budget,
87-
notImportedSuggestions: notImportedSuggestions,
88-
);
89-
90-
suggestions.addAll(
91-
await manager.computeSuggestions(
92-
request,
93-
performance,
94-
maxSuggestions: maxSuggestions,
95-
useFilter: useFilter,
96-
),
97-
);
98-
});
99-
// TODO(danrubel): if request is obsolete (processAnalysisRequest returns
100-
// false) then send empty results
101-
return suggestions;
102-
}
103-
10465
/// Return the suggestions that should be presented in the YAML [file] at the
10566
/// given [offset].
10667
YamlCompletionResults computeYamlSuggestions(String file, int offset) {

0 commit comments

Comments
 (0)