[vm] Verify entry point annotations in Dart_GetStaticMethodClosure.

Methods that are accessed via Dart_GetStaticMethodClosure should
be annotated as a getter entry point, so now the runtime verifies that.

See the discussion on flutter/engine#57158
for additional context.

TEST=vm/cc/DartAPI_GetStaticMethodClosure

Cq-Include-Trybots: luci.dart.try:vm-aot-linux-product-x64-try,vm-aot-linux-debug-x64-try,vm-aot-mac-release-arm64-try,vm-aot-mac-product-arm64-try,vm-aot-dwarf-linux-product-x64-try,vm-linux-debug-x64-try,vm-linux-release-x64-try,vm-appjit-linux-product-x64-try
Change-Id: I4b65ed4332dfabe662a364e7cde0ef0596beee54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400583
Commit-Queue: Tess Strickland <[email protected]>
Reviewed-by: Martin Kustermann <[email protected]>

Author: sstrickl

runtime/vm/dart_api_impl.cc

@@ -2795,6 +2795,11 @@ DART_EXPORT Dart_Handle Dart_GetStaticMethodClosure(Dart_Handle library,
     return Api::NewError(
         "function_name must be the name of a regular function.");
   }
+
+  if (FLAG_verify_entry_points) {
+    CHECK_ERROR_HANDLE(func.VerifyEntryPoint(EntryPointPragma::kGetterOnly));
+  }
+
   func = func.ImplicitClosureFunction();
   if (func.IsNull()) {
     return Dart_Null();

runtime/vm/dart_api_impl_test.cc

@@ -1270,17 +1270,29 @@ TEST_CASE(DartAPI_ClosureFunction) {
 }
 
 TEST_CASE(DartAPI_GetStaticMethodClosure) {
-  const char* kScriptChars =
-      "class Foo {\n"
-      "  static int getInt() {\n"
-      "    return 1;\n"
-      "  }\n"
-      "  double getDouble() {\n"
-      "    return 1.0;\n"
-      "  }\n"
-      "}\n";
+  const char* kScriptChars = R"(
+    @pragma("vm:entry-point")
+    class Foo {
+      static int getIntNoAnnotation() {
+        return 1;
+      }
+      @pragma("vm:entry-point", "call")
+      static int getIntCallOnly() {
+        return 1;
+      }
+      @pragma("vm:entry-point", "get")
+      static int getInt() {
+        return 1;
+      }
+      @pragma("vm:entry-point", "get")
+      double getDouble() {
+        return 1.0;
+      }
+    }
+  )";
+  // Ensure entry points are checked.
+  SetFlagScope<bool> sfs(&FLAG_verify_entry_points, true);
   // Create a test library and Load up a test script in it.
-  SetFlagScope<bool> sfs(&FLAG_verify_entry_points, false);
   Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, nullptr);
   EXPECT_VALID(lib);
   Dart_Handle foo_cls = Dart_GetClass(lib, NewString("Foo"));
@@ -1321,6 +1333,15 @@ TEST_CASE(DartAPI_GetStaticMethodClosure) {
   EXPECT_ERROR(Dart_GetStaticMethodClosure(lib, foo_cls, Dart_Null()),
                "Dart_GetStaticMethodClosure expects argument 'function_name' "
                "to be non-null.");
+  EXPECT_ERROR(
+      Dart_GetStaticMethodClosure(lib, foo_cls,
+                                  NewString("getIntNoAnnotation")),
+      "To closurize 'file:///test-lib::Foo.getIntNoAnnotation' from native "
+      "code, it must be annotated.");
+  EXPECT_ERROR(
+      Dart_GetStaticMethodClosure(lib, foo_cls, NewString("getIntCallOnly")),
+      "To closurize 'file:///test-lib::Foo.getIntCallOnly' from native "
+      "code, it must be annotated.");
 }
 
 TEST_CASE(DartAPI_ClassLibrary) {