[messages] Update parameter names for more analyzer diagnostics.

In the following analyzer diagnostics, updates the placeholder
parameter names `p0`, `p1`, `p2`, etc. with descriptive parameter
names, and updates the call sites that use those diagnostic messages
to use the new literate diagnostic reporting API:

- `ambiguousExport`
- `ambiguousExtensionMemberAccessTwo`
- `ambiguousExtensionMemberAccessThreeOrMore`
- `ambiguousImport`
- `assignmentToFinal`
- `assignmentToFinalLocal`
- `assignmentToFinalNoSetter`
- `augmentationModifierExtra`
- `augmentationModifierMissing`
- `augmentationOfDifferentDeclarationKind`
- `augmentedExpressionNotOperator`
- `builtInIdentifierAsType`
- `caseExpressionTypeImplementsEquals`

Only the `messages.yaml` changes were done manually; the changes to
`dart` code were produced either by the diagnostic message code
generator or by the script `use_literate_api_in_analyzer.dart`.

Change-Id: I6a6a69642fea2a18e0a661c4aadbbc434aba7e77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/467685
Commit-Queue: Paul Berry <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: stereotype441

pkg/analyzer/lib/src/dart/constant/constant_verifier.dart

@@ -1092,10 +1092,10 @@ class ConstantVerifier extends RecursiveAstVisitor<void> {
       if (!featureSet.isEnabled(Feature.patterns)) {
         var expressionType = expressionValue.type;
         if (!expressionValue.hasPrimitiveEquality(featureSet)) {
-          _diagnosticReporter.atNode(
-            expression,
-            diag.caseExpressionTypeImplementsEquals,
-            arguments: [expressionType],
+          _diagnosticReporter.report(
+            diag.caseExpressionTypeImplementsEquals
+                .withArguments(type: expressionType)
+                .at(expression),
           );
         }
       }

pkg/analyzer/lib/src/dart/resolver/assignment_expression_resolver.dart

@@ -398,10 +398,10 @@ class AssignmentExpressionShared {
             }
           } else {
             if (isForEachIdentifier || !unassigned) {
-              _errorReporter.atNode(
-                left,
-                diag.assignmentToFinalLocal,
-                arguments: [element.name!],
+              _errorReporter.report(
+                diag.assignmentToFinalLocal
+                    .withArguments(variableName: element.name!)
+                    .at(left),
               );
             }
           }

pkg/analyzer/lib/src/dart/resolver/extension_member_resolver.dart

@@ -127,32 +127,32 @@ class ExtensionMemberResolver {
 
     // The most specific extension is ambiguous.
     if (mostSpecific.length == 2) {
-      _diagnosticReporter.atEntity(
-        nameEntity,
-        diag.ambiguousExtensionMemberAccessTwo,
-        arguments: [
-          name.name,
-          mostSpecific[0].extension,
-          mostSpecific[1].extension,
-        ],
+      _diagnosticReporter.report(
+        diag.ambiguousExtensionMemberAccessTwo
+            .withArguments(
+              name: name.name,
+              firstExtension: mostSpecific[0].extension,
+              secondExtension: mostSpecific[1].extension,
+            )
+            .at(nameEntity),
       );
     } else {
       var extensions = mostSpecific.map((e) => e.extension).toList();
-      _diagnosticReporter.atEntity(
-        nameEntity,
-        diag.ambiguousExtensionMemberAccessThreeOrMore,
-        arguments: [
-          name.name,
-          mostSpecific.map((e) {
-            var name = e.extension.name;
-            if (name != null) {
-              return "extension '$name'";
-            }
-            var type = e.extendedType.getDisplayString();
-            return "unnamed extension on '$type'";
-          }).commaSeparatedWithAnd,
-        ],
-        contextMessages: convertTypeNames(<Object>[...extensions]),
+      _diagnosticReporter.report(
+        diag.ambiguousExtensionMemberAccessThreeOrMore
+            .withArguments(
+              name: name.name,
+              extensions: mostSpecific.map((e) {
+                var name = e.extension.name;
+                if (name != null) {
+                  return "extension '$name'";
+                }
+                var type = e.extendedType.getDisplayString();
+                return "unnamed extension on '$type'";
+              }).commaSeparatedWithAnd,
+            )
+            .withContextMessages(convertTypeNames(<Object>[...extensions]))
+            .at(nameEntity),
       );
     }
     return ExtensionResolutionError.ambiguous;