Skip to content

Commit 9189341

Browse files
chloestefantsovaCommit Queue
authored andcommitted
[ffi] Remove a test that relies on not-Null Safe subtyping
This CL does not clean up the null checks that are discussed in #47486 Change-Id: Iff5891d48dd9e0602940896001a7bb29538f6016 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429620 Reviewed-by: Daco Harkes <[email protected]> Commit-Queue: Chloe Stefantsova <[email protected]>
1 parent 886de78 commit 9189341

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

tests/ffi/function_test.dart

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ void main() {
3636
testFloatRounding();
3737
testVoidReturn();
3838
testNoArgs();
39-
testNativeFunctionNullableInt();
4039
}
4140
}
4241

@@ -583,20 +582,3 @@ String get arg2ObfuscatedName {
583582
final str = (arg2: 0).toString();
584583
return str.substring('('.length, str.length - ': 0)'.length);
585584
}
586-
587-
void testNativeFunctionNullableInt() {
588-
final sumPlus42 = ffiTestFunctions
589-
.lookupFunction<Int32 Function(Int32, Int32), int Function(int, int?)>(
590-
"SumPlus42",
591-
);
592-
593-
try {
594-
sumPlus42(3, null);
595-
} catch (e) {
596-
// TODO(http://dartbug.com/47098): Save param names to dwarf.
597-
Expect.isTrue(
598-
e.toString().contains(arg2ObfuscatedName) ||
599-
e.toString().contains('<optimized out>'),
600-
);
601-
}
602-
}

0 commit comments

Comments
 (0)