analyzer: Simplify AnalysisOptionsImpl

There were three private fields that were unnecessarily backed by
public getters and and setters.

https://dart.dev/effective-dart/usage#dont-wrap-a-field-in-a-getter-and-setter-unnecessarily

If the three fields are intended to be writable, they can just be
made public.

Change-Id: I3add352e3433b4e9707a0c056c659fbffdaa7cfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389040
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/generated/engine.dart

@@ -42,9 +42,9 @@ typedef AnalyzeFunctionBodiesPredicate = bool Function(Source source);
 /// An analysis context also represents the state of the analysis, which includes
 /// knowing which sources have been included in the analysis (either directly or
 /// indirectly) and the results of the analysis. Sources must be added and
-/// removed from the context using the method [applyChanges], which is also used
-/// to notify the context when sources have been modified and, consequently,
-/// previously known results might have been invalidated.
+/// removed from the context, which is also used to notify the context when
+/// sources have been modified and, consequently, previously known results might
+/// have been invalidated.
 ///
 /// There are two ways to access the results of the analysis. The most common is
 /// to use one of the 'get' methods to access the results. The 'get' methods have
@@ -63,8 +63,7 @@ typedef AnalyzeFunctionBodiesPredicate = bool Function(Source source);
 /// However, this is not always acceptable. Some clients need to keep the
 /// analysis results up-to-date. For such clients there is a mechanism that
 /// allows them to incrementally perform needed analysis and get notified of the
-/// consequent changes to the analysis results. This mechanism is realized by the
-/// method [performAnalysisTask].
+/// consequent changes to the analysis results.
 ///
 /// Analysis engine allows for having more than one context. This can be used,
 /// for example, to perform one analysis based on the state of files on disk and
@@ -196,12 +195,11 @@ class AnalysisOptionsImpl implements AnalysisOptions {
   /// Return `true` if timing data should be gathered during execution.
   bool enableTiming = false;
 
-  /// A list of error processors that are to be used when reporting errors in
-  /// some analysis context.
-  List<ErrorProcessor>? _errorProcessors;
+  @override
+  List<ErrorProcessor> errorProcessors = [];
 
-  /// A list of exclude patterns used to exclude some sources from analysis.
-  List<String>? _excludePatterns;
+  @override
+  List<String> excludePatterns = [];
 
   /// The associated `analysis_options.yaml` file (or `null` if there is none).
   File? file;
@@ -212,12 +210,11 @@ class AnalysisOptionsImpl implements AnalysisOptions {
   @override
   bool warning = true;
 
-  /// The lint rules that are to be run in an analysis context if [lint] returns
-  /// `true`.
-  List<LintRule>? _lintRules;
+  @override
+  List<LintRule> lintRules = [];
 
   /// Indicates whether linter exceptions should be propagated to the caller (by
-  /// re-throwing them)
+  /// re-throwing them).
   bool propagateLinterExceptions = false;
 
   /// Whether implicit casts should be reported as potential problems.
@@ -290,25 +287,6 @@ class AnalysisOptionsImpl implements AnalysisOptions {
   @Deprecated("Use 'enabledLegacyPluginNames' instead")
   List<String> get enabledPluginNames => enabledLegacyPluginNames;
 
-  @override
-  List<ErrorProcessor> get errorProcessors =>
-      _errorProcessors ??= const <ErrorProcessor>[];
-
-  /// Set the list of error [processors] that are to be used when reporting
-  /// errors in some analysis context.
-  set errorProcessors(List<ErrorProcessor> processors) {
-    _errorProcessors = processors;
-  }
-
-  @override
-  List<String> get excludePatterns => _excludePatterns ??= const <String>[];
-
-  /// Set the exclude patterns used to exclude some sources from analysis to
-  /// those in the given list of [patterns].
-  set excludePatterns(List<String> patterns) {
-    _excludePatterns = patterns;
-  }
-
   /// The set of enabled experiments.
   ExperimentStatus get experimentStatus => _contextFeatures;
 
@@ -319,15 +297,6 @@ class AnalysisOptionsImpl implements AnalysisOptions {
   @Deprecated("Use 'warning=' instead")
   set hint(bool value) => warning = value;
 
-  @override
-  List<LintRule> get lintRules => _lintRules ??= const [];
-
-  /// Set the lint rules that are to be run in an analysis context if [lint]
-  /// returns `true`.
-  set lintRules(List<LintRule> rules) {
-    _lintRules = rules;
-  }
-
   Uint32List get signature {
     if (_signature == null) {
       ApiSignature buffer = ApiSignature();