[cfe] Create synthesized super classes late

This moves the creation of class builders for anonymous mixin application to after the creation of the normal class builders.

A ClassDeclaration interface is added to support class builders from different fragments. This is also a step towards creating class builders fully through fragments.

TEST=existing

Change-Id: Ia6b4a17648bdc89b89fd3cfdfe39d24d347b6341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407420
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
Reviewed-by: Alexander Markov <[email protected]>

Author: johnniwinther

pkg/_fe_analyzer_shared/test/metadata/evaluate_data/marker.options

@@ -1,2 +1 @@
 cfe=pkg/front_end/test/id_tests/metadata_evaluate_test.dart
-

pkg/front_end/lib/src/base/scope.dart

@@ -1078,7 +1078,6 @@ extension IteratorExtension<T extends Builder> on Iterator<T> {
     }
   }
 
-  // Coverage-ignore(suite): Not run.
   List<T> toList() {
     List<T> list = [];
     while (moveNext()) {

pkg/front_end/lib/src/compute_platform_binaries_location.dart

@@ -96,7 +96,8 @@ Uri computePlatformBinariesLocation({bool forceBuildDir = false}) {
   // The directory of the Dart VM executable.
   Uri vmDirectory = Uri.base
       .resolveUri(
-          new Uri.file(resolvedExecutable ?? Platform.resolvedExecutable))
+          new Uri.file(resolvedExecutable ?? // Coverage-ignore(suite): Not run.
+              Platform.resolvedExecutable))
       .resolve(".");
   if (vmDirectory.path.endsWith("/bin/")) {
     // Looks like the VM is in a `/bin/` directory, so this is running from a

pkg/front_end/lib/src/fragment/named_mixin_application.dart

@@ -43,7 +43,6 @@ class NamedMixinApplicationFragment implements Fragment {
     return _builder!;
   }
 
-  // Coverage-ignore(suite): Not run.
   void set builder(SourceClassBuilder value) {
     assert(_builder == null, "Builder has already been computed for $this.");
     _builder = value;

pkg/front_end/lib/src/kernel/benchmarker.dart

@@ -173,6 +173,7 @@ enum BenchmarkPhases {
   outline_checkSemantics,
   outline_finishTypeParameters,
   outline_createTypeInferenceEngine,
+  outline_computeSupertypes,
   outline_buildComponent,
   outline_installDefaultSupertypes,
   outline_installSyntheticConstructors,

pkg/front_end/lib/src/kernel/kernel_target.dart

@@ -391,6 +391,7 @@ class KernelTarget {
       Iterable<SourceLibraryBuilder> libraryBuilders) {
     loader.computeLibraryScopes(libraryBuilders);
     loader.resolveTypes(libraryBuilders);
+    loader.computeSupertypes(libraryBuilders);
     loader.computeDefaultTypes(
         libraryBuilders, dynamicType, nullType, bottomType, objectClassBuilder);
   }
@@ -421,6 +422,11 @@ class KernelTarget {
           ?.enterPhase(BenchmarkPhases.outline_resolveTypes);
       loader.resolveTypes(loader.sourceLibraryBuilders);
 
+      benchmarker
+          // Coverage-ignore(suite): Not run.
+          ?.enterPhase(BenchmarkPhases.outline_computeSupertypes);
+      loader.computeSupertypes(loader.sourceLibraryBuilders);
+
       benchmarker
           // Coverage-ignore(suite): Not run.
           ?.enterPhase(BenchmarkPhases.outline_computeMacroApplications);
@@ -1381,7 +1387,7 @@ class KernelTarget {
     _finishConstructors(extensionTypeDeclaration);
   }
 
-  void _finishConstructors(ClassDeclaration classDeclaration) {
+  void _finishConstructors(ClassDeclarationBuilder classDeclaration) {
     SourceLibraryBuilder libraryBuilder = classDeclaration.libraryBuilder;
 
     /// Quotes below are from [Dart Programming Language Specification, 4th

pkg/front_end/lib/src/source/class_declaration.dart

@@ -15,7 +15,10 @@ import 'source_library_builder.dart';
 /// as a regular class declaration and an extension type declaration.
 // TODO(johnniwinther): Should this be renamed now that inline classes are
 //  renamed to extension type declarations?
-abstract class ClassDeclaration
+// TODO(johnniwinther): Merge this with [IDeclarationBuilder]? Extensions are
+// the only declarations without constructors, this might come with the static
+// extension feature.
+abstract class ClassDeclarationBuilder
     implements IDeclarationBuilder, ClassMemberAccess {
   @override
   SourceLibraryBuilder get libraryBuilder;
@@ -79,7 +82,7 @@ abstract class ClassDeclaration
   Iterator<T> localConstructorIterator<T extends MemberBuilder>();
 }
 
-mixin ClassDeclarationMixin implements ClassDeclaration {
+mixin ClassDeclarationBuilderMixin implements ClassDeclarationBuilder {
   List<ConstructorReferenceBuilder>? get constructorReferences;
 
   @override
@@ -107,13 +110,14 @@ mixin ClassDeclarationMixin implements ClassDeclaration {
   }
 }
 
-abstract class ClassDeclarationAugmentationAccess<D extends ClassDeclaration> {
+abstract class ClassDeclarationAugmentationAccess<
+    D extends ClassDeclarationBuilder> {
   D getOrigin(D classDeclaration);
 
   Iterable<D>? getAugmentations(D classDeclaration);
 }
 
-class ClassDeclarationMemberIterator<D extends ClassDeclaration,
+class ClassDeclarationMemberIterator<D extends ClassDeclarationBuilder,
     T extends Builder> implements Iterator<T> {
   Iterator<T>? _iterator;
   Iterator<D>? augmentationBuilders;
@@ -171,7 +175,7 @@ class ClassDeclarationMemberIterator<D extends ClassDeclaration,
 }
 
 // Coverage-ignore(suite): Not run.
-class ClassDeclarationMemberNameIterator<D extends ClassDeclaration,
+class ClassDeclarationMemberNameIterator<D extends ClassDeclarationBuilder,
     T extends Builder> implements NameIterator<T> {
   NameIterator<T>? _iterator;
   Iterator<D>? augmentationBuilders;
@@ -224,7 +228,7 @@ class ClassDeclarationMemberNameIterator<D extends ClassDeclaration,
   String get name => _iterator?.name ?? (throw new StateError('No element'));
 }
 
-class ClassDeclarationConstructorIterator<D extends ClassDeclaration,
+class ClassDeclarationConstructorIterator<D extends ClassDeclarationBuilder,
     T extends MemberBuilder> implements Iterator<T> {
   Iterator<T>? _iterator;
   Iterator<D>? augmentationBuilders;
@@ -283,7 +287,7 @@ class ClassDeclarationConstructorIterator<D extends ClassDeclaration,
       (throw new StateError('No element'));
 }
 
-class ClassDeclarationConstructorNameIterator<D extends ClassDeclaration,
+class ClassDeclarationConstructorNameIterator<D extends ClassDeclarationBuilder,
     T extends MemberBuilder> implements NameIterator<T> {
   NameIterator<T>? _iterator;
   Iterator<D>? augmentationBuilders;