[native_assets] Enable code assets for next stable release

Make it available on the stable branch.

Fix the version numbers for when it was enabled. (3.9 as experiment
enabled is not entirely correct, as the experiment was not available
on the stable channel in 3.9, only on betas of 3.9.)

And disable passing data assets under the same experiment flag.

Note: It seems that it was accidentally still marked as 3.9 and then
got swept up in https://dart-review.googlesource.com/c/sdk/+/443803.

TEST=dartdev native assets tests

Bug: #50565
Change-Id: I4c44ad22e32673d6a951017d0cf6d3374dd20429
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449803
Reviewed-by: Ivan Inozemtsev <[email protected]>
Reviewed-by: Michael Goderbauer <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: dcharkes

DEPS

@@ -140,7 +140,7 @@ vars = {
   "i18n_rev": "a62bed2cf32482e531fbc5c719dfb30680f31c0d",
   "leak_tracker_rev": "f5620600a5ce1c44f65ddaa02001e200b096e14c", # rolled manually
   "material_color_utilities_rev": "799b6ba2f3f1c28c67cc7e0b4f18e0c7d7f3c03e",
-  "native_rev": "99456dec33c4c1f8927c9948ac2138ae6961abf6", # rolled manually while native assets are experimental
+  "native_rev": "445cb0af620328ff04aeed028a60065ec6e5c7ce", # rolled manually while native assets are experimental
   "protobuf_rev": "971bcae358e8c6d0246382b0b15b787e6ac0a428",
   "pub_rev": "469eb6193c0a49495ea2ce7432cf749f077ad596", # rolled manually
   "shelf_rev": "de91a5b8c1de05f622c0c6f1eab38d5f31e0113f",

pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart

@@ -182,7 +182,7 @@ enum ExperimentalFlag {
     name: 'native-assets',
     isEnabledByDefault: true,
     isExpired: true,
-    experimentEnabledVersion: const Version(3, 9),
+    experimentEnabledVersion: const Version(3, 10),
     experimentReleasedVersion: const Version(3, 9),
   ),
 

pkg/analyzer/lib/src/dart/analysis/experiments.g.dart

@@ -427,9 +427,9 @@ class ExperimentalFeatures {
     isEnabledByDefault: IsEnabledByDefault.native_assets,
     isExpired: IsExpired.native_assets,
     documentation: 'Compile and bundle native assets.',
-    experimentalReleaseVersion: null,
-    releaseVersion: Version.parse('3.9.0'),
-    channels: ["main", "dev", "beta"],
+    experimentalReleaseVersion: Version.parse('3.9.0'),
+    releaseVersion: Version.parse('3.10.0'),
+    channels: ["stable", "beta", "dev", "main"],
   );
 
   static final non_nullable = ExperimentalFeature(

pkg/dartdev/lib/src/native_assets.dart

@@ -9,7 +9,6 @@ import 'package:code_assets/code_assets.dart';
 import 'package:dartdev/src/native_assets_bundling.dart';
 import 'package:dartdev/src/sdk.dart';
 import 'package:dartdev/src/utils.dart';
-import 'package:data_assets/data_assets.dart';
 import 'package:file/local.dart';
 import 'package:hooks/hooks.dart';
 import 'package:hooks_runner/hooks_runner.dart';
@@ -137,7 +136,7 @@ class DartNativeAssetsBuilder {
     ),
     // TODO(dacoharkes,mosum): This should be gated behind a data-assets
     // experiment flag.
-    DataAssetsExtension(),
+    // DataAssetsExtension(),
   ];
 
   Future<BuildResult?> _buildNativeAssetsShared({

pkg/front_end/lib/src/api_prototype/experimental_flags_generated.dart

@@ -255,8 +255,8 @@ class ExperimentalFlag {
     name: 'native-assets',
     isEnabledByDefault: true,
     isExpired: true,
-    enabledVersion: const Version(3, 9),
-    experimentEnabledVersion: const Version(3, 9),
+    enabledVersion: const Version(3, 10),
+    experimentEnabledVersion: const Version(3, 10),
     experimentReleasedVersion: const Version(3, 9),
   );
 

runtime/vm/experimental_features.cc

@@ -26,8 +26,8 @@ bool GetExperimentalFeatureDefault(ExperimentalFeature feature) {
 
 const char* GetExperimentalFeatureName(ExperimentalFeature feature) {
   constexpr const char* kFeatureNames[] = {
-      "native-assets",
       "dot-shorthands",
+      "native-assets",
       "getter-setter-error",
       "sound-flow-analysis",
       "null-aware-elements",

runtime/vm/experimental_features.h

@@ -12,8 +12,8 @@
 namespace dart {
 
 enum class ExperimentalFeature {
-  native_assets,
   dot_shorthands,
+  native_assets,
   getter_setter_error,
   sound_flow_analysis,
   null_aware_elements,

tools/experimental_features.yaml

@@ -179,9 +179,9 @@ features:
     help: "Shorter dot syntax for static accesses."
 
   native-assets:
-    help: "Compile and bundle native assets."
-    channels: [ "main", "dev", "beta" ]
-    enabledIn: '3.9.0'
+    help: 'Compile and bundle native assets.'
+    enabledIn: '3.10.0'
+    experimentalReleaseVersion: '3.9.0'
     expired: true
 
   getter-setter-error: