Skip to content

Commit 945b031

Browse files
fishythefishCommit Queue
authored andcommitted
Delete js_platform_hostasserts fileset.
The hostasserts and non-hostasserts filesets do not differ significantly and can be merged for ease of maintenance. The cost of copying extra files is small compared to building, and we currently lack the granularity to see meaningful savings in builds if we keep them separate. Change-Id: If8e3dd1013f60b05dabb104c632abd7a1638fe1d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417947 Reviewed-by: Sigmund Cherem <[email protected]> Reviewed-by: Nicholas Shahan <[email protected]>
1 parent 6446cce commit 945b031

File tree

1 file changed

+8
-33
lines changed

1 file changed

+8
-33
lines changed

tools/bots/test_matrix.json

Lines changed: 8 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@
1414
],
1515
"js_platform": [
1616
".dart_tool/package_config.json",
17+
"out/ReleaseX64/dart",
1718
"out/ReleaseX64/dart-sdk/",
19+
"out/ReleaseX64/dart2js_platform.dill",
20+
"out/ReleaseX64/ddc_outline.dill",
1821
"out/ReleaseX64/gen/utils/ddc/",
1922
"pkg/",
2023
"runtime/tests/",
@@ -32,41 +35,13 @@
3235
"tests/language/",
3336
"tests/lib/",
3437
"tests/web/",
35-
"third_party/babel/babel.min.js",
3638
"third_party/d8/",
3739
"third_party/pkg/",
3840
"third_party/requirejs/",
3941
"tools/",
4042
"xcodebuild/ReleaseARM64/dart-sdk/",
4143
"xcodebuild/ReleaseARM64/gen/utils/ddc/"
4244
],
43-
"js_platform_hostasserts": [
44-
".dart_tool/package_config.json",
45-
"out/ReleaseX64/dart",
46-
"out/ReleaseX64/dart2js_platform.dill",
47-
"out/ReleaseX64/ddc_outline.dill",
48-
"out/ReleaseX64/gen/utils/ddc/",
49-
"pkg/",
50-
"runtime/tests/",
51-
"sdk/",
52-
"tests/co19/co19-analyzer.status",
53-
"tests/co19/co19-co19.status",
54-
"tests/co19/co19-dart2js.status",
55-
"tests/co19/co19-dart2wasm.status",
56-
"tests/co19/co19-dartdevc.status",
57-
"tests/co19/co19-kernel.status",
58-
"tests/co19/co19-runtime.status",
59-
"tests/corelib/",
60-
"tests/dartdevc/",
61-
"tests/ffi/",
62-
"tests/language/",
63-
"tests/lib/",
64-
"tests/web/",
65-
"third_party/d8/",
66-
"third_party/pkg/",
67-
"third_party/requirejs/",
68-
"tools/"
69-
],
7045
"dart2wasm_hostasserts": [
7146
".dart_tool/package_config.json",
7247
"out/ReleaseX64/dart",
@@ -2279,7 +2254,7 @@
22792254
"web"
22802255
],
22812256
"shards": 12,
2282-
"fileset": "js_platform_hostasserts"
2257+
"fileset": "js_platform"
22832258
}
22842259
]
22852260
},
@@ -2444,7 +2419,7 @@
24442419
"web"
24452420
],
24462421
"shards": 6,
2447-
"fileset": "js_platform_hostasserts"
2422+
"fileset": "js_platform"
24482423
},
24492424
{
24502425
"name": "dart2js chrome tests",
@@ -2454,7 +2429,7 @@
24542429
"web"
24552430
],
24562431
"shards": 3,
2457-
"fileset": "js_platform_hostasserts"
2432+
"fileset": "js_platform"
24582433
},
24592434
{
24602435
"name": "dart2js chrome co19 tests",
@@ -2463,7 +2438,7 @@
24632438
"co19"
24642439
],
24652440
"shards": 6,
2466-
"fileset": "js_platform_hostasserts"
2441+
"fileset": "js_platform"
24672442
}
24682443
]
24692444
},
@@ -2538,7 +2513,7 @@
25382513
"web"
25392514
],
25402515
"shards": 13,
2541-
"fileset": "js_platform_hostasserts"
2516+
"fileset": "js_platform"
25422517
}
25432518
]
25442519
},

0 commit comments

Comments
 (0)