Add 'flags' to FeatureSet.latestLanguageVersion()

Change-Id: Iebeaf74ff44c2079b319308638fa731a013fdb90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406221
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Bob Nystrom <[email protected]>

Author: scheglov

pkg/analyzer/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 7.3.0-dev
+* Add `flags` optional named parameter to `FeatureSet.latestLanguageVersion()`.
+
 ## 7.2.0
 * Add `ElementDirective` as superinterface for `LibraryExport`, `LibraryImport`,
   and `PartInclude`. It implements `Annotatable`.

pkg/analyzer/lib/dart/analysis/features.dart

@@ -136,13 +136,14 @@ abstract class FeatureSet {
   }) = ExperimentStatus.fromStrings2;
 
   /// Computes the set of features for the latest language version known
-  /// to the analyzer, without any experiments.  Use it only if you really
-  /// don't care which language version you want to use, and sure that the
-  /// code that you process is valid for the latest language version.
+  /// to the analyzer, with experiments according to [flags].  Use it only if
+  /// you really don't care which language version you want to use, and sure
+  /// that the code that you process is valid for the latest language version.
   ///
   /// Otherwise, it is recommended to use [FeatureSet.fromEnableFlags2].
-  factory FeatureSet.latestLanguageVersion() =
-      ExperimentStatus.latestLanguageVersion;
+  factory FeatureSet.latestLanguageVersion({
+    List<String> flags,
+  }) = ExperimentStatus.latestLanguageVersion;
 
   /// Queries whether the given [feature] is contained in this feature set.
   bool isEnabled(Feature feature);

pkg/analyzer/lib/src/dart/analysis/experiments.dart

@@ -93,7 +93,6 @@ class ExperimentStatus with _CurrentState implements FeatureSet {
   factory ExperimentStatus.fromStrings2({
     required Version sdkLanguageVersion,
     required List<String> flags,
-    // TODO(scheglov): use restrictEnableFlagsToVersion
   }) {
     var explicitFlags = decodeExplicitFlags(flags);
 
@@ -112,10 +111,12 @@ class ExperimentStatus with _CurrentState implements FeatureSet {
     );
   }
 
-  factory ExperimentStatus.latestLanguageVersion() {
+  factory ExperimentStatus.latestLanguageVersion({
+    List<String> flags = const [],
+  }) {
     return ExperimentStatus.fromStrings2(
       sdkLanguageVersion: currentVersion,
-      flags: [],
+      flags: flags,
     );
   }
 

pkg/analyzer/pubspec.yaml

@@ -1,5 +1,5 @@
 name: analyzer
-version: 7.2.0
+version: 7.3.0-dev
 description: >-
   This package provides a library that performs static analysis of Dart code.
 repository: https://github.com/dart-lang/sdk/tree/main/pkg/analyzer