[element model] migrate no_solo_tests check

Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I3659da3539f07072e8ecabfccb5f472818510017
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389141
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/linter/analyzer_use_new_elements.txt

@@ -1,3 +1,7 @@
+lib/src/analyzer.dart
+lib/src/lint_names.dart
+lib/src/linter_lint_codes.dart
+lib/src/rules.dart
 lib/src/rules/always_declare_return_types.dart
 lib/src/rules/always_put_control_body_on_new_line.dart
 lib/src/rules/always_put_required_named_parameters_first.dart
@@ -163,3 +167,300 @@ lib/src/rules/use_test_throws_matchers.dart
 lib/src/rules/use_to_and_as_if_applicable.dart
 lib/src/rules/use_truncating_division.dart
 lib/src/rules/valid_regexps.dart
+lib/src/test_utilities/analyzer_utils.dart
+lib/src/test_utilities/annotation.dart
+lib/src/test_utilities/formatter.dart
+lib/src/test_utilities/test_linter.dart
+lib/src/test_utilities/test_resource_provider.dart
+lib/src/util/ascii_utils.dart
+lib/src/util/charcodes.dart
+lib/src/utils.dart
+test/all.dart
+test/annotation_test.dart
+test/ascii_utils_test.dart
+test/canonicalization_test.dart
+test/directives_ordering_test.dart
+test/doc_test.dart
+test/engine_test.dart
+test/formatter_test.dart
+test/integration_test.dart
+test/lint_code_test.dart
+test/mocks.dart
+test/pubspec_test.dart
+test/rule_test.dart
+test/rule_test_support.dart
+test/rules/all.dart
+test/rules/always_declare_return_types_test.dart
+test/rules/always_put_control_body_on_new_line_test.dart
+test/rules/always_put_required_named_parameters_first_test.dart
+test/rules/always_specify_types_test.dart
+test/rules/always_use_package_imports_test.dart
+test/rules/analyzer_use_new_elements_test.dart
+test/rules/annotate_overrides_test.dart
+test/rules/annotate_redeclares_test.dart
+test/rules/avoid_annotating_with_dynamic_test.dart
+test/rules/avoid_bool_literals_in_conditional_expressions_test.dart
+test/rules/avoid_catches_without_on_clauses_test.dart
+test/rules/avoid_catching_errors_test.dart
+test/rules/avoid_classes_with_only_static_members_test.dart
+test/rules/avoid_double_and_int_checks_test.dart
+test/rules/avoid_dynamic_calls_test.dart
+test/rules/avoid_empty_else_test.dart
+test/rules/avoid_equals_and_hash_code_on_mutable_classes_test.dart
+test/rules/avoid_escaping_inner_quotes_test.dart
+test/rules/avoid_field_initializers_in_const_classes_test.dart
+test/rules/avoid_field_initializers_in_non_const_classes_test.dart
+test/rules/avoid_final_parameters_test.dart
+test/rules/avoid_function_literals_in_foreach_calls_test.dart
+test/rules/avoid_futureor_void_test.dart
+test/rules/avoid_implementing_value_types_test.dart
+test/rules/avoid_init_to_null_test.dart
+test/rules/avoid_js_rounded_ints_test.dart
+test/rules/avoid_multiple_declarations_per_line_test.dart
+test/rules/avoid_null_checks_in_equality_operators_test.dart
+test/rules/avoid_positional_boolean_parameters_test.dart
+test/rules/avoid_print_test.dart
+test/rules/avoid_private_typedef_functions_test.dart
+test/rules/avoid_redundant_argument_values_test.dart
+test/rules/avoid_relative_lib_imports_test.dart
+test/rules/avoid_renaming_method_parameters_test.dart
+test/rules/avoid_return_types_on_setters_test.dart
+test/rules/avoid_returning_null_for_void_test.dart
+test/rules/avoid_returning_null_test.dart
+test/rules/avoid_returning_this_test.dart
+test/rules/avoid_setters_without_getters_test.dart
+test/rules/avoid_shadowing_type_parameters_test.dart
+test/rules/avoid_single_cascade_in_expression_statements_test.dart
+test/rules/avoid_slow_async_io_test.dart
+test/rules/avoid_type_to_string_test.dart
+test/rules/avoid_types_as_parameter_names_test.dart
+test/rules/avoid_types_on_closure_parameters_test.dart
+test/rules/avoid_unnecessary_containers_test.dart
+test/rules/avoid_unused_constructor_parameters_test.dart
+test/rules/avoid_void_async_test.dart
+test/rules/avoid_web_libraries_in_flutter_test.dart
+test/rules/await_only_futures_test.dart
+test/rules/camel_case_extensions_test.dart
+test/rules/camel_case_types_test.dart
+test/rules/cancel_subscriptions_test.dart
+test/rules/cascade_invocations_test.dart
+test/rules/cast_nullable_to_non_nullable_test.dart
+test/rules/close_sinks_test.dart
+test/rules/collection_methods_unrelated_type_test.dart
+test/rules/combinators_ordering_test.dart
+test/rules/comment_references_test.dart
+test/rules/conditional_uri_does_not_exist_test.dart
+test/rules/constant_identifier_names_test.dart
+test/rules/control_flow_in_finally_test.dart
+test/rules/curly_braces_in_flow_control_structures_test.dart
+test/rules/dangling_library_doc_comments_test.dart
+test/rules/depend_on_referenced_packages_test.dart
+test/rules/deprecated_consistency_test.dart
+test/rules/deprecated_member_use_from_same_package_test.dart
+test/rules/diagnostic_describe_all_properties_test.dart
+test/rules/directives_ordering_test.dart
+test/rules/discarded_futures_test.dart
+test/rules/do_not_use_environment_test.dart
+test/rules/document_ignores_test.dart
+test/rules/empty_catches_test.dart
+test/rules/empty_constructor_bodies_test.dart
+test/rules/empty_statements_test.dart
+test/rules/eol_at_end_of_file_test.dart
+test/rules/erase_dart_type_extension_types_test.dart
+test/rules/exhaustive_cases_test.dart
+test/rules/file_names_test.dart
+test/rules/flutter_style_todos_test.dart
+test/rules/hash_and_equals_test.dart
+test/rules/implementation_imports_test.dart
+test/rules/implicit_call_tearoffs_test.dart
+test/rules/implicit_reopen_test.dart
+test/rules/invalid_case_patterns_test.dart
+test/rules/invalid_runtime_check_with_js_interop_types_test.dart
+test/rules/join_return_with_assignment_test.dart
+test/rules/leading_newlines_in_multiline_strings_test.dart
+test/rules/library_annotations_test.dart
+test/rules/library_names_test.dart
+test/rules/library_prefixes_test.dart
+test/rules/library_private_types_in_public_api_test.dart
+test/rules/lines_longer_than_80_chars_test.dart
+test/rules/literal_only_boolean_expressions_test.dart
+test/rules/matching_super_parameters_test.dart
+test/rules/missing_code_block_language_in_doc_comment_test.dart
+test/rules/missing_whitespace_between_adjacent_strings_test.dart
+test/rules/no_adjacent_strings_in_list_test.dart
+test/rules/no_duplicate_case_values_test.dart
+test/rules/no_leading_underscores_for_library_prefixes_test.dart
+test/rules/no_leading_underscores_for_local_identifiers_test.dart
+test/rules/no_literal_bool_comparisons_test.dart
+test/rules/no_logic_in_create_state_test.dart
+test/rules/no_runtimeType_toString_test.dart
+test/rules/no_self_assignments_test.dart
+test/rules/no_wildcard_variable_uses_test.dart
+test/rules/non_constant_identifier_names_test.dart
+test/rules/noop_primitive_operations_test.dart
+test/rules/null_check_on_nullable_type_parameter_test.dart
+test/rules/null_closures_test.dart
+test/rules/omit_local_variable_types_test.dart
+test/rules/omit_obvious_local_variable_types_test.dart
+test/rules/one_member_abstracts_test.dart
+test/rules/only_throw_errors_test.dart
+test/rules/overridden_fields_test.dart
+test/rules/package_api_docs_test.dart
+test/rules/package_names_test.dart
+test/rules/package_prefixed_library_names_test.dart
+test/rules/parameter_assignments_test.dart
+test/rules/prefer_adjacent_string_concatenation_test.dart
+test/rules/prefer_asserts_in_initializer_lists_test.dart
+test/rules/prefer_asserts_with_message_test.dart
+test/rules/prefer_collection_literals_test.dart
+test/rules/prefer_conditional_assignment_test.dart
+test/rules/prefer_const_constructors_in_immutables_test.dart
+test/rules/prefer_const_constructors_test.dart
+test/rules/prefer_const_declarations_test.dart
+test/rules/prefer_const_literals_to_create_immutables_test.dart
+test/rules/prefer_constructors_over_static_methods_test.dart
+test/rules/prefer_contains_test.dart
+test/rules/prefer_double_quotes_test.dart
+test/rules/prefer_expression_function_bodies_test.dart
+test/rules/prefer_final_fields_test.dart
+test/rules/prefer_final_in_for_each_test.dart
+test/rules/prefer_final_locals_test.dart
+test/rules/prefer_final_parameters_test.dart
+test/rules/prefer_for_elements_to_map_fromIterable_test.dart
+test/rules/prefer_foreach_test.dart
+test/rules/prefer_function_declarations_over_variables_test.dart
+test/rules/prefer_generic_function_type_aliases_test.dart
+test/rules/prefer_if_elements_to_conditional_expressions_test.dart
+test/rules/prefer_if_null_operators_test.dart
+test/rules/prefer_initializing_formals_test.dart
+test/rules/prefer_inlined_adds_test.dart
+test/rules/prefer_int_literals_test.dart
+test/rules/prefer_interpolation_to_compose_strings_test.dart
+test/rules/prefer_is_empty_test.dart
+test/rules/prefer_iterable_whereType_test.dart
+test/rules/prefer_mixin_test.dart
+test/rules/prefer_null_aware_method_calls_test.dart
+test/rules/prefer_null_aware_operators_test.dart
+test/rules/prefer_relative_imports_test.dart
+test/rules/prefer_single_quotes_test.dart
+test/rules/prefer_spread_collections_test.dart
+test/rules/prefer_typing_uninitialized_variables_test.dart
+test/rules/prefer_void_to_null_test.dart
+test/rules/provide_deprecation_message_test.dart
+test/rules/public_member_api_docs_test.dart
+test/rules/recursive_getters_test.dart
+test/rules/require_trailing_commas_test.dart
+test/rules/secure_pubspec_urls_test.dart
+test/rules/sized_box_for_whitespace_test.dart
+test/rules/sized_box_shrink_expand_test.dart
+test/rules/slash_for_doc_comments_test.dart
+test/rules/sort_child_properties_last_test.dart
+test/rules/sort_constructors_first_test.dart
+test/rules/sort_pub_dependencies_test.dart
+test/rules/sort_unnamed_constructors_first_test.dart
+test/rules/specify_nonobvious_local_variable_types_test.dart
+test/rules/test_types_in_equals_test.dart
+test/rules/throw_in_finally_test.dart
+test/rules/tighten_type_of_initializing_formals_test.dart
+test/rules/type_annotate_public_apis_test.dart
+test/rules/type_init_formals_test.dart
+test/rules/type_literal_in_constant_pattern_test.dart
+test/rules/unawaited_futures_test.dart
+test/rules/unintended_html_in_doc_comment_test.dart
+test/rules/unnecessary_await_in_return_test.dart
+test/rules/unnecessary_brace_in_string_interps_test.dart
+test/rules/unnecessary_breaks_test.dart
+test/rules/unnecessary_const_test.dart
+test/rules/unnecessary_constructor_name_test.dart
+test/rules/unnecessary_final_test.dart
+test/rules/unnecessary_getters_setters_test.dart
+test/rules/unnecessary_lambdas_test.dart
+test/rules/unnecessary_late_test.dart
+test/rules/unnecessary_library_directive_test.dart
+test/rules/unnecessary_library_name_test.dart
+test/rules/unnecessary_new_test.dart
+test/rules/unnecessary_null_aware_assignments_test.dart
+test/rules/unnecessary_null_aware_operator_on_extension_on_nullable_test.dart
+test/rules/unnecessary_null_checks_test.dart
+test/rules/unnecessary_null_in_if_null_operators_test.dart
+test/rules/unnecessary_nullable_for_final_variable_declarations_test.dart
+test/rules/unnecessary_overrides_test.dart
+test/rules/unnecessary_parenthesis_test.dart
+test/rules/unnecessary_raw_strings_test.dart
+test/rules/unnecessary_statements_test.dart
+test/rules/unnecessary_string_escapes_test.dart
+test/rules/unnecessary_string_interpolations_test.dart
+test/rules/unnecessary_this_test.dart
+test/rules/unnecessary_to_list_in_spreads_test.dart
+test/rules/unreachable_from_main_test.dart
+test/rules/unrelated_type_equality_checks_test.dart
+test/rules/unsafe_html_test.dart
+test/rules/use_colored_box_test.dart
+test/rules/use_decorated_box_test.dart
+test/rules/use_enums_test.dart
+test/rules/use_full_hex_values_for_flutter_colors_test.dart
+test/rules/use_function_type_syntax_for_parameters_test.dart
+test/rules/use_if_null_to_convert_nulls_to_bools_test.dart
+test/rules/use_is_even_rather_than_modulo_test.dart
+test/rules/use_key_in_widget_constructors_test.dart
+test/rules/use_late_for_private_fields_and_variables_test.dart
+test/rules/use_named_constants_test.dart
+test/rules/use_raw_strings_test.dart
+test/rules/use_rethrow_when_possible_test.dart
+test/rules/use_setters_to_change_properties_test.dart
+test/rules/use_string_buffers_test.dart
+test/rules/use_string_in_part_of_directives_test.dart
+test/rules/use_super_parameters_test.dart
+test/rules/use_test_throws_matchers_test.dart
+test/rules/use_to_and_as_if_applicable_test.dart
+test/rules/use_truncating_division_test.dart
+test/rules/valid_regexps_test.dart
+test/rules/void_checks_test.dart
+test/test_constants.dart
+test/unmocked_sdk_rule_test.dart
+test/util/annotation.dart
+test/util/annotation_matcher.dart
+test/util/rule_debug.dart
+test/util/test_resource_provider.dart
+test/util/test_utils.dart
+test/utils_test.dart
+test/validate_incompatible_rules_test.dart
+test/validate_no_rule_description_references_test.dart
+test/validate_rule_description_format_test.dart
+test/verify_checks_test.dart
+test/verify_generated_codes_test.dart
+test/verify_reflective_test_suites_test.dart
+test_data/rules/no_default_cases.dart
+test_data/rules/overridden_fields.dart
+test_data/rules/prefer_const_declarations.dart
+test_data/rules/prefer_final_fields.dart
+test_data/rules/prefer_is_not_empty.dart
+test_data/rules/prefer_is_not_operator.dart
+test_data/rules/prefer_void_to_null.dart
+test_data/rules/require_trailing_commas.dart
+test_data/rules/type_init_formals.dart
+test_data/rules/unawaited_futures.dart
+test_data/rules/unmocked/unsafe_html.dart
+test_data/rules/unnecessary_lambdas.dart
+test_data/rules/unnecessary_parenthesis.dart
+test_data/rules/void_checks.dart
+tool/changelog.dart
+tool/checks/check_all_yaml.dart
+tool/checks/check_messages_yaml.dart
+tool/checks/driver.dart
+tool/checks/rules/no_solo_tests.dart
+tool/checks/rules/no_trailing_spaces.dart
+tool/cli.dart
+tool/codes/generate.dart
+tool/labeler/issue_config.dart
+tool/labeler/pr_config.dart
+tool/legacy_test_move.dart
+tool/lint_sets.dart
+tool/machine.dart
+tool/messages_info.dart
+tool/migrate.dart
+tool/parse.dart
+tool/rule.dart
+tool/scorecard.dart
+tool/spelunk.dart
+tool/util/path_utils.dart

pkg/linter/tool/checks/rules/no_solo_tests.dart

@@ -4,7 +4,7 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:linter/src/analyzer.dart';
 
 const _desc = r"Don't commit soloed tests.";
@@ -58,9 +58,9 @@ class _Visitor extends SimpleAstVisitor<void> {
 
 extension on Annotation {
   bool get isSoloTest {
-    var element = this.element;
-    return element is PropertyAccessorElement &&
+    var element = element2;
+    return element is GetterElement &&
         element.name == 'soloTest' &&
-        element.library.name == 'test_reflective_loader';
+        element.library2?.name == 'test_reflective_loader';
   }
 }

pkg/linter/tool/migrate.dart

@@ -10,6 +10,7 @@ import 'package:analyzer/error/error.dart';
 import 'package:args/args.dart';
 import 'package:collection/collection.dart';
 import 'package:linter/src/rules/analyzer_use_new_elements.dart';
+import 'package:path/path.dart' as path;
 
 import 'checks/driver.dart';
 
@@ -19,15 +20,16 @@ main(List<String> args) async {
     ..addFlag('write',
         abbr: 'w', help: 'Write updated `analyzer_use_new_elements.txt` file.');
 
-  var errors = await getOldElementModelAccesses(rulesDir.absolute.path);
+  var errors =
+      await getOldElementModelAccesses(directoryToMigrate.absolute.path);
 
   var errorFiles = <String>{};
   for (var error in errors) {
     errorFiles.add(error.source.fullName);
   }
 
   var migratedFiles =
-      ruleFiles.where((rule) => !errorFiles.any((f) => f.endsWith(rule)));
+      filesToMigrate.where((file) => !errorFiles.any((f) => f.endsWith(file)));
 
   var options = parser.parse(args);
   if (options['write'] == true) {
@@ -44,21 +46,21 @@ main(List<String> args) async {
   }
 
   print('Unmigrated files:\n\n');
-  for (var rule in ruleFiles) {
-    if (!migratedFiles.contains(rule)) {
-      print(rule);
+  for (var file in filesToMigrate) {
+    if (!migratedFiles.contains(file)) {
+      print(file);
     }
   }
 }
 
-final List<String> ruleFiles = rulesDir
+final Directory directoryToMigrate = Directory.current;
+
+final List<String> filesToMigrate = directoryToMigrate
     .listSync(recursive: true)
     .where((f) => f.path.endsWith('.dart'))
-    .map((r) => r.path)
+    .map((r) => path.relative(r.path, from: directoryToMigrate.path))
     .sorted();
 
-final Directory rulesDir = Directory('lib/src/rules');
-
 Future<List<AnalysisError>> getOldElementModelAccesses(String directory) async {
   var results = await Driver([AnalyzerUseNewElements(useOptInFile: false)])
       .analyze([directory]);