Skip to content

Commit 957c9a1

Browse files
stereotype441Commit Queue
authored andcommitted
Remove pkg/OWNERS.
The intention of this file was to allow any change to files in `pkg/` to be approved by anyone in OWNERS_ECOSYSTEM, OWNERS_FOUNDATION, or OWNERS_INFRA, but that if the package itself specifies other owners, then those owners should be preferred when suggesting owners. What was actually happening was that the `#{LAST_RESORT_SUGGESTION}` annotation only has an effect on lines that name a specific user; it is ignored on `file:` lines. (See docs at https://gerrit.googlesource.com/plugins/code-owners/+/refs/heads/master/resources/Documentation/backend-find-owners.md#annotations). So people in OWNERS_ECOSYSTEM, OWNERS_FOUNDATION, and OWNERS_INFRA were included in the suggested owners. Fortunately it was not too serious a problem in practice, because the "find owners" backend seems to have other heuristics that favor recent reviewers. But it still produced surprising output when using Gerrit's "suggest all owners" checkbox. I discussed this with [email protected], and we decided to just drop the `pkg/OWNERS` file altogether. There was one useful line in that file, assigning `pkg.status` to OWNERS_ENG. That has been moved to the top level OWNERS file. Change-Id: I8906ffcd18ffd35055f1401d40a3c3e7fc0eb3a2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414183 Auto-Submit: Paul Berry <[email protected]> Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Paul Berry <[email protected]>
1 parent 82c3d74 commit 957c9a1

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

OWNERS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,6 @@ per-file .clang-format,.gn,BUILD.gn,sdk_args.gni=file:/tools/OWNERS_BUILD
2424

2525
# Infrastructure files.
2626
per-file .style.yapf,codereview.settings,PRESUBMIT.py=file:/tools/OWNERS_INFRA
27+
28+
# Test status files
29+
per-file pkg.status=file:/tools/OWNERS_ENG

pkg/OWNERS

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)