[linter] Fixes use_named_constants for dot-shorthands

Fixes: #62206
Change-Id: I73633eb56f2ac9cd290dc884445d923485d09397
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/466901
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: FMorschel

pkg/linter/lib/src/rules/use_named_constants.dart

@@ -30,6 +30,7 @@ class UseNamedConstants extends AnalysisRule {
   ) {
     var visitor = _Visitor(this);
     registry.addInstanceCreationExpression(this, visitor);
+    registry.addDotShorthandConstructorInvocation(this, visitor);
   }
 }
 
@@ -38,41 +39,49 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   _Visitor(this.rule);
 
+  @override
+  void visitDotShorthandConstructorInvocation(
+    DotShorthandConstructorInvocation node,
+  ) {
+    if (node.isConst) {
+      _reportWhenMatchingConstant(node);
+    }
+  }
+
   @override
   void visitInstanceCreationExpression(InstanceCreationExpression node) {
     if (node.isConst) {
-      var type = node.staticType;
-      if (type is! InterfaceType) return;
-      var element = type.element;
-      if (element is ClassElement) {
-        var nodeField = node
-            .thisOrAncestorOfType<VariableDeclaration>()
-            ?.declaredFragment
-            ?.element;
+      _reportWhenMatchingConstant(node);
+    }
+  }
+
+  void _reportWhenMatchingConstant(Expression node) {
+    var type = node.staticType;
+    if (type is! InterfaceType) return;
+    var element = type.element;
+    if (element is ClassElement) {
+      var nodeField = node
+          .thisOrAncestorOfType<VariableDeclaration>()
+          ?.declaredFragment
+          ?.element;
 
-        // avoid diagnostic for fields in the same class having the same value
-        // class A {
-        //   const A();
-        //   static const a = A();
-        //   static const b = A();
-        // }
-        if (nodeField?.enclosingElement == element) return;
+      // avoid diagnostic for fields in the same class having the same value
+      // class A {
+      //   const A();
+      //   static const a = A();
+      //   static const b = A();
+      // }
+      if (nodeField?.enclosingElement == element) return;
 
-        var library =
-            (node.root as CompilationUnit).declaredFragment?.element.library;
-        if (library == null) return;
-        var value = node.computeConstantValue()?.value;
-        for (var field in element.fields.where(
-          (e) => e.isStatic && e.isConst,
-        )) {
-          if (field.isAccessibleIn(library) &&
-              field.computeConstantValue() == value) {
-            rule.reportAtNode(
-              node,
-              arguments: ['${element.name}.${field.name}'],
-            );
-            return;
-          }
+      var library =
+          (node.root as CompilationUnit).declaredFragment?.element.library;
+      if (library == null) return;
+      var value = node.computeConstantValue()?.value;
+      for (var field in element.fields.where((e) => e.isStatic && e.isConst)) {
+        if (field.isAccessibleIn(library) &&
+            field.computeConstantValue() == value) {
+          rule.reportAtNode(node, arguments: ['${element.name}.${field.name}']);
+          return;
         }
       }
     }

pkg/linter/test/rules/use_named_constants_test.dart

@@ -58,6 +58,36 @@ void f(A a) {
     );
   }
 
+  test_dotShorthand() async {
+    await assertDiagnostics(
+      r'''
+void f() {
+  const A a = .new(0);
+}
+class A {
+  const A(int value);
+  static const zero = A(0);
+}
+''',
+      [lint(25, 7)],
+    );
+  }
+
+  test_dotShorthand_const() async {
+    await assertDiagnostics(
+      r'''
+void f() {
+  A a = const .new(0);
+}
+class A {
+  const A(int value);
+  static const zero = A(0);
+}
+''',
+      [lint(19, 13)],
+    );
+  }
+
   test_duplicate_inDefinition() async {
     await assertNoDiagnostics(r'''
 class A {