Skip to content

Commit 9677798

Browse files
scheglovCommit Queue
authored andcommitted
Elements. Migrate MetadataElementTest.
Change-Id: Ifa10e395597bb86926ac67c2ea88734e02e34c9a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406162 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Phil Quitslund <[email protected]>
1 parent 32082be commit 9677798

File tree

1 file changed

+4
-27
lines changed

1 file changed

+4
-27
lines changed

pkg/analyzer/test/src/summary/elements/metadata_test.dart

Lines changed: 4 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// ignore_for_file: analyzer_use_new_elements
6-
7-
import 'package:analyzer/dart/element/element.dart';
8-
import 'package:analyzer/src/dart/element/element.dart';
95
import 'package:test/test.dart';
106
import 'package:test_reflective_loader/test_reflective_loader.dart';
117

@@ -408,9 +404,8 @@ class C {
408404
}
409405
''');
410406
// Check metadata without asking any other properties.
411-
var x = _elementOfDefiningUnit(library, ['@class', 'C', '@field', 'x'])
412-
as FieldElement;
413-
expect(x.metadata, hasLength(1));
407+
var x = library.getClass2('C')!.getField2('x')!;
408+
expect(x.metadata2.annotations, hasLength(1));
414409
// Check details.
415410
checkElementText(library, r'''
416411
library
@@ -10360,9 +10355,8 @@ const a = 0;
1036010355
int x = 0;
1036110356
''');
1036210357
// Check metadata without asking any other properties.
10363-
var x = _elementOfDefiningUnit(library, ['@topLevelVariable', 'x'])
10364-
as TopLevelVariableElement;
10365-
expect(x.metadata, hasLength(1));
10358+
var x = library.getTopLevelVariable('x')!;
10359+
expect(x.metadata2.annotations, hasLength(1));
1036610360
// Check details.
1036710361
checkElementText(library, r'''
1036810362
library
@@ -12076,23 +12070,6 @@ library
1207612070
firstFragment: <testLibraryFragment>::@class::C::@constructor::new
1207712071
''');
1207812072
}
12079-
12080-
// TODO(scheglov): This is duplicate.
12081-
Element _elementOfDefiningUnit(
12082-
LibraryElementImpl library, List<String> names) {
12083-
var reference = library.definingCompilationUnit.reference!;
12084-
for (var name in names) {
12085-
reference = reference.getChild(name);
12086-
}
12087-
12088-
var element = reference.element;
12089-
if (element != null) {
12090-
return element;
12091-
}
12092-
12093-
var elementFactory = library.linkedData!.elementFactory;
12094-
return elementFactory.elementOfReference(reference)!;
12095-
}
1209612073
}
1209712074

1209812075
@reflectiveTest

0 commit comments

Comments
 (0)