Format {_fe_analyzer_shared,front_end,kernel}/lib; update generated files to match package version

For the generated files (e.g. codes) we had gotten into a scenario
where the auto generated files was forced to be formatted as short
style, but if asking the dart formatter to format the
_fe_analyzer_shared file it would be formatted in long style because the
minimum version for _fe_analyzer_shared is now 3.7.

This CL updates the generators for the generated files to pass the
language version from the package config to the formatter.

Change-Id: I986ce1b5ff65244499ab5a277e78124f372ee46d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444300
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Jens Johansen <[email protected]>

Author: jensjoha

pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart

@@ -72,7 +72,8 @@ Future<CompilerResult?> kernelForProgramInternal(
     if (component == null) return null;
 
     if (requireMain && component.mainMethod == null) {
-      context.options.report(context,
+      context.options.report(
+          context,
           codeMissingMain.withLocation(source, -1, noLength),
           CfeSeverity.error);
       return null;

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -164,7 +164,8 @@ Future<Component?> compile(
     Component? component = compilerResult.component;
     if (component == null) return null;
     if (component.mainMethod == null) {
-      context.options.report(context,
+      context.options.report(
+          context,
           codeMissingMain.withLocation(inputs.single, -1, 0),
           CfeSeverity.error);
       return null;

pkg/front_end/lib/src/api_prototype/kernel_generator.dart

@@ -711,8 +711,7 @@ class ProcessedOptions {
           CfeSeverity.error);
     } catch (e) {
       // Coverage-ignore-block(suite): Not run.
-      reportWithoutLocation(
-          codeCantReadFile.withArguments(requestedUri, "$e"),
+      reportWithoutLocation(codeCantReadFile.withArguments(requestedUri, "$e"),
           CfeSeverity.error);
     }
     // Coverage-ignore(suite): Not run.

pkg/front_end/lib/src/api_unstable/dart2js.dart

@@ -32,9 +32,10 @@ dev_dependencies:
   expect: any
   json_rpc_2: any
   path: any
+  pub_semver: any
   test_reflective_loader: any
   test: any
   testing: any
-  vm: any
   vm_service: any
+  vm: any
   web_socket_channel: any

pkg/front_end/lib/src/base/processed_options.dart

@@ -10,7 +10,7 @@ import 'package:_fe_analyzer_shared/src/scanner/token.dart';
 import 'package:_fe_analyzer_shared/src/scanner/utf8_bytes_scanner.dart';
 import 'package:dart_style/dart_style.dart' show DartFormatter;
 
-import 'utils/io_utils.dart' show computeRepoDirUri;
+import 'utils/io_utils.dart' show computeRepoDirUri, getPackageVersionFor;
 
 void main(List<String> args) {
   final Uri repoDir = computeRepoDirUri();
@@ -111,8 +111,7 @@ class ParserTestListener implements Listener {
 
   out.writeln("}");
 
-  return new DartFormatter(
-          languageVersion: DartFormatter.latestShortStyleLanguageVersion)
+  return new DartFormatter(languageVersion: getPackageVersionFor("front_end"))
       .format("$out");
 }
 

pkg/front_end/pubspec.yaml

@@ -10,7 +10,7 @@ import 'package:_fe_analyzer_shared/src/scanner/token.dart';
 import 'package:_fe_analyzer_shared/src/scanner/utf8_bytes_scanner.dart';
 import 'package:dart_style/dart_style.dart' show DartFormatter;
 
-import 'utils/io_utils.dart' show computeRepoDirUri;
+import 'utils/io_utils.dart' show computeRepoDirUri, getPackageVersionFor;
 
 void main(List<String> args) {
   final Uri repoDir = computeRepoDirUri();
@@ -114,8 +114,7 @@ class TestParser extends Parser {
 
   out.writeln("}");
 
-  return new DartFormatter(
-          languageVersion: DartFormatter.latestShortStyleLanguageVersion)
+  return new DartFormatter(languageVersion: getPackageVersionFor("front_end"))
       .format("$out");
 }
 

pkg/front_end/test/parser_test_listener_creator.dart

@@ -5,6 +5,9 @@
 import 'dart:io' show Directory, File, Platform, Process, ProcessResult;
 
 import 'package:_fe_analyzer_shared/src/util/filenames.dart';
+import 'package:package_config/package_config.dart'
+    show PackageConfig, Package, LanguageVersion;
+import 'package:pub_semver/pub_semver.dart' show Version;
 
 String computeRepoDir() {
   Uri uri;
@@ -56,3 +59,26 @@ Uri computeRepoDirUri() {
   String dirPath = computeRepoDir();
   return new Directory(dirPath).uri;
 }
+
+Package? getPackageFor(String name) {
+  Uri packageConfigUri =
+      computeRepoDirUri().resolve(".dart_tool/package_config.json");
+  PackageConfig packageConfig = PackageConfig.parseBytes(
+      new File.fromUri(packageConfigUri).readAsBytesSync(), packageConfigUri);
+  for (Package package in packageConfig.packages) {
+    if (package.name == name) {
+      return package;
+    }
+  }
+  return null;
+}
+
+Version getPackageVersionFor(String name) {
+  Package? package = getPackageFor(name);
+  if (package == null) throw "Didn't find '$name' as a package.";
+  LanguageVersion? languageVersion = package.languageVersion;
+  if (languageVersion == null) {
+    throw "'$name' does not have a language version.";
+  }
+  return new Version(languageVersion.major, languageVersion.minor, 0);
+}

pkg/front_end/test/parser_test_parser_creator.dart

@@ -10,7 +10,8 @@ import 'package:_fe_analyzer_shared/src/sdk/allowed_experiments.dart';
 import 'package:dart_style/dart_style.dart' show DartFormatter;
 import 'package:yaml/yaml.dart' show YamlMap, loadYaml;
 
-import '../test/utils/io_utils.dart' show computeRepoDirUri;
+import '../test/utils/io_utils.dart'
+    show computeRepoDirUri, getPackageVersionFor;
 
 void main(List<String> arguments) {
   final Uri repoDir = computeRepoDirUri();
@@ -180,7 +181,7 @@ class Version {
 ''');
 
   return new DartFormatter(
-          languageVersion: DartFormatter.latestShortStyleLanguageVersion)
+          languageVersion: getPackageVersionFor("_fe_analyzer_shared"))
       .format("$sb");
 }
 
@@ -215,8 +216,7 @@ import "ast.dart";
 const Version defaultLanguageVersion = const Version($currentVersionMajor, $currentVersionMinor);
 ''');
 
-  return new DartFormatter(
-          languageVersion: DartFormatter.latestShortStyleLanguageVersion)
+  return new DartFormatter(languageVersion: getPackageVersionFor("kernel"))
       .format("$sb");
 }
 
@@ -530,8 +530,7 @@ const AllowedExperimentalFlags defaultAllowedExperimentalFlags =
   };
   ''');
 
-  return new DartFormatter(
-          languageVersion: DartFormatter.latestShortStyleLanguageVersion)
+  return new DartFormatter(languageVersion: getPackageVersionFor("front_end"))
       .format("$sb");
 }