Skip to content

Commit 9b33264

Browse files
committed
[dart2wasm] Keep static symbols in dart2wasm-*optimized-* builders
The optimized builders run with binaryen which by default strips static symbols (in all -Ox modes). So we'll pass `--no-strip-wasm` to `dart compile wasm` in order to keep the static symbols. This makes stack traces have the symbols in them which will make tests that rely on that more likely to work. Change-Id: I9e0eab8c4ec50ef3a7208551d04a80e9ffa009e8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406241 Reviewed-by: Ömer Ağacan <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
1 parent 52a5282 commit 9b33264

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tools/bots/test_matrix.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,8 @@
479479
"dart2wasm-(linux|mac|win)-optimized-(d8|jsshell|jsc|chrome|firefox)": {
480480
"options": {
481481
"dart2wasm-options": [
482-
"-O1"
482+
"-O1",
483+
"--no-strip-wasm"
483484
],
484485
"use-sdk": true,
485486
"host-asserts": false,

0 commit comments

Comments
 (0)