Skip to content

Commit 9b631bf

Browse files
liamappelbeCommit Queue
authored andcommitted
[deps] Roll dart-lang/native
Change-Id: I4a37c01fefdf00e128b7b2716ac893b3aed10171 Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403585 Reviewed-by: Liam Appelbe <[email protected]> Reviewed-by: Brian Quinlan <[email protected]> Reviewed-by: Nate Bosch <[email protected]> Commit-Queue: Liam Appelbe <[email protected]>
1 parent 6a1f9ed commit 9b631bf

File tree

5 files changed

+33
-32
lines changed

5 files changed

+33
-32
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ vars = {
141141
"markdown_rev": "19aaded4300d24bedcbf52ade792b203ddf030b0",
142142
"material_color_utilities_rev": "799b6ba2f3f1c28c67cc7e0b4f18e0c7d7f3c03e",
143143
# dart-native-interop-team@ is rolling breaking changes manually while the assets features are in experimental.
144-
"native_rev": "0f9cb0bea17cdd39bacc498e36d687d6baddd0a3", # disable tools/rev_sdk_deps.dart
144+
"native_rev": "14368a80bae9e3f381a2e59c91405338d82451ee", # disable tools/rev_sdk_deps.dart
145145
"package_config_rev": "07097d7ae60d40b34ce8daabdce318ecc168b7d1",
146146
"pool_rev": "bf27900420ba382b6e5c0484ab3c79daad703dcd",
147147
"protobuf_rev": "b7dd58cdbd879beee4c3fbf8ee80fce8e97bad26",

pkg/dartdev/lib/src/commands/build.dart

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -147,17 +147,17 @@ class BuildCommand extends DartdevCommand {
147147
final cCompilerConfig = getCCompilerConfig();
148148

149149
final buildResult = await nativeAssetsBuildRunner.build(
150-
configCreator: () => BuildConfigBuilder()
151-
..setupCodeConfig(
150+
inputCreator: () => BuildInputBuilder()
151+
..config.setupCode(
152152
targetOS: target.os,
153153
linkModePreference: LinkModePreference.dynamic,
154154
targetArchitecture: target.architecture,
155-
macOSConfig: macOSConfig,
156-
cCompilerConfig: cCompilerConfig,
155+
macOS: macOSConfig,
156+
cCompiler: cCompilerConfig,
157157
),
158-
configValidator: (config) async => [
159-
...await validateDataAssetBuildConfig(config),
160-
...await validateCodeAssetBuildConfig(config),
158+
inputValidator: (config) async => [
159+
...await validateDataAssetBuildInput(config),
160+
...await validateCodeAssetBuildInput(config),
161161
],
162162
workingDirectory: workingDirectory,
163163

@@ -205,17 +205,17 @@ class BuildCommand extends DartdevCommand {
205205

206206
// Start linking here.
207207
final linkResult = await nativeAssetsBuildRunner.link(
208-
configCreator: () => LinkConfigBuilder()
209-
..setupCodeConfig(
208+
inputCreator: () => LinkInputBuilder()
209+
..config.setupCode(
210210
targetOS: target.os,
211211
targetArchitecture: target.architecture,
212212
linkModePreference: LinkModePreference.dynamic,
213-
macOSConfig: macOSConfig,
214-
cCompilerConfig: cCompilerConfig,
213+
macOS: macOSConfig,
214+
cCompiler: cCompilerConfig,
215215
),
216-
configValidator: (config) async => [
217-
...await validateDataAssetLinkConfig(config),
218-
...await validateCodeAssetLinkConfig(config),
216+
inputValidator: (config) async => [
217+
...await validateDataAssetLinkInput(config),
218+
...await validateCodeAssetLinkInput(config),
219219
],
220220
resourceIdentifiers:
221221
recordUseEnabled ? Uri.file(recordedUsagesPath!) : null,

pkg/dartdev/lib/src/native_assets.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,18 +54,18 @@ Future<List<EncodedAsset>?> compileNativeAssetsJit({
5454
: null;
5555
final cCompilerConfig = getCCompilerConfig();
5656
final buildResult = await nativeAssetsBuildRunner.build(
57-
configCreator: () => BuildConfigBuilder()
58-
..setupCodeConfig(
57+
inputCreator: () => BuildInputBuilder()
58+
..config.setupCode(
5959
targetOS: target.os,
6060
targetArchitecture: target.architecture,
6161
// When running in JIT mode, only dynamic libraries are supported.
6262
linkModePreference: LinkModePreference.dynamic,
63-
macOSConfig: macOSConfig,
64-
cCompilerConfig: cCompilerConfig,
63+
macOS: macOSConfig,
64+
cCompiler: cCompilerConfig,
6565
),
66-
configValidator: (config) async => [
67-
...await validateCodeAssetBuildConfig(config),
68-
...await validateDataAssetBuildConfig(config),
66+
inputValidator: (config) async => [
67+
...await validateCodeAssetBuildInput(config),
68+
...await validateDataAssetBuildInput(config),
6969
],
7070
workingDirectory: workingDirectory,
7171
runPackageName: runPackageName,

pkg/record_use/test_data/drop_dylib_recording/hook/build.dart

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,14 @@ import 'package:native_assets_cli/code_assets.dart';
77
import 'package:native_toolchain_c/native_toolchain_c.dart';
88

99
void main(List<String> arguments) async {
10-
await build(arguments, (config, output) async {
10+
await build(arguments, (input, output) async {
1111
final logger = Logger('')
1212
..level = Level.ALL
1313
..onRecord.listen((record) {
1414
print('${record.level.name}: ${record.time}: ${record.message}');
1515
});
16-
final linkInPackage = config.linkingEnabled ? config.packageName : null;
16+
final linkInPackage =
17+
input.config.linkingEnabled ? input.packageName : null;
1718
await CBuilder.library(
1819
name: 'add',
1920
assetName: 'dylib_add',
@@ -22,7 +23,7 @@ void main(List<String> arguments) async {
2223
],
2324
linkModePreference: LinkModePreference.dynamic,
2425
).run(
25-
config: config,
26+
input: input,
2627
output: output,
2728
logger: logger,
2829
linkInPackage: linkInPackage,
@@ -36,7 +37,7 @@ void main(List<String> arguments) async {
3637
],
3738
linkModePreference: LinkModePreference.dynamic,
3839
).run(
39-
config: config,
40+
input: input,
4041
output: output,
4142
logger: logger,
4243
linkInPackage: linkInPackage,

pkg/record_use/test_data/drop_dylib_recording/hook/link.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,18 @@ final instanceId = const Identifier(
2626
);
2727

2828
void main(List<String> arguments) async {
29-
await link(arguments, (config, output) async {
30-
final file = File.fromUri(config.recordedUsagesFile!);
29+
await link(arguments, (input, output) async {
30+
final file = File.fromUri(input.recordedUsagesFile!);
3131
final string = await file.readAsString();
3232
final usages =
3333
RecordedUsages.fromJson(jsonDecode(string) as Map<String, dynamic>);
3434

35-
final codeAssets = config.codeAssets;
35+
final codeAssets = input.assets.code;
3636
print('Received assets: ${codeAssets.map((a) => a.id).join(', ')}.');
3737

3838
final symbols = <String>{};
3939
final argumentsFile =
40-
await File.fromUri(config.outputDirectory.resolve('arguments.txt'))
40+
await File.fromUri(input.outputDirectory.resolve('arguments.txt'))
4141
.create();
4242

4343
final dataLines = <String>[];
@@ -71,8 +71,8 @@ void main(List<String> arguments) async {
7171
];
7272

7373
print('Keeping only ${neededCodeAssets.map((e) => e.id).join(', ')}.');
74-
output.codeAssets.addAll(neededCodeAssets);
74+
output.assets.code.addAll(neededCodeAssets);
7575

76-
output.addDependency(config.packageRoot.resolve('hook/link.dart'));
76+
output.addDependency(input.packageRoot.resolve('hook/link.dart'));
7777
});
7878
}

0 commit comments

Comments
 (0)