Elements. Print isSynthetic, do not print not useful flags of property related fragments.

Change-Id: Ic8f44bb3fd1ff58f261bdce2eaec2b9ca63c4b6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395423
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/dart/element/element2.dart

@@ -658,6 +658,13 @@ abstract class ExecutableFragment implements FunctionTypedFragment {
   /// Whether the body is marked as being synchronous.
   bool get isSynchronous;
 
+  /// Whether this fragment is synthetic.
+  ///
+  /// A synthetic fragment is a fragment that is not represented in the source
+  /// code explicitly, but is implied by the source code, such as the default
+  /// constructor for a class that does not explicitly define any constructors.
+  bool get isSynthetic;
+
   @override
   LibraryFragment get libraryFragment;
 
@@ -2123,16 +2130,10 @@ abstract class PropertyInducingFragment
 
   /// Whether the element is an augmentation.
   ///
-  /// Property indicing fragments are augmentations if they are explicitly
+  /// Property inducing fragments are augmentations if they are explicitly
   /// marked as such using the 'augment' modifier.
   bool get isAugmentation;
 
-  /// Whether the fragment is a static fragment.
-  ///
-  /// A static fragment is a fragment that is not associated with a particular
-  /// instance, but rather with an entire library or class.
-  bool get isStatic;
-
   /// Whether this fragment is synthetic.
   ///
   /// A synthetic fragment is a fragment that is not represented in the source
@@ -2547,15 +2548,6 @@ abstract class VariableFragment implements Fragment {
   @override
   VariableElement2 get element;
 
-  /// Whether the variable was declared with the 'const' modifier.
-  bool get isConst;
-
-  /// Whether the variable was declared with the 'final' modifier.
-  ///
-  /// Variables that are declared with the 'const' modifier will return `false`
-  /// even though they are implicitly final.
-  bool get isFinal;
-
   @override
   VariableFragment? get nextFragment;
 

pkg/analyzer/lib/src/dart/element/element.dart

@@ -4362,7 +4362,7 @@ class FormalParameterElementImpl extends PromotableElementImpl2
 
   @override
   // TODO(augmentations): Implement the merge of formal parameters.
-  bool get isFinal => firstFragment.isFinal;
+  bool get isFinal => wrappedElement.isFinal;
 
   @override
   bool get isInitializingFormal => wrappedElement.isInitializingFormal;

pkg/analyzer/test/src/summary/element_text.dart

@@ -485,16 +485,14 @@ class _Element2Writer extends _AbstractElementWriter {
     _sink.writeIndentedLine(() {
       _sink.writeIf(e.isSynthetic, 'synthetic ');
       _sink.writeIf(e.isStatic, 'static ');
-      _sink.writeIf(e is FieldElementImpl && e.isAbstract, 'abstract ');
-      _sink.writeIf(e is FieldElementImpl && e.isCovariant, 'covariant ');
-      _sink.writeIf(e is FieldElementImpl && e.isExternal, 'external ');
+      _sink.writeIf(e.isAbstract, 'abstract ');
+      _sink.writeIf(e.isCovariant, 'covariant ');
+      _sink.writeIf(e.isExternal, 'external ');
       _sink.writeIf(e.isLate, 'late ');
       _sink.writeIf(e.isFinal, 'final ');
       _sink.writeIf(e.isConst, 'const ');
-      if (e is FieldElementImpl) {
-        _sink.writeIf(e.isEnumConstant, 'enumConstant ');
-        _sink.writeIf(e.isPromotable, 'promotable ');
-      }
+      _sink.writeIf(e.isEnumConstant, 'enumConstant ');
+      _sink.writeIf(e.isPromotable, 'promotable ');
 
       _writeElementName(e);
     });
@@ -550,19 +548,8 @@ class _Element2Writer extends _AbstractElementWriter {
     // }
 
     _sink.writeIndentedLine(() {
-      // _sink.writeIf(f.isAugmentation, 'augment ');
-      // _sink.writeIf(f.isSynthetic, 'synthetic ');
-      // _sink.writeIf(f.isStatic, 'static ');
-      _sink.writeIf(f is FieldElementImpl && f.isAbstract, 'abstract ');
-      _sink.writeIf(f is FieldElementImpl && f.isCovariant, 'covariant ');
-      _sink.writeIf(f is FieldElementImpl && f.isExternal, 'external ');
-      // _sink.writeIf(f.isLate, 'late ');
-      // _sink.writeIf(f.isFinal, 'final ');
-      // _sink.writeIf(f.isConst, 'const ');
-      if (f is FieldElementImpl) {
-        _sink.writeIf(f.isEnumConstant, 'enumConstant ');
-        _sink.writeIf(f.isPromotable, 'promotable ');
-      }
+      _sink.writeIf(f.isAugmentation, 'augment ');
+      _sink.writeIf(f.isSynthetic, 'synthetic ');
 
       _writeFragmentName(f);
     });
@@ -899,13 +886,9 @@ class _Element2Writer extends _AbstractElementWriter {
 
     _sink.writeIndentedLine(() {
       _sink.writeIf(f.isAugmentation, 'augment ');
-      // _sink.writeIf(e.isSynthetic, 'synthetic ');
-      // _sink.writeIf(e.isStatic, 'static ');
-      // _sink.writeIf(e.isAbstract, 'abstract ');
-      // _sink.writeIf(e.isExternal, 'external ');
+      _sink.writeIf(f.isSynthetic, 'synthetic ');
 
       _sink.write('get ');
-
       _writeFragmentName(f);
       // _writeBodyModifiers(e);
     });
@@ -1690,10 +1673,7 @@ class _Element2Writer extends _AbstractElementWriter {
 
     _sink.writeIndentedLine(() {
       _sink.writeIf(f.isAugmentation, 'augment ');
-      // _sink.writeIf(f.isSynthetic, 'synthetic ');
-      // _sink.writeIf(f.isStatic, 'static ');
-      // _sink.writeIf(f.isAbstract, 'abstract ');
-      // _sink.writeIf(f.isExternal, 'external ');
+      _sink.writeIf(f.isSynthetic, 'synthetic ');
 
       _sink.write('set ');
       _writeFragmentName(f);
@@ -1883,9 +1863,7 @@ class _Element2Writer extends _AbstractElementWriter {
     _sink.writeIndentedLine(() {
       _sink.writeIf(f.isAugmentation, 'augment ');
       _sink.writeIf(f.isSynthetic, 'synthetic ');
-      // _sink.writeIf(f.isLate, 'late ');
-      _sink.writeIf(f.isFinal, 'final ');
-      _sink.writeIf(f.isConst, 'const ');
+
       _writeFragmentName(f);
     });