[test] Synthetic versions of the mutator-marker race.

TEST=vm/cc/MutatorMarkerRace_*
Bug: #56895
Change-Id: I3e3f25b2c43aec09a409377f77c6d2fec287bccb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390263
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>

Author: rmacnak-google

runtime/platform/BUILD.gn

@@ -11,6 +11,7 @@ library_for_all_configs("libdart_platform") {
   sources = platform_sources
   include_dirs = [ ".." ]
   extra_deps = []
+  configurable_deps = [ ":libdart_platform_no_tsan" ]
 
   if (is_fuchsia) {
     extra_deps += [
@@ -19,3 +20,22 @@ library_for_all_configs("libdart_platform") {
     ]
   }
 }
+
+config("no_tsan_config") {
+  if (!is_win) {
+    cflags = [ "-fno-sanitize=thread" ]
+  }
+}
+
+library_for_all_configs("libdart_platform_no_tsan") {
+  target_type = "source_set"
+  public_configs = [
+    "../vm:libdart_vm_config",
+    ":no_tsan_config",
+  ]
+  sources = [
+    "no_tsan.cc",
+    "no_tsan.h",
+  ]
+  include_dirs = [ ".." ]
+}

runtime/platform/no_tsan.cc

@@ -0,0 +1,33 @@
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#include "platform/no_tsan.h"
+
+namespace dart {
+
+#if defined(__clang__)
+
+#if defined(__has_feature)
+#if __has_feature(thread_sanitizer)
+#error Misconfigured build
+#endif
+#endif
+
+uintptr_t FetchAndRelaxedIgnoreRace(std::atomic<uintptr_t>* ptr,
+                                    uintptr_t value) {
+  return ptr->fetch_and(value, std::memory_order_relaxed);
+}
+
+uintptr_t FetchOrRelaxedIgnoreRace(std::atomic<uintptr_t>* ptr,
+                                   uintptr_t value) {
+  return ptr->fetch_or(value, std::memory_order_relaxed);
+}
+
+uintptr_t LoadRelaxedIgnoreRace(const std::atomic<uintptr_t>* ptr) {
+  return ptr->load(std::memory_order_relaxed);
+}
+
+#endif  // defined(__clang__)
+
+}  // namespace dart

runtime/platform/no_tsan.h

@@ -0,0 +1,48 @@
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#ifndef RUNTIME_PLATFORM_NO_TSAN_H_
+#define RUNTIME_PLATFORM_NO_TSAN_H_
+
+#include <stdint.h>
+
+#include <atomic>
+
+namespace dart {
+
+#if defined(__clang__)
+// Clang does not honor no_sanitize(thread) for std::atomic, so we place
+// the implementation in a separate compilation unit with TSAN disabled.
+uintptr_t FetchAndRelaxedIgnoreRace(std::atomic<uintptr_t>* ptr,
+                                    uintptr_t value);
+uintptr_t FetchOrRelaxedIgnoreRace(std::atomic<uintptr_t>* ptr,
+                                   uintptr_t value);
+uintptr_t LoadRelaxedIgnoreRace(const std::atomic<uintptr_t>* ptr);
+#else
+#if defined(__GNUC__)
+__attribute__((no_sanitize("thread")))
+#endif
+inline uintptr_t
+FetchAndRelaxedIgnoreRace(std::atomic<uintptr_t>* ptr, uintptr_t value) {
+  return ptr->fetch_and(value, std::memory_order_relaxed);
+}
+#if defined(__GNUC__)
+__attribute__((no_sanitize("thread")))
+#endif
+inline uintptr_t
+FetchOrRelaxedIgnoreRace(std::atomic<uintptr_t>* ptr, uintptr_t value) {
+  return ptr->fetch_or(value, std::memory_order_relaxed);
+}
+#if defined(__GNUC__)
+__attribute__((no_sanitize("thread")))
+#endif
+inline uintptr_t
+LoadRelaxedIgnoreRace(const std::atomic<uintptr_t>* ptr) {
+  return ptr->load(std::memory_order_relaxed);
+}
+#endif
+
+}  // namespace dart
+
+#endif  // RUNTIME_PLATFORM_NO_TSAN_H_

runtime/tests/vm/vm.status

@@ -11,6 +11,8 @@ cc/IsolateReload_PendingStaticCall_DefinedToNSM: Fail # Issue 32981
 cc/IsolateReload_PendingStaticCall_NSMToDefined: Fail, Crash # Issue 32981. Fails on non-Windows, crashes on Windows (because of test.py special handline)
 cc/IsolateReload_PendingUnqualifiedCall_InstanceToStatic: Fail # Issue 32981
 cc/IsolateReload_PendingUnqualifiedCall_StaticToInstance: Fail # Issue 32981
+cc/MutatorMarkerRace_Relaxed: Pass, Fail # Comparison to demonstrate race, failure seen on Mac M1.
+cc/MutatorMarkerRace_ReleaseHeader: Pass, Fail # Comparison to demonstrate race, failure seen on Windows Snapdragon.
 cc/TTS_STC_ManyAsserts: Pass, Slow # Generates 10k classes that are put into an STC via assert checks.
 cc/TypeArguments_Cache_ManyInstantiations: Pass, Slow
 dart/analyze_snapshot_binary_test: Pass, Slow # Runs various subprocesses for testing AOT.

runtime/vm/class_table.cc

@@ -85,6 +85,10 @@ void ClassTable::Register(const Class& cls) {
         classes_.GetColumn<kClassIndex>());
     UpdateCachedAllocationTracingStateTablePointer();
   } else {
+    // GCC warns that TSAN doesn't understand thread fences.
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic ignored "-Wtsan"
+#endif
     std::atomic_thread_fence(std::memory_order_release);
   }
 }