[analyzer] Produce CONST_EVAL_EXTENSION_METHOD diagnostic when using extension methods in const contexts.

More specific error code.

Semi-related to work in https://dart-review.googlesource.com/c/sdk/+/301505.

Change-Id: I1233e9e31389d387a9c777fe83cdd30a224bd00e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310760
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -380,6 +380,8 @@ CompileTimeErrorCode.CONST_DEFERRED_CLASS:
   status: needsFix
   notes: |-
     Remove the `deferred` keyword from the import.
+CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD:
+  status: needsEvaluation
 CompileTimeErrorCode.CONST_EVAL_FOR_ELEMENT:
   status: needsEvaluation
 CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION:

pkg/analyzer/lib/src/dart/constant/constant_verifier.dart

@@ -552,6 +552,8 @@ class ConstantVerifier extends RecursiveAstVisitor<void> {
       AnalysisError data = errors[i];
       ErrorCode dataErrorCode = data.errorCode;
       if (identical(dataErrorCode,
+              CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD) ||
+          identical(dataErrorCode,
               CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION) ||
           identical(
               dataErrorCode, CompileTimeErrorCode.CONST_EVAL_THROWS_IDBZE) ||

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -593,8 +593,11 @@ class ConstantVisitor extends UnifyingAstVisitor<Constant> {
   @override
   Constant? visitBinaryExpression(BinaryExpression node) {
     if (node.staticElement?.enclosingElement is ExtensionElement) {
-      _error(node, null);
-      return null;
+      // TODO(kallentu): Don't report error here.
+      _errorReporter.reportErrorForNode(
+          CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD, node);
+      return InvalidConstant(
+          node, CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD);
     }
 
     TokenType operatorType = node.operator.type;
@@ -1084,8 +1087,11 @@ class ConstantVisitor extends UnifyingAstVisitor<Constant> {
       return null;
     }
     if (node.staticElement?.enclosingElement is ExtensionElement) {
-      _error(node, null);
-      return null;
+      // TODO(kallentu): Don't report error here.
+      _errorReporter.reportErrorForNode(
+          CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD, node);
+      return InvalidConstant(
+          node, CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD);
     }
     if (node.operator.type == TokenType.BANG) {
       return _dartObjectComputer.logicalNot(node, operand);

pkg/analyzer/lib/src/error/codes.g.dart

@@ -795,6 +795,12 @@ class CompileTimeErrorCode extends AnalyzerErrorCode {
     hasPublishedDocs: true,
   );
 
+  static const CompileTimeErrorCode CONST_EVAL_EXTENSION_METHOD =
+      CompileTimeErrorCode(
+    'CONST_EVAL_EXTENSION_METHOD',
+    "Extension methods can't be used in constant expressions.",
+  );
+
   static const CompileTimeErrorCode CONST_EVAL_FOR_ELEMENT =
       CompileTimeErrorCode(
     'CONST_EVAL_FOR_ELEMENT',

pkg/analyzer/lib/src/error/error_code_values.g.dart

@@ -109,6 +109,7 @@ const List<ErrorCode> errorCodeValues = [
   CompileTimeErrorCode.CONST_CONSTRUCTOR_WITH_NON_CONST_SUPER,
   CompileTimeErrorCode.CONST_CONSTRUCTOR_WITH_NON_FINAL_FIELD,
   CompileTimeErrorCode.CONST_DEFERRED_CLASS,
+  CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD,
   CompileTimeErrorCode.CONST_EVAL_FOR_ELEMENT,
   CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION,
   CompileTimeErrorCode.CONST_EVAL_THROWS_IDBZE,

pkg/analyzer/lib/src/lint/linter.dart

@@ -904,6 +904,7 @@ class _ConstantAnalysisErrorListener extends AnalysisErrorListener {
       switch (errorCode) {
         case CompileTimeErrorCode
               .CONST_CONSTRUCTOR_WITH_FIELD_INITIALIZED_BY_NON_CONST:
+        case CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD:
         case CompileTimeErrorCode.CONST_EVAL_TYPE_BOOL:
         case CompileTimeErrorCode.CONST_EVAL_TYPE_BOOL_INT:
         case CompileTimeErrorCode.CONST_EVAL_TYPE_BOOL_NUM_STRING:

pkg/analyzer/messages.yaml

@@ -2568,6 +2568,8 @@ CompileTimeErrorCode:
 
       const json2 = convert.JsonCodec();
       ```
+  CONST_EVAL_EXTENSION_METHOD:
+    problemMessage: "Extension methods can't be used in constant expressions."
   CONST_EVAL_FOR_ELEMENT:
     problemMessage: "Constant expressions don't support 'for' elements."
     correctionMessage: "Try replacing the 'for' element with a spread, or removing 'const'."

pkg/analyzer/test/generated/constant_test.dart

@@ -368,26 +368,6 @@ const [for (var i = 0; i < 4; i++) i]
     await _assertValueInt(-42, "-42");
   }
 
-  test_negated_object_hasExtension() async {
-    await assertErrorsInCode('''
-extension on Object {
-  int operator -() => 0;
-}
-
-const Object v1 = 1;
-const v2 = -v1;
-''', [
-      error(CompileTimeErrorCode.CONST_INITIALIZED_WITH_NON_CONSTANT_VALUE, 82,
-          3),
-    ]);
-
-    final v2 = findElement.topVar('v2');
-    final evaluationResult = v2.evaluationResult;
-    assertDartObjectText(evaluationResult.value, r'''
-<null>
-''');
-  }
-
   /// Even though it is an error to specify a default value for a required
   /// parameter, we still can evaluate it.
   test_normalParameter_requiredNamed_hasDefault() async {
@@ -577,26 +557,6 @@ E<String>
     await _assertValueInt(5, "2 + 3");
   }
 
-  test_plus_object_hasExtension() async {
-    await assertErrorsInCode('''
-extension on Object {
-  int operator +(Object other) => 0;
-}
-
-const Object v1 = 0;
-const v2 = v1 + v1;
-''', [
-      error(CompileTimeErrorCode.CONST_INITIALIZED_WITH_NON_CONSTANT_VALUE, 94,
-          7),
-    ]);
-
-    final v2 = findElement.topVar('v2');
-    final evaluationResult = v2.evaluationResult;
-    assertDartObjectText(evaluationResult.value, r'''
-<null>
-''');
-  }
-
   test_plus_string_string() async {
     await _assertValueString("ab", "'a' + 'b'");
   }

pkg/analyzer/test/src/dart/constant/evaluation_test.dart

@@ -483,6 +483,20 @@ const c = identical(int, int);
     );
   }
 
+  test_visitBinaryExpression_extensionMethod() async {
+    await assertErrorsInCode('''
+extension on Object {
+  int operator +(Object other) => 0;
+}
+
+const Object v1 = 0;
+const v2 = v1 + v1;
+''', [
+      error(CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD, 94, 7),
+    ]);
+    _assertNull('v2');
+  }
+
   test_visitBinaryExpression_gtGtGt_negative_fewerBits() async {
     await resolveTestCode('''
 const c = 0xFFFFFFFF >>> 8;
@@ -1383,6 +1397,20 @@ const void Function(int) h = self.g;
     _assertTypeArguments(result, ['int']);
   }
 
+  test_visitPrefixExpression_extensionMethod() async {
+    await assertErrorsInCode('''
+extension on Object {
+  int operator -() => 0;
+}
+
+const Object v1 = 1;
+const v2 = -v1;
+''', [
+      error(CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD, 82, 3),
+    ]);
+    _assertNull('v2');
+  }
+
   test_visitPropertyAccess_genericFunction_instantiated() async {
     await resolveTestCode('''
 import '' as self;

pkg/analyzer/test/src/diagnostics/const_eval_extension_method_test.dart

@@ -0,0 +1,43 @@
+// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:analyzer/src/error/codes.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+
+import '../dart/resolution/context_collection_resolution.dart';
+
+main() {
+  defineReflectiveSuite(() {
+    defineReflectiveTests(ConstEvalExtensionMethodTest);
+  });
+}
+
+@reflectiveTest
+class ConstEvalExtensionMethodTest extends PubPackageResolutionTest {
+  test_binaryExpression() async {
+    await assertErrorsInCode('''
+extension on Object {
+  int operator +(Object other) => 0;
+}
+
+const Object v1 = 0;
+const v2 = v1 + v1;
+''', [
+      error(CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD, 94, 7),
+    ]);
+  }
+
+  test_prefixExpression() async {
+    await assertErrorsInCode('''
+extension on Object {
+  int operator -() => 0;
+}
+
+const Object v1 = 1;
+const v2 = -v1;
+''', [
+      error(CompileTimeErrorCode.CONST_EVAL_EXTENSION_METHOD, 82, 3),
+    ]);
+  }
+}