Fine. Add @trackedInternal marker.

Change-Id: Idabe772d7de2d1a0f3a9d0a2ea71cc3050bb8c3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448225
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -4637,6 +4637,7 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
   List<ConstructorElementImpl> _constructors = _Sentinel.constructorElement;
 
   /// This callback is set during mixins inference to handle reentrant calls.
+  @trackedInternal
   List<InterfaceTypeImpl>? Function(InterfaceElementImpl)?
   mixinInferenceCallback;
 

pkg/analyzer/lib/src/fine/annotations.dart

@@ -65,6 +65,13 @@ const trackedIncludedInId = _TrackedIncludedInId();
 /// class.
 const trackedIndirectly = _TrackedIndirectly();
 
+/// Annotation for methods that used internally while building elements,
+/// but are not supposed to be used by any client.
+///
+/// Such methods of course are never API, and potential clients could only
+/// be other parts of the analyzer itself.
+const trackedInternal = _TrackedInternal();
+
 final class _ElementClass {
   const _ElementClass();
 }
@@ -89,6 +96,10 @@ final class _TrackedIndirectly extends _TrackedKind {
   const _TrackedIndirectly();
 }
 
+final class _TrackedInternal extends _TrackedKind {
+  const _TrackedInternal();
+}
+
 /// Superclass for all specific kinds of tracking annotations.
 sealed class _TrackedKind {
   const _TrackedKind();

pkg/linter/lib/src/rules/analyzer_element_model_tracking.dart

@@ -105,7 +105,8 @@ class _Visitor extends SimpleAstVisitor<void> {
                         annotation.element.isTrackedDirectlyExpensive ||
                         annotation.element.isTrackedDirectlyOpaque ||
                         annotation.element.isTrackedIncludedInId ||
-                        annotation.element.isTrackedIndirectly) {
+                        annotation.element.isTrackedIndirectly ||
+                        annotation.element.isTrackedInternal) {
                       if (hasRequired) {
                         _reportMoreThanOne(annotation);
                       }
@@ -133,7 +134,8 @@ class _Visitor extends SimpleAstVisitor<void> {
                         annotation.element.isTrackedDirectlyExpensive ||
                         annotation.element.isTrackedDirectlyOpaque ||
                         annotation.element.isTrackedIncludedInId ||
-                        annotation.element.isTrackedIndirectly) {
+                        annotation.element.isTrackedIndirectly ||
+                        annotation.element.isTrackedInternal) {
                       if (hasRequired) {
                         _reportMoreThanOne(annotation);
                       }
@@ -193,7 +195,8 @@ extension on ElementAnnotation {
       isTrackedDirectlyExpensive ||
       isTrackedDirectlyOpaque ||
       isTrackedIncludedInId ||
-      isTrackedIndirectly;
+      isTrackedIndirectly ||
+      isTrackedInternal;
 
   bool get isElementClass => _isAnnotation('elementClass');
 
@@ -208,6 +211,8 @@ extension on ElementAnnotation {
 
   bool get isTrackedIndirectly => _isAnnotation('trackedIndirectly');
 
+  bool get isTrackedInternal => _isAnnotation('trackedInternal');
+
   bool _isAnnotation(String name) {
     if (element case GetterElement element) {
       return element.name == name &&

pkg/linter/test/rules/analyzer_element_model_tracking_test.dart

@@ -262,6 +262,18 @@ class A {
 ''');
   }
 
+  test_public_instancePublic_getter_trackedInternal() async {
+    await assertNoDiagnostics(r'''
+import 'package:analyzer/src/fine/annotations.dart';
+
+@elementClass
+class A {
+  @trackedInternal
+  int get foo => 0;
+}
+''');
+  }
+
   test_public_instancePublic_method_noAnnotation() async {
     await assertDiagnostics(
       r'''
@@ -374,6 +386,18 @@ class A {
 ''');
   }
 
+  test_public_instancePublic_method_trackedInternal() async {
+    await assertNoDiagnostics(r'''
+import 'package:analyzer/src/fine/annotations.dart';
+
+@elementClass
+class A {
+  @trackedInternal
+  int foo() => 0;
+}
+''');
+  }
+
   test_public_staticPrivate_field_trackedIncludedInId() async {
     await assertDiagnostics(
       r'''