[analyzer] Cache/reuse CorrectionUtils

For `lsp_many_prefer_single_quotes_violations_benchmark.dart --sizes=3200`:

Before:
Initial analysis: 0.119093
First code action call: 2.632948
Subsequent action call 1: 2.176926
Subsequent action call 2: 2.316560
Select all code action call: 8.269120

Now:
Initial analysis: 0.105622
First code action call: 2.629498
Subsequent action call 1: 2.240760
Subsequent action call 2: 2.354467
Select all code action call: 6.873468

Change-Id: Ic967e54592d96057e20a8d70355e47d5232653a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426180
Commit-Queue: Jens Johansen <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: jensjoha

pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart

@@ -18,6 +18,7 @@ import 'package:analysis_server/src/services/refactoring/legacy/refactoring.dart
 import 'package:analysis_server/src/utilities/extensions/ast.dart';
 import 'package:analysis_server_plugin/edit/assist/assist.dart';
 import 'package:analysis_server_plugin/edit/assist/dart_assist_context.dart';
+import 'package:analysis_server_plugin/edit/correction_utils.dart';
 import 'package:analysis_server_plugin/edit/fix/dart_fix_context.dart';
 import 'package:analysis_server_plugin/src/correction/assist_performance.dart';
 import 'package:analysis_server_plugin/src/correction/assist_processor.dart';
@@ -210,6 +211,7 @@ class DartCodeActionsProducer extends AbstractCodeActionsProducer {
       Set<String>? skipAlreadyCalculatedIfNonNull =
           willBeDeduplicated ? {} : null;
       var workspace = DartChangeWorkspace(await server.currentSessions);
+      CorrectionUtils? correctionUtils;
       for (var error in unitResult.errors) {
         // Return fixes for any part of the line where a diagnostic is.
         // If a diagnostic spans multiple lines, the fix will be included for
@@ -228,6 +230,7 @@ class DartCodeActionsProducer extends AbstractCodeActionsProducer {
           libraryResult: libraryResult,
           unitResult: unitResult,
           error: error,
+          correctionUtils: correctionUtils ??= CorrectionUtils(unitResult),
         );
 
         var performanceTracker = FixPerformance();

pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart

@@ -244,7 +244,7 @@ final class CorrectionProducerContext {
   })  : _libraryResult = libraryResult,
         _unitResult = unitResult,
         _sessionHelper = AnalysisSessionHelper(unitResult.session),
-        _utils = CorrectionUtils(unitResult),
+        _utils = dartFixContext?.correctionUtils ?? CorrectionUtils(unitResult),
         _applyingBulkFixes = applyingBulkFixes,
         _diagnostic = diagnostic,
         _token = token,

pkg/analysis_server_plugin/lib/edit/fix/dart_fix_context.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analysis_server_plugin/edit/correction_utils.dart';
 import 'package:analysis_server_plugin/edit/fix/fix_context.dart';
 import 'package:analysis_server_plugin/src/correction/change_workspace.dart';
 import 'package:analyzer/dart/analysis/results.dart';
@@ -37,6 +38,9 @@ class DartFixContext implements FixContext {
   /// The unit result in which the fix operates.
   final ResolvedUnitResult unitResult;
 
+  // The [CorrectionUtils] for the unit result.
+  final CorrectionUtils correctionUtils;
+
   /// The workspace in which the fix contributor operates.
   final ChangeWorkspace workspace;
 
@@ -58,7 +62,8 @@ class DartFixContext implements FixContext {
     required this.unitResult,
     required this.error,
     this.autoTriggered = false,
-  });
+    CorrectionUtils? correctionUtils,
+  }) : correctionUtils = correctionUtils ?? CorrectionUtils(unitResult);
 
   /// Returns the mapping from each library (that is available to this context)
   /// to a top-level declaration that is exported (not necessary declared) by

pkg/analysis_server_plugin/lib/src/correction/fix_in_file_processor.dart

@@ -69,6 +69,7 @@ final class FixInFileProcessor {
           libraryResult: _fixContext.libraryResult,
           unitResult: _fixContext.unitResult,
           error: error,
+          correctionUtils: _fixContext.correctionUtils,
         );
         fixState = await _fixDiagnostic(fixContext, fixState, generator, error);
 
@@ -85,6 +86,7 @@ final class FixInFileProcessor {
             libraryResult: _fixContext.libraryResult,
             unitResult: _fixContext.unitResult,
             error: error,
+            correctionUtils: _fixContext.correctionUtils,
           );
           fixState =
               await _fixDiagnostic(fixContext, fixState, generator, error);