Fix bug with change parameter type when there are no parameters in argument list

Change-Id: I5cabd16091cb66be45f107a3701128776e8129ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/310820
Commit-Queue: Keerti Parthasarathy <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: keertip

pkg/analysis_server/lib/src/services/correction/fix/data_driven/modify_parameters.dart

@@ -126,7 +126,9 @@ class ModifyParameters extends Change<_Data> {
           // that the parameter was absent.
           var index = reference is PositionalFormalParameterReference
               ? reference.index
-              : remainingArguments.last + 1;
+              : remainingArguments.isNotEmpty
+                  ? remainingArguments.last + 1
+                  : 0;
           remainingArguments.add(index);
           indexToNewArgumentMap[index] = modification;
           argumentsToInsert.add(index);
@@ -229,11 +231,13 @@ class ModifyParameters extends Change<_Data> {
               offset = arguments[remainingIndex - 1].end;
               needsInitialComma = true;
             } else {
-              offset = arguments[remainingIndex].offset;
+              offset = arguments.isNotEmpty
+                  ? arguments[remainingIndex].offset
+                  : argumentList.leftParenthesis.end;
             }
             builder.addInsertion(offset, (builder) {
               writeInsertionRange(builder, insertionRange, needsInitialComma);
-              if (insertionIndex == 0) {
+              if (insertionIndex == 0 && arguments.isNotEmpty) {
                 builder.write(', ');
               }
             });

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -855,6 +855,9 @@ class FixProcessor extends BaseProcessor {
     CompileTimeErrorCode.INVALID_OVERRIDE_SETTER: [
       DataDriven.new,
     ],
+    CompileTimeErrorCode.MISSING_REQUIRED_ARGUMENT: [
+      DataDriven.new,
+    ],
     CompileTimeErrorCode.MIXIN_OF_NON_CLASS: [
       DataDriven.new,
       ImportLibrary.forType,

pkg/analysis_server/test/src/services/correction/fix/data_driven/flutter_use_case_test.dart

@@ -2321,6 +2321,51 @@ void f() {
   Future<void>
       test_services_ClipboardData_changeParameterNonNullAbsent() async {
     setPackageContent('''
+class ClipboardData {
+  const ClipboardData({required String this.text});
+
+  final String? text;
+}
+''');
+
+    addPackageDataFile('''
+version: 1
+transforms:
+  - title: "Migrate to empty 'text' string"
+    date: 2023-04-19
+    element:
+      uris: ['$importUri']
+      constructor: ''
+      inClass: 'ClipboardData'
+    changes:
+      - kind: 'changeParameterType'
+        name: 'text'
+        nullability: non_null
+        argumentValue:
+          expression: "''"
+''');
+
+    await resolveTestCode('''
+import '$importUri';
+
+void f() {
+  var c = ClipboardData();
+  print(c);
+}
+''');
+    await assertHasFix('''
+import '$importUri';
+
+void f() {
+  var c = ClipboardData(text: '');
+  print(c);
+}
+''');
+  }
+
+  Future<void>
+      test_services_ClipboardData_changeParameterNonNullAdditional() async {
+    setPackageContent('''
 class ClipboardData {
   const ClipboardData({required String this.text, String? this.p});
 
@@ -2350,15 +2395,15 @@ transforms:
 import '$importUri';
 
 void f() {
-  var c = ClipboardData(p: 'hello', text: null);
+  var c = ClipboardData(text: null, p: 'hello');
   print(c);
 }
 ''');
     await assertHasFix('''
 import '$importUri';
 
 void f() {
-  var c = ClipboardData(p: 'hello', text: '');
+  var c = ClipboardData(text: '', p: 'hello');
   print(c);
 }
 ''');