linter: Migrate reportLint to reportAtNode for rules q-z

Change-Id: Idc5711338e0cae4232d680634d8b85a7c57fbad0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425400
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/linter/lib/src/rules/pub/depend_on_referenced_packages.dart

@@ -81,6 +81,6 @@ class _Visitor extends SimpleAstVisitor<void> {
     var packageName = uriContent.substring(8, firstSlash);
     if (virtualPackages.contains(packageName)) return;
     if (availableDeps.contains(packageName)) return;
-    rule.reportLint(node.uri, arguments: [packageName]);
+    rule.reportAtNode(node.uri, arguments: [packageName]);
   }
 }

pkg/linter/lib/src/rules/recursive_getters.dart

@@ -58,7 +58,7 @@ class _BodyVisitor extends RecursiveAstVisitor<void> {
   @override
   void visitSimpleIdentifier(SimpleIdentifier node) {
     if (isSelfReference(node)) {
-      rule.reportLint(node, arguments: [node.name]);
+      rule.reportAtNode(node, arguments: [node.name]);
     }
 
     // No need to call super visit (SimpleIdentifiers have no children).

pkg/linter/lib/src/rules/sized_box_for_whitespace.dart

@@ -40,7 +40,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
 
     if (_shouldReportForArguments(node.argumentList)) {
-      rule.reportLint(node.constructorName);
+      rule.reportAtNode(node.constructorName);
     }
   }
 

pkg/linter/lib/src/rules/sized_box_shrink_expand.dart

@@ -48,10 +48,10 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
 
     if (data.width == 0 && data.height == 0) {
-      rule.reportLint(node.constructorName, arguments: ['shrink']);
+      rule.reportAtNode(node.constructorName, arguments: ['shrink']);
     } else if (data.width == double.infinity &&
         data.height == double.infinity) {
-      rule.reportLint(node.constructorName, arguments: ['expand']);
+      rule.reportAtNode(node.constructorName, arguments: ['expand']);
     }
   }
 

pkg/linter/lib/src/rules/slash_for_doc_comments.dart

@@ -59,7 +59,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   void checkComment(Comment? comment) {
     if (comment != null && isJavaStyle(comment)) {
-      rule.reportLint(comment);
+      rule.reportAtNode(comment);
     }
   }
 

pkg/linter/lib/src/rules/sort_child_properties_last.dart

@@ -59,7 +59,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (!onlyClosuresAfterChild) {
       var argument = arguments.firstWhere(isChildArg);
       var name = (argument as NamedExpression).name.label.name;
-      rule.reportLint(argument, arguments: [name]);
+      rule.reportAtNode(argument, arguments: [name]);
     }
   }
 

pkg/linter/lib/src/rules/sort_constructors_first.dart

@@ -39,7 +39,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     for (var member in members) {
       if (member is ConstructorDeclaration) {
         if (other) {
-          rule.reportLint(member.returnType);
+          rule.reportAtNode(member.returnType);
         }
       } else {
         other = true;

pkg/linter/lib/src/rules/sort_unnamed_constructors_first.dart

@@ -43,7 +43,7 @@ class _Visitor extends SimpleAstVisitor<void> {
       if (member is ConstructorDeclaration) {
         if (member.name == null) {
           if (seenConstructor) {
-            rule.reportLint(member.returnType);
+            rule.reportAtNode(member.returnType);
           }
         } else {
           seenConstructor = true;

pkg/linter/lib/src/rules/specify_nonobvious_local_variable_types.dart

@@ -55,7 +55,7 @@ class _PatternVisitor extends GeneralizingAstVisitor<void> {
         !staticType.isDartCoreNull) {
       return;
     }
-    rule.reportLint(node);
+    rule.reportAtNode(node);
   }
 }
 
@@ -79,7 +79,7 @@ class _Visitor extends SimpleAstVisitor<void> {
       if (iterable.hasObviousType) {
         return;
       }
-      rule.reportLint(loopParts.loopVariable);
+      rule.reportAtNode(loopParts.loopVariable);
     }
   }
 
@@ -133,10 +133,10 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
     if (aDeclaredTypeIsNeeded) {
       if (node.variables.length == 1) {
-        rule.reportLint(node);
+        rule.reportAtNode(node);
       } else {
         // Multiple variables, report each of them separately. No fix.
-        variablesThatNeedAType.forEach(rule.reportLint);
+        variablesThatNeedAType.forEach(rule.reportAtNode);
       }
     }
   }

pkg/linter/lib/src/rules/specify_nonobvious_property_types.dart

@@ -107,10 +107,10 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
     if (aDeclaredTypeIsNeeded) {
       if (node.variables.length == 1) {
-        rule.reportLint(node);
+        rule.reportAtNode(node);
       } else {
         // Multiple variables, report each of them separately. No fix.
-        variablesThatNeedAType.forEach(rule.reportLint);
+        variablesThatNeedAType.forEach(rule.reportAtNode);
       }
     }
   }