[messages] Convert classInstantiationAccessTo(Static|Instance)Member to use literate diagnostic API.

Converts the code that reports the diagnostic codes
`classInstantiationAccessToStaticMember` and
`classInstantiationAccessToInstanceMember` to use the literate
diagnostic reporting API.

Change-Id: I6a6a6964690435bde5e4c39bc6a95c2a3d01104f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/467741
Commit-Queue: Paul Berry <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: stereotype441

pkg/analyzer/lib/src/dart/resolver/constructor_reference_resolver.dart

@@ -68,10 +68,8 @@ class ConstructorReferenceResolver {
           var error = method.isStatic
               ? diag.classInstantiationAccessToStaticMember
               : diag.classInstantiationAccessToInstanceMember;
-          _resolver.diagnosticReporter.atNode(
-            node,
-            error,
-            arguments: [name.name],
+          _resolver.diagnosticReporter.report(
+            error.withArguments(name: name.name).at(node),
           );
         } else if (!name.isSynthetic) {
           _resolver.diagnosticReporter.atNode(

pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart

@@ -1448,9 +1448,9 @@ const DiagnosticWithoutArguments classInClass = DiagnosticWithoutArgumentsImpl(
 );
 
 /// Parameters:
-/// String p0: the name of the member
+/// String name: the name of the member
 const DiagnosticWithArguments<
-  LocatableDiagnostic Function({required String p0})
+  LocatableDiagnostic Function({required String name})
 >
 classInstantiationAccessToInstanceMember = DiagnosticWithArguments(
   name: 'class_instantiation_access_to_member',
@@ -1465,9 +1465,9 @@ classInstantiationAccessToInstanceMember = DiagnosticWithArguments(
 );
 
 /// Parameters:
-/// String p0: the name of the member
+/// String name: the name of the member
 const DiagnosticWithArguments<
-  LocatableDiagnostic Function({required String p0})
+  LocatableDiagnostic Function({required String name})
 >
 classInstantiationAccessToStaticMember = DiagnosticWithArguments(
   name: 'class_instantiation_access_to_member',
@@ -18036,19 +18036,19 @@ LocatableDiagnostic _withArgumentsCastToNonType({required String p0}) {
 }
 
 LocatableDiagnostic _withArgumentsClassInstantiationAccessToInstanceMember({
-  required String p0,
+  required String name,
 }) {
   return LocatableDiagnosticImpl(
     diag.classInstantiationAccessToInstanceMember,
-    [p0],
+    [name],
   );
 }
 
 LocatableDiagnostic _withArgumentsClassInstantiationAccessToStaticMember({
-  required String p0,
+  required String name,
 }) {
   return LocatableDiagnosticImpl(diag.classInstantiationAccessToStaticMember, [
-    p0,
+    name,
   ]);
 }
 

pkg/analyzer/messages.yaml

@@ -2554,9 +2554,9 @@ CompileTimeErrorCode:
   classInstantiationAccessToInstanceMember:
     type: compileTimeError
     parameters:
-      String p0: the name of the member
+      String name: the name of the member
     sharedName: classInstantiationAccessToMember
-    problemMessage: "The instance member '#p0' can't be accessed on a class instantiation."
+    problemMessage: "The instance member '#name' can't be accessed on a class instantiation."
     correctionMessage: Try changing the member name to the name of a constructor.
     hasPublishedDocs: false
   classInstantiationAccessToUnknownMember:
@@ -2571,9 +2571,9 @@ CompileTimeErrorCode:
   classInstantiationAccessToStaticMember:
     type: compileTimeError
     parameters:
-      String p0: the name of the member
+      String name: the name of the member
     sharedName: classInstantiationAccessToMember
-    problemMessage: "The static member '#p0' can't be accessed on a class instantiation."
+    problemMessage: "The static member '#name' can't be accessed on a class instantiation."
     correctionMessage: Try removing the type arguments from the class name, or changing the member name to the name of a constructor.
     hasPublishedDocs: false
   nonConstGenerativeEnumConstructor: