[DAS] Considers factory keyword on constructors auto-complete

[email protected]

Fixes #59896

Change-Id: I47c51bc521f97398ae19a8d124e836baadfdabd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405200
Commit-Queue: Keerti Parthasarathy <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart

@@ -4024,9 +4024,10 @@ extension on AstNode {
     while (enclosingMember != null) {
       if (enclosingMember is MethodDeclaration) {
         return enclosingMember.isStatic;
-      } else if (enclosingMember is FunctionBody &&
-          enclosingMember.parent is ConstructorDeclaration) {
-        return false;
+      } else if (enclosingMember.parent case ConstructorDeclaration(
+        :var factoryKeyword,
+      ) when enclosingMember is FunctionBody) {
+        return factoryKeyword != null;
       } else if (enclosingMember is VariableDeclarationList &&
           enclosingMember.parent is FieldDeclaration) {
         return !enclosingMember.isLate;

pkg/analysis_server/test/services/completion/dart/location/constructor_declaration_test.dart

@@ -17,6 +17,20 @@ class ConstructorDeclarationTest extends AbstractCompletionDriverTest
     with ConstructorDeclarationTestCases {}
 
 mixin ConstructorDeclarationTestCases on AbstractCompletionDriverTest {
+  Future<void> test_factory_noInstanceValues() async {
+    await computeSuggestions('''
+class A {
+  A();
+  factory A.n() {
+    ^
+    return A();
+  }
+  bool isEmpty = false;
+}
+''');
+    assertNoSuggestion(completion: 'isEmpty');
+  }
+
   Future<void> test_factory_redirectedConstructor_afterName() async {
     await computeSuggestions('''
 class A {