[CQ] enforce unnecessary_ignore

Change-Id: Id2c57e56425aa31e86b78f081d71575e8fec7838
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406722
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/analysis_server/analysis_options.yaml

@@ -37,6 +37,7 @@ linter:
     - unawaited_futures
     - unnecessary_breaks
     - unnecessary_final
+    - unnecessary_ignore
     - unnecessary_library_directive
     - unnecessary_parenthesis
     - unreachable_from_main

pkg/analyzer/analysis_options.yaml

@@ -55,5 +55,6 @@ linter:
     - unawaited_futures
     - unnecessary_breaks
     - unnecessary_final
+    - unnecessary_ignore
     - unnecessary_library_directive
     - unnecessary_parenthesis

pkg/analyzer/lib/src/dart/element/replacement_visitor.dart

@@ -337,7 +337,6 @@ class ReplacementVisitor
       var type = parameter.type;
       var newType = visitType(type);
 
-      // ignore: deprecated_member_use_from_same_package
       var kind = parameter.parameterKind;
       var newKind = visitParameterKind(kind);
 

pkg/analyzer/test/src/summary/macro/example/json_serializable.dart

@@ -4,7 +4,6 @@
 //
 // SharedOptions=--enable-experiment=macros
 // ignore_for_file: deprecated_member_use
-// ignore_for_file: deprecated_member_use_from_same_package
 
 // There is no public API exposed yet, the in-progress API lives here.
 import 'package:macros/macros.dart';

pkg/analyzer_cli/analysis_options.yaml

@@ -22,6 +22,7 @@ linter:
     - omit_local_variable_types
     - prefer_single_quotes
     - unawaited_futures
+    - unnecessary_ignore
     - unnecessary_library_directive
     - unnecessary_parenthesis
     - unreachable_from_main

pkg/analyzer_plugin/analysis_options.yaml

@@ -23,6 +23,7 @@ linter:
     - omit_local_variable_types
     - prefer_single_quotes
     - unawaited_futures
+    - unnecessary_ignore
     - unnecessary_library_directive
     - unnecessary_parenthesis
     - unreachable_from_main

pkg/linter/analysis_options.yaml

@@ -52,6 +52,7 @@ linter:
     - unawaited_futures # pedantic
     - unnecessary_breaks
     - unnecessary_final
+    - unnecessary_ignore
     - unnecessary_lambdas
     - unnecessary_library_directive
     - unnecessary_null_checks

pkg/meta/analysis_options.yaml

@@ -2,4 +2,5 @@ include: package:lints/recommended.yaml
 
 linter:
   rules:
-    - flutter_style_todos
+    - flutter_style_todos
+    - unnecessary_ignore