[cfe] Add PrimaryConstructorFragment

Change-Id: Id46a32408e99896030b1a507dc59e9c9b245fde5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390680
Reviewed-by: Chloe Stefantsova <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/fragment/fragment.dart

@@ -37,6 +37,7 @@ part 'getter.dart';
 part 'method.dart';
 part 'mixin.dart';
 part 'named_mixin_application.dart';
+part 'primary_constructor.dart';
 part 'setter.dart';
 part 'typedef.dart';
 

pkg/front_end/lib/src/fragment/primary_constructor.dart

@@ -0,0 +1,52 @@
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+part of 'fragment.dart';
+
+class PrimaryConstructorFragment implements Fragment {
+  final String name;
+  final Uri fileUri;
+  final int charOffset;
+  final Modifiers modifiers;
+  final OmittedTypeBuilder returnType;
+  final List<NominalVariableBuilder>? typeParameters;
+  final List<FormalParameterBuilder>? formals;
+  final bool forAbstractClassOrMixin;
+  Token? _beginInitializers;
+
+  AbstractSourceConstructorBuilder? _builder;
+
+  PrimaryConstructorFragment(
+      {required this.name,
+      required this.fileUri,
+      required this.charOffset,
+      required this.modifiers,
+      required this.returnType,
+      required this.typeParameters,
+      required this.formals,
+      required this.forAbstractClassOrMixin,
+      required Token? beginInitializers})
+      : _beginInitializers = beginInitializers;
+
+  Token? get beginInitializers {
+    Token? result = _beginInitializers;
+    // Ensure that we don't hold onto the token.
+    _beginInitializers = null;
+    return result;
+  }
+
+  @override
+  AbstractSourceConstructorBuilder get builder {
+    assert(_builder != null, "Builder has not been computed for $this.");
+    return _builder!;
+  }
+
+  void set builder(AbstractSourceConstructorBuilder value) {
+    assert(_builder == null, "Builder has already been computed for $this.");
+    _builder = value;
+  }
+
+  @override
+  String toString() => '$runtimeType($name,$fileUri,$charOffset)';
+}

pkg/front_end/lib/src/source/offset_map.dart

@@ -25,6 +25,7 @@ class OffsetMap {
   final Uri uri;
   final Map<int, DeclarationFragment> _declarations = {};
   final Map<int, FieldFragment> _fields = {};
+  final Map<int, PrimaryConstructorFragment> _primaryConstructors = {};
   final Map<int, ConstructorFragment> _constructors = {};
   final Map<int, FactoryFragment> _factoryFragments = {};
   final Map<int, GetterFragment> _getters = {};
@@ -105,12 +106,12 @@ class OffsetMap {
   }
 
   void registerPrimaryConstructor(
-      Token beginToken, ConstructorFragment builder) {
-    _constructors[beginToken.charOffset] = builder;
+      Token beginToken, PrimaryConstructorFragment fragment) {
+    _primaryConstructors[beginToken.charOffset] = fragment;
   }
 
   SourceFunctionBuilder lookupPrimaryConstructor(Token beginToken) {
-    return _checkBuilder(_constructors[beginToken.charOffset]?.builder,
+    return _checkBuilder(_primaryConstructors[beginToken.charOffset]?.builder,
         '<primary-constructor>', beginToken.charOffset);
   }
 

pkg/front_end/lib/src/source/source_builder_factory.dart

@@ -1652,24 +1652,34 @@ class BuilderFactoryImpl implements BuilderFactory, BuilderFactoryResult {
     List<NominalVariableBuilder>? typeVariables =
         nominalVariableCopy?.newVariableBuilders;
 
-    ConstructorFragment builder = _addConstructor(
-        null,
-        isConst ? Modifiers.Const : Modifiers.empty,
-        constructorName,
-        typeVariables,
-        formals,
-        /* startCharOffset = */
-        charOffset,
-        charOffset,
-        /* charOpenParenOffset = */
-        charOffset,
-        /* charEndOffset = */
-        charOffset,
-        /* nativeMethodName = */
-        null,
-        isConst: isConst,
-        forAbstractClassOrMixin: false);
-    offsetMap.registerPrimaryConstructor(beginToken, builder);
+    PrimaryConstructorFragment fragment = new PrimaryConstructorFragment(
+        name: constructorName,
+        fileUri: _compilationUnit.fileUri,
+        charOffset: charOffset,
+        modifiers: isConst ? Modifiers.Const : Modifiers.empty,
+        returnType: addInferableType(),
+        typeParameters: typeVariables,
+        formals: formals,
+        forAbstractClassOrMixin: false,
+        beginInitializers: isConst || libraryFeatures.superParameters.isEnabled
+            // const constructors will have their initializers compiled and
+            // written into the outline. In case of super-parameters language
+            // feature, the super initializers are required to infer the types
+            // of super parameters.
+            // TODO(johnniwinther): Avoid using a dummy token to ensure building
+            // of constant constructors in the outline phase.
+            ? new Token.eof(-1)
+            : null);
+
+    _nominalParameterNameSpaces.pop().addTypeVariables(
+        _problemReporting, typeVariables,
+        ownerName: constructorName, allowNameConflict: true);
+    _addFragment(fragment);
+    if (isConst) {
+      _declarationFragments.current.declaresConstConstructor = true;
+    }
+
+    offsetMap.registerPrimaryConstructor(beginToken, fragment);
   }
 
   @override

pkg/front_end/lib/src/source/source_compilation_unit.dart

@@ -347,7 +347,6 @@ class SourceCompilationUnitImpl implements SourceCompilationUnit {
     assert(!_languageVersion.isFinal);
 
     if (version > loader.target.currentSdkVersion) {
-      // Coverage-ignore-block(suite): Not run.
       // If trying to set a language version that is higher than the current sdk
       // version it's an error.
       addPostponedProblem(

pkg/front_end/lib/src/source/source_constructor_builder.dart

@@ -411,23 +411,23 @@ class DeclaredSourceConstructorBuilder
   final DeclarationBuilder declarationBuilder;
 
   DeclaredSourceConstructorBuilder(
-      List<MetadataBuilder>? metadata,
-      Modifiers modifiers,
-      OmittedTypeBuilder returnType,
-      String name,
-      List<NominalVariableBuilder>? typeVariables,
-      this.formals,
-      this.libraryBuilder,
-      this.declarationBuilder,
-      this.fileUri,
-      int startCharOffset,
-      this.charOffset,
-      int charOpenParenOffset,
-      int charEndOffset,
-      Reference? constructorReference,
-      Reference? tearOffReference,
-      NameScheme nameScheme,
-      {String? nativeMethodName,
+      {required List<MetadataBuilder>? metadata,
+      required Modifiers modifiers,
+      required OmittedTypeBuilder returnType,
+      required String name,
+      required List<NominalVariableBuilder>? typeVariables,
+      required this.formals,
+      required this.libraryBuilder,
+      required this.declarationBuilder,
+      required this.fileUri,
+      required int startCharOffset,
+      required this.charOffset,
+      required int charOpenParenOffset,
+      required int charEndOffset,
+      required Reference? constructorReference,
+      required Reference? tearOffReference,
+      required NameScheme nameScheme,
+      String? nativeMethodName,
       required bool forAbstractClassOrEnumOrMixin,
       required Token? beginInitializers,
       bool isSynthetic = false})
@@ -1238,23 +1238,23 @@ class SourceExtensionTypeConstructorBuilder
   final Uri fileUri;
 
   SourceExtensionTypeConstructorBuilder(
-      List<MetadataBuilder>? metadata,
-      Modifiers modifiers,
-      OmittedTypeBuilder returnType,
-      String name,
-      List<NominalVariableBuilder>? typeVariables,
-      List<FormalParameterBuilder>? formals,
-      this.libraryBuilder,
-      this.declarationBuilder,
-      this.fileUri,
-      int startCharOffset,
-      this.charOffset,
-      int charOpenParenOffset,
-      int charEndOffset,
-      Reference? constructorReference,
-      Reference? tearOffReference,
-      NameScheme nameScheme,
-      {String? nativeMethodName,
+      {required List<MetadataBuilder>? metadata,
+      required Modifiers modifiers,
+      required OmittedTypeBuilder returnType,
+      required String name,
+      required List<NominalVariableBuilder>? typeVariables,
+      required List<FormalParameterBuilder>? formals,
+      required this.libraryBuilder,
+      required this.declarationBuilder,
+      required this.fileUri,
+      required int startCharOffset,
+      required this.charOffset,
+      required int charOpenParenOffset,
+      required int charEndOffset,
+      required Reference? constructorReference,
+      required Reference? tearOffReference,
+      required NameScheme nameScheme,
+      String? nativeMethodName,
       required bool forAbstractClassOrEnumOrMixin,
       required Token? beginInitializers})
       : _memberName = nameScheme.getDeclaredName(name),

pkg/front_end/lib/src/source/source_enum_builder.dart

@@ -351,23 +351,23 @@ class SourceEnumBuilder extends SourceClassBuilder {
     if (needsSynthesizedDefaultConstructor) {
       synthesizedDefaultConstructorBuilder =
           new DeclaredSourceConstructorBuilder(
-              /* metadata = */ null,
-              Modifiers.Const,
-              /* returnType = */ libraryBuilder.loader.inferableTypes
-                  .addInferableType(),
-              /* name = */ "",
-              /* typeParameters = */ null,
-              /* formals = */ [],
-              libraryBuilder,
-              this,
-              fileUri,
-              charOffset,
-              charOffset,
-              charOffset,
-              charEndOffset,
-              constructorReference,
-              tearOffReference,
-              new NameScheme(
+              metadata: null,
+              modifiers: Modifiers.Const,
+              returnType:
+                  libraryBuilder.loader.inferableTypes.addInferableType(),
+              name: "",
+              typeVariables: null,
+              formals: [],
+              libraryBuilder: libraryBuilder,
+              declarationBuilder: this,
+              fileUri: fileUri,
+              startCharOffset: charOffset,
+              charOffset: charOffset,
+              charOpenParenOffset: charOffset,
+              charEndOffset: charEndOffset,
+              constructorReference: constructorReference,
+              tearOffReference: tearOffReference,
+              nameScheme: new NameScheme(
                   isInstanceMember: false,
                   containerName: new ClassName(name),
                   containerType: ContainerType.Class,

pkg/front_end/lib/src/source/source_loader.dart

@@ -548,7 +548,6 @@ class SourceLoader extends Loader {
               packageForLanguageVersion.languageVersion!.major,
               packageForLanguageVersion.languageVersion!.minor);
           if (version > target.currentSdkVersion) {
-            // Coverage-ignore-block(suite): Not run.
             packageLanguageVersionProblem =
                 templateLanguageVersionTooHighPackage.withArguments(
                     version.major,