[CQ] unify featureSet access

Change-Id: I927f9c5d851907b732232f72590a7f65b8dfdbed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403266
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: pq

pkg/linter/lib/src/rules/avoid_renaming_method_parameters.dart

@@ -30,8 +30,7 @@ class AvoidRenamingMethodParameters extends LintRule {
       NodeLintRegistry registry, LinterContext context) {
     if (!context.isInLibDir) return;
 
-    var visitor =
-        _Visitor(this, context.libraryElement2, context.inheritanceManager);
+    var visitor = _Visitor(this, context);
     registry.addMethodDeclaration(this, visitor);
   }
 }
@@ -44,9 +43,10 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   final LintRule rule;
 
-  _Visitor(this.rule, LibraryElement2? library, this.inheritanceManager)
+  _Visitor(this.rule, LinterContext context)
       : _wildCardVariablesEnabled =
-            library?.featureSet.isEnabled(Feature.wildcard_variables) ?? false;
+            context.isEnabled(Feature.wildcard_variables),
+        inheritanceManager = context.inheritanceManager;
 
   bool isWildcardIdentifier(String lexeme) =>
       _wildCardVariablesEnabled && lexeme == '_';

pkg/linter/lib/src/rules/avoid_shadowing_type_parameters.dart

@@ -5,9 +5,9 @@
 import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element2.dart';
 
 import '../analyzer.dart';
+import '../extensions.dart';
 
 const _desc = r'Avoid shadowing type parameters.';
 
@@ -24,7 +24,7 @@ class AvoidShadowingTypeParameters extends LintRule {
   @override
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {
-    var visitor = _Visitor(this, context.libraryElement2);
+    var visitor = _Visitor(this, context);
     registry.addFunctionDeclarationStatement(this, visitor);
     registry.addGenericTypeAlias(this, visitor);
     registry.addMethodDeclaration(this, visitor);
@@ -37,9 +37,9 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   final LintRule rule;
 
-  _Visitor(this.rule, LibraryElement2? library)
+  _Visitor(this.rule, LinterContext context)
       : _wildCardVariablesEnabled =
-            library?.featureSet.isEnabled(Feature.wildcard_variables) ?? false;
+            context.isEnabled(Feature.wildcard_variables);
 
   @override
   void visitFunctionDeclarationStatement(FunctionDeclarationStatement node) {

pkg/linter/lib/src/rules/library_prefixes.dart

@@ -5,9 +5,9 @@
 import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element2.dart';
 
 import '../analyzer.dart';
+import '../extensions.dart';
 import '../utils.dart';
 
 const _desc =
@@ -26,7 +26,7 @@ class LibraryPrefixes extends LintRule {
   @override
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {
-    var visitor = _Visitor(this, context.libraryElement2);
+    var visitor = _Visitor(this, context);
     registry.addImportDirective(this, visitor);
   }
 }
@@ -37,9 +37,9 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   final LintRule rule;
 
-  _Visitor(this.rule, LibraryElement2? library)
+  _Visitor(this.rule, LinterContext context)
       : _wildCardVariablesEnabled =
-            library?.featureSet.isEnabled(Feature.wildcard_variables) ?? false;
+            context.isEnabled(Feature.wildcard_variables);
 
   @override
   void visitImportDirective(ImportDirective node) {

pkg/linter/lib/src/rules/no_leading_underscores_for_library_prefixes.dart

@@ -5,9 +5,9 @@
 import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element2.dart';
 
 import '../analyzer.dart';
+import '../extensions.dart';
 import '../util/ascii_utils.dart';
 
 const _desc = r'Avoid leading underscores for library prefixes.';
@@ -26,7 +26,7 @@ class NoLeadingUnderscoresForLibraryPrefixes extends LintRule {
   @override
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {
-    var visitor = _Visitor(this, context.libraryElement2);
+    var visitor = _Visitor(this, context);
     registry.addImportDirective(this, visitor);
   }
 }
@@ -37,9 +37,9 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   final LintRule rule;
 
-  _Visitor(this.rule, LibraryElement2? library)
+  _Visitor(this.rule, LinterContext context)
       : _wildCardVariablesEnabled =
-            library?.featureSet.isEnabled(Feature.wildcard_variables) ?? false;
+            context.isEnabled(Feature.wildcard_variables);
 
   void checkIdentifier(SimpleIdentifier? id) {
     if (id == null) return;