Elements. Migrate DartCompletionManager and VisibilityTracker.

Change-Id: I0582c52608d29373af778ff2f1ba869fb2ef3703
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398953
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/analyzer_use_new_elements.txt

@@ -19,23 +19,16 @@ lib/src/lsp/handlers/commands/abstract_refactor.dart
 lib/src/lsp/handlers/handler_completion.dart
 lib/src/lsp/handlers/handler_completion_resolve.dart
 lib/src/lsp/handlers/handler_definition.dart
-lib/src/lsp/handlers/handler_document_color_presentation.dart
 lib/src/lsp/handlers/handler_implementation.dart
 lib/src/lsp/handlers/handler_references.dart
 lib/src/lsp/handlers/handler_rename.dart
 lib/src/operation/operation_analysis.dart
 lib/src/protocol_server.dart
 lib/src/search/element_references.dart
 lib/src/search/type_hierarchy.dart
-lib/src/services/completion/dart/completion_manager.dart
 lib/src/services/completion/dart/declaration_helper.dart
-lib/src/services/completion/dart/identifier_helper.dart
-lib/src/services/completion/dart/visibility_tracker.dart
 lib/src/services/correction/namespace.dart
 lib/src/services/correction/util.dart
-lib/src/services/flutter/class_description.dart
-lib/src/services/flutter/property.dart
-lib/src/services/flutter/widget_descriptions.dart
 lib/src/services/kythe/kythe_visitors.dart
 lib/src/services/refactoring/agnostic/change_method_signature.dart
 lib/src/services/refactoring/framework/formal_parameter.dart

pkg/analysis_server/lib/src/cider/completion.dart

@@ -7,8 +7,8 @@ import 'package:analysis_server/src/protocol_server.dart';
 import 'package:analysis_server/src/services/completion/dart/completion_manager.dart';
 import 'package:analysis_server/src/services/completion/dart/fuzzy_filter_sort.dart';
 import 'package:analysis_server/src/services/completion/dart/suggestion_builder.dart';
-import 'package:analyzer/dart/element/element.dart'
-    show CompilationUnitElement, LibraryElement;
+import 'package:analyzer/dart/element/element.dart' show LibraryElement;
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/src/dart/analysis/performance_logger.dart';
 import 'package:analyzer/src/dart/analysis/results.dart';
 import 'package:analyzer/src/dart/micro/resolve_file.dart';
@@ -84,7 +84,7 @@ class CiderCompletionComputer {
         fileState: resolvedUnit.fileState,
         filePath: resolvedUnit.path,
         fileContent: resolvedUnit.content,
-        unitElement: resolvedUnit.unitElement,
+        libraryFragment: resolvedUnit.unitElement,
         enclosingNode: enclosingNode,
         offset: offset,
         unit: resolvedUnit.parsedUnit,
@@ -167,19 +167,19 @@ class CiderCompletionComputer {
   // TODO(scheglov): Implement show / hide combinators.
   // TODO(scheglov): Implement prefixes.
   List<CompletionSuggestionBuilder> _importedLibrariesSuggestions({
-    required CompilationUnitElement target,
+    required LibraryFragment target,
     required OperationPerformanceImpl performance,
   }) {
     var suggestionBuilders = <CompletionSuggestionBuilder>[];
     var importedLibraries =
-        target.withEnclosing
-            .expand((fragment) => fragment.libraryImports)
-            .map((import) => import.importedLibrary)
+        target.withEnclosing2
+            .expand((fragment) => fragment.libraryImports2)
+            .map((import) => import.importedLibrary2)
             .nonNulls
             .toSet();
     for (var importedLibrary in importedLibraries) {
       var importedSuggestions = _importedLibrarySuggestions(
-        element: importedLibrary,
+        element: importedLibrary.asElement,
         performance: performance,
       );
       suggestionBuilders.addAll(importedSuggestions);

pkg/analysis_server/lib/src/cider/local_library_contributor.dart

@@ -61,7 +61,7 @@ class LibraryElementSuggestionBuilder
   @override
   void visitClassElement(ClassElement2 element) {
     AstNode node = request.target.containingNode;
-    var libraryElement = request.libraryElement2;
+    var libraryElement = request.libraryElement;
     if (node is ExtendsClause && !element.isExtendableIn2(libraryElement)) {
       return;
     } else if (node is ImplementsClause &&
@@ -130,7 +130,7 @@ class LibraryElementSuggestionBuilder
   visitMixinElement(MixinElement2 element) {
     AstNode node = request.target.containingNode;
     if (node is ImplementsClause &&
-        !element.isImplementableIn2(request.libraryElement2)) {
+        !element.isImplementableIn2(request.libraryElement)) {
       return;
     }
     _visitInterfaceElement(element);
@@ -219,13 +219,13 @@ class LibraryElementSuggestionBuilder
       }
     }
     if (opType.includeReturnValueSuggestions) {
-      var typeSystem = request.libraryElement2.typeSystem;
+      var typeSystem = request.libraryElement.typeSystem;
       var contextType = request.contextType;
       if (contextType is InterfaceType) {
         // TODO(scheglov): This looks not ideal - we should suggest getters.
         for (var field in element.fields2) {
           if (field.isStatic &&
-              field.isAccessibleIn2(request.libraryElement2) &&
+              field.isAccessibleIn2(request.libraryElement) &&
               typeSystem.isSubtypeOf(field.type, contextType)) {
             if (field.isSynthetic) {
               var getter = field.getter2;

pkg/analysis_server/lib/src/handler/legacy/completion_get_suggestions2.dart

@@ -182,7 +182,7 @@ class CompletionGetSuggestions2Handler extends CompletionHandler
         fileState: resolvedUnit.fileState,
         filePath: resolvedUnit.path,
         fileContent: resolvedUnit.content,
-        unitElement: resolvedUnit.unitElement,
+        libraryFragment: resolvedUnit.unitElement,
         enclosingNode: enclosingNode,
         offset: offset,
         unit: resolvedUnit.parsedUnit,

pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

@@ -19,7 +19,6 @@ import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/analysis/session.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
-import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/file_system/file_system.dart';
@@ -35,7 +34,6 @@ import 'package:analyzer/src/generated/source.dart' show SourceFactory;
 import 'package:analyzer/src/util/file_paths.dart' as file_paths;
 import 'package:analyzer/src/util/performance/operation_performance.dart';
 import 'package:analyzer/src/utilities/completion_matcher.dart';
-import 'package:analyzer/src/utilities/extensions/element.dart';
 import 'package:analyzer/src/utilities/fuzzy_matcher.dart';
 import 'package:analyzer_plugin/src/utilities/completion/completion_target.dart';
 import 'package:analyzer_plugin/src/utilities/completion/optype.dart';
@@ -247,10 +245,10 @@ class DartCompletionRequest {
   final FeatureComputer featureComputer;
 
   /// The library element of the file in which completion is requested.
-  final LibraryElement libraryElement;
+  final LibraryElement2 libraryElement;
 
   /// The library fragment of the file in which completion is requested.
-  final CompilationUnitElement libraryFragment;
+  final LibraryFragment libraryFragment;
 
   /// Return the offset within the source at which the completion is being
   /// requested.
@@ -298,7 +296,7 @@ class DartCompletionRequest {
     required FileState fileState,
     required String filePath,
     required String fileContent,
-    required CompilationUnitElement unitElement,
+    required LibraryFragment libraryFragment,
     required AstNode enclosingNode,
     required int offset,
     required CompilationUnit unit,
@@ -307,7 +305,7 @@ class DartCompletionRequest {
   }) {
     var target = CompletionTarget.forOffset(enclosingNode, offset);
 
-    var libraryElement = unitElement.library;
+    var libraryElement = libraryFragment.element;
     var featureComputer = FeatureComputer(
       libraryElement.typeSystem,
       libraryElement.typeProvider,
@@ -333,13 +331,13 @@ class DartCompletionRequest {
       ),
       featureComputer: featureComputer,
       libraryElement: libraryElement,
-      libraryFragment: unitElement,
+      libraryFragment: libraryFragment,
       offset: offset,
       opType: opType,
       fileState: fileState,
       path: filePath,
       replacementRange: target.computeReplacementRange(offset),
-      source: unitElement.source,
+      source: libraryFragment.source,
       target: target,
       unit: unit,
     );
@@ -357,7 +355,7 @@ class DartCompletionRequest {
       fileState: resolvedUnit.fileState,
       filePath: resolvedUnit.path,
       fileContent: resolvedUnit.content,
-      unitElement: resolvedUnit.unit.declaredElement!,
+      libraryFragment: resolvedUnit.libraryFragment,
       enclosingNode: resolvedUnit.unit,
       offset: offset,
       unit: resolvedUnit.unit,
@@ -403,9 +401,6 @@ class DartCompletionRequest {
     return analysisSession.inheritanceManager;
   }
 
-  /// Getter for the [Element2] representation of [libraryElement].
-  LibraryElement2 get libraryElement2 => libraryElement.asElement2;
-
   /// Answer the [DartType] for Object in dart:core
   InterfaceType get objectType => libraryElement.typeProvider.objectType;
 

pkg/analysis_server/lib/src/services/completion/dart/completion_state.dart

@@ -58,7 +58,7 @@ class CompletionState {
   }
 
   /// The element of the library containing the completion location.
-  LibraryElement2 get libraryElement => request.libraryElement2;
+  LibraryElement2 get libraryElement => request.libraryElement;
 
   /// The type of quotes preferred for [String]s as specified in [CodeStyleOptions].
   String get preferredQuoteForStrings =>