Fine. Tracking for LibraryElementImpl.featureSet and languageVersion.

Change-Id: If5d0e4e4060af91a3e5f315c98bf5c8ce17e0acc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449387
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/binary/binary_reader.dart

@@ -127,6 +127,14 @@ class SummaryDataReader {
     }
   }
 
+  Uint8List? readOptionalUint8List() {
+    if (readBool()) {
+      return readUint8List();
+    } else {
+      return null;
+    }
+  }
+
   String readStringReference() {
     var index = readUint30();
     return stringOfIndex(index);

pkg/analyzer/lib/src/binary/binary_writer.dart

@@ -180,6 +180,15 @@ class BufferedSink {
     }
   }
 
+  void writeOptionalUint8List(Uint8List? value) {
+    if (value != null) {
+      writeBool(true);
+      writeUint8List(value);
+    } else {
+      writeBool(false);
+    }
+  }
+
   /// Write the [value] as UTF8 encoded byte array.
   void writeStringUtf8(String value) {
     var bytes = const Utf8Encoder().convert(value);

pkg/analyzer/lib/src/dart/element/element.dart

@@ -5917,10 +5917,10 @@ class LibraryElementImpl extends ElementImpl
   late List<ExportedReference> exportedReferences;
 
   /// The union of names for all searchable elements in this library.
+  @trackedInternal
   ElementNameUnion nameUnion = ElementNameUnion.empty();
 
-  @override
-  final FeatureSet featureSet;
+  final FeatureSet _featureSet;
 
   /// The entry point for this library, or `null` if this library does not have
   /// an entry point.
@@ -5979,7 +5979,7 @@ class LibraryElementImpl extends ElementImpl
     this._name,
     this._nameOffset,
     this._nameLength,
-    this.featureSet,
+    this._featureSet,
   );
 
   @override
@@ -6129,6 +6129,13 @@ class LibraryElementImpl extends ElementImpl
     _extensionTypes = value;
   }
 
+  @override
+  @trackedDirectly
+  FeatureSet get featureSet {
+    globalResultRequirements?.record_library_featureSet(element: this);
+    return _featureSet;
+  }
+
   /// Information about why non-promotable private fields in the library are not
   /// promotable.
   ///
@@ -6236,7 +6243,9 @@ class LibraryElementImpl extends ElementImpl
   ElementKind get kind => ElementKind.LIBRARY;
 
   @override
+  @trackedDirectly
   LibraryLanguageVersion get languageVersion {
+    globalResultRequirements?.record_library_languageVersion(element: this);
     return _languageVersion ??= LibraryLanguageVersion(
       package: ExperimentStatus.currentVersion,
       override: null,

pkg/analyzer/lib/src/fine/library_manifest.dart

@@ -7,6 +7,7 @@ import 'dart:typed_data';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/binary/binary_reader.dart';
 import 'package:analyzer/src/binary/binary_writer.dart';
+import 'package:analyzer/src/dart/analysis/experiments.dart';
 import 'package:analyzer/src/dart/analysis/file_state.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/fine/lookup_name.dart';
@@ -22,7 +23,9 @@ import 'package:collection/collection.dart';
 
 /// The manifest of a single library.
 class LibraryManifest {
-  String? name;
+  final String? name;
+  final Uint8List featureSet;
+  final ManifestLibraryLanguageVersion languageVersion;
 
   /// The names that are re-exported by this library.
   /// This does not include names that are declared in this library.
@@ -47,6 +50,8 @@ class LibraryManifest {
 
   LibraryManifest({
     required this.name,
+    required this.featureSet,
+    required this.languageVersion,
     required this.reExportMap,
     required this.reExportDeprecatedOnly,
     required this.declaredClasses,
@@ -65,6 +70,8 @@ class LibraryManifest {
   factory LibraryManifest.read(SummaryDataReader reader) {
     return LibraryManifest(
       name: reader.readOptionalStringUtf8(),
+      featureSet: reader.readUint8List(),
+      languageVersion: ManifestLibraryLanguageVersion.read(reader),
       reExportMap: reader.readLookupNameToIdMap(),
       reExportDeprecatedOnly: reader.readLookupNameSet(),
       declaredClasses: reader.readLookupNameMap(
@@ -143,6 +150,8 @@ class LibraryManifest {
 
   void write(BufferedSink sink) {
     sink.writeOptionalStringUtf8(name);
+    sink.writeUint8List(featureSet);
+    languageVersion.write(sink);
     reExportMap.write(sink);
     reExportDeprecatedOnly.write(sink);
     declaredClasses.write(sink);
@@ -852,6 +861,10 @@ class LibraryManifestBuilder {
 
       var newManifest = LibraryManifest(
         name: libraryElement.name.nullIfEmpty,
+        featureSet: (libraryElement.featureSet as ExperimentStatus).toStorage(),
+        languageVersion: ManifestLibraryLanguageVersion.encode(
+          libraryElement.languageVersion,
+        ),
         reExportMap: {},
         reExportDeprecatedOnly: <LookupName>{},
         declaredClasses: newClassItems,
@@ -1070,6 +1083,8 @@ class LibraryManifestBuilder {
     return inputManifests[uri] ??
         LibraryManifest(
           name: null,
+          featureSet: Uint8List(0),
+          languageVersion: ManifestLibraryLanguageVersion.empty(),
           reExportMap: {},
           reExportDeprecatedOnly: <LookupName>{},
           declaredClasses: {},

pkg/analyzer/lib/src/fine/manifest_item.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/binary/binary_reader.dart';
 import 'package:analyzer/src/binary/binary_writer.dart';
 import 'package:analyzer/src/dart/element/element.dart';
@@ -15,6 +16,7 @@ import 'package:analyzer/src/fine/manifest_type.dart';
 import 'package:analyzer/src/utilities/extensions/collection.dart';
 import 'package:collection/collection.dart';
 import 'package:meta/meta.dart';
+import 'package:pub_semver/pub_semver.dart';
 
 class ClassItem extends InterfaceItem<ClassElementImpl> {
   ClassItem({
@@ -1016,6 +1018,82 @@ sealed class ManifestItem<E extends ElementImpl> {
   }
 }
 
+class ManifestLibraryLanguageVersion {
+  final Version packageVersion;
+  final Version? overrideVersion;
+
+  ManifestLibraryLanguageVersion({
+    required this.packageVersion,
+    required this.overrideVersion,
+  });
+
+  ManifestLibraryLanguageVersion.empty()
+    : packageVersion = Version.none,
+      overrideVersion = null;
+
+  factory ManifestLibraryLanguageVersion.encode(
+    LibraryLanguageVersion languageVersion,
+  ) {
+    return ManifestLibraryLanguageVersion(
+      packageVersion: languageVersion.package,
+      overrideVersion: languageVersion.override,
+    );
+  }
+
+  factory ManifestLibraryLanguageVersion.read(SummaryDataReader reader) {
+    return ManifestLibraryLanguageVersion(
+      packageVersion: _readVersion(reader),
+      overrideVersion: reader.readOptionalObject(() => _readVersion(reader)),
+    );
+  }
+
+  @override
+  int get hashCode {
+    return Object.hash(packageVersion, overrideVersion);
+  }
+
+  @override
+  bool operator ==(Object other) {
+    return other is ManifestLibraryLanguageVersion &&
+        packageVersion == other.packageVersion &&
+        overrideVersion == other.overrideVersion;
+  }
+
+  @override
+  String toString() {
+    var result = '(package: $packageVersion';
+    if (overrideVersion case var overrideVersion?) {
+      result += ', override: $overrideVersion';
+    }
+    result += ')';
+    return result;
+  }
+
+  void write(BufferedSink sink) {
+    _writeVersion(sink, packageVersion);
+    sink.writeOptionalObject(overrideVersion, (it) => _writeVersion(sink, it));
+  }
+
+  static ManifestLibraryLanguageVersion? readOptional(
+    SummaryDataReader reader,
+  ) {
+    return reader.readOptionalObject(
+      () => ManifestLibraryLanguageVersion.read(reader),
+    );
+  }
+
+  static Version _readVersion(SummaryDataReader reader) {
+    var major = reader.readUint30();
+    var minor = reader.readUint30();
+    return Version(major, minor, 0);
+  }
+
+  static void _writeVersion(BufferedSink sink, Version version) {
+    sink.writeUint30(version.major);
+    sink.writeUint30(version.minor);
+  }
+}
+
 class ManifestMetadata {
   final List<ManifestAnnotation> annotations;
 

pkg/analyzer/lib/src/fine/requirement_failure.dart

@@ -2,8 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'dart:typed_data';
+
 import 'package:analyzer/src/fine/lookup_name.dart';
 import 'package:analyzer/src/fine/manifest_id.dart';
+import 'package:analyzer/src/fine/manifest_item.dart';
 import 'package:analyzer/src/fine/requirements.dart';
 
 final class ExportCountMismatch extends ExportFailure {
@@ -295,6 +298,36 @@ class LibraryChildrenIdsMismatch extends RequirementFailure {
   }
 }
 
+class LibraryFeatureSetMismatch extends RequirementFailure {
+  final Uri libraryUri;
+  final Uint8List? expected;
+  final Uint8List? actual;
+
+  LibraryFeatureSetMismatch({
+    required this.libraryUri,
+    required this.expected,
+    required this.actual,
+  });
+
+  @override
+  String toString() {
+    return 'LibraryFeatureSetMismatch(libraryUri: $libraryUri, '
+        'expected: $expected, actual: $actual)';
+  }
+}
+
+class LibraryLanguageVersionMismatch extends RequirementFailure {
+  final Uri libraryUri;
+  final ManifestLibraryLanguageVersion expected;
+  final ManifestLibraryLanguageVersion actual;
+
+  LibraryLanguageVersionMismatch({
+    required this.libraryUri,
+    required this.expected,
+    required this.actual,
+  });
+}
+
 class LibraryMissing extends RequirementFailure {
   final Uri uri;