Collect analytics on type of workpace and number of packages for contexts.

Change-Id: I2274536383f92f21912bd39dc5a6796dd2177fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456800
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: keertip

pkg/analysis_server/lib/src/analysis_server.dart

@@ -80,6 +80,7 @@ import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/util/file_paths.dart' as file_paths;
 import 'package:analyzer/src/util/performance/operation_performance.dart';
 import 'package:analyzer/src/utilities/extensions/analysis_session.dart';
+import 'package:analyzer/src/workspace/pub.dart';
 import 'package:analyzer_plugin/protocol/protocol.dart';
 import 'package:analyzer_plugin/src/protocol/protocol_internal.dart'
     as analyzer_plugin;
@@ -938,13 +939,29 @@ abstract class AnalysisServer {
     var transitiveFilePaths = <String>{};
     var transitiveFileUniqueLineCount = 0;
     var libraryCycles = <LibraryCycle>{};
+    var workspaceTypes = <int>[0, 0, 0];
+    var numberOfPackages = <int>[];
     var driverMap = contextManager.driverMap;
     for (var entry in driverMap.entries) {
       var rootPath = entry.key.path;
       var driver = entry.value;
-      var contextRoot = driver.analysisContext?.contextRoot;
-      if (contextRoot != null) {
+      var analysisContext = driver.analysisContext;
+      if (analysisContext != null) {
+        var contextRoot = analysisContext.contextRoot;
         packagesFileMap[rootPath] = contextRoot.packagesFile;
+        var workspace = contextRoot.workspace;
+        if (workspace is PackageConfigWorkspace) {
+          if (workspace.isPubWorkspace) {
+            // Pub workspace index = 2, Package workspace index = 1
+            workspaceTypes[2]++;
+            numberOfPackages.add(workspace.allPackages.length);
+          } else {
+            workspaceTypes[1]++;
+          }
+        } else {
+          // Blaze, GN or other workspace index  = 0
+          workspaceTypes[0]++;
+        }
       }
       var fileSystemState = driver.fsState;
       // Capture the known files before the loop to prevent a concurrent
@@ -995,6 +1012,8 @@ abstract class AnalysisServer {
       transitiveFileUniqueLineCount: transitiveFileUniqueLineCount,
       libraryCycleLibraryCounts: libraryCycleLibraryCounts,
       libraryCycleLineCounts: libraryCycleLineCounts,
+      contextWorkspaceType: workspaceTypes,
+      numberOfPackagesInWorkspace: numberOfPackages,
     );
   }
 

pkg/analysis_server/lib/src/analytics/analytics_manager.dart

@@ -119,6 +119,8 @@ class AnalyticsManager {
     required int transitiveFileUniqueLineCount,
     required List<int> libraryCycleLibraryCounts,
     required List<int> libraryCycleLineCounts,
+    required List<int> numberOfPackagesInWorkspace,
+    required List<int> contextWorkspaceType,
   }) {
     // This is currently keeping the first report of completed analysis, but we
     // might want to consider alternatives, such as keeping the "largest"
@@ -133,6 +135,8 @@ class AnalyticsManager {
       transitiveFileUniqueLineCount: transitiveFileUniqueLineCount,
       libraryCycleLibraryCounts: libraryCycleLibraryCounts,
       libraryCycleLineCounts: libraryCycleLineCounts,
+      contextWorkspaceType: contextWorkspaceType,
+      numberOfPackagesInWorkspace: numberOfPackagesInWorkspace,
     );
   }
 
@@ -474,6 +478,12 @@ class AnalyticsManager {
       h3('Analysis data');
       buffer.writeln('<ul>');
       li('numberOfContexts: ${json.encode(analysisData.numberOfContexts)}');
+      li(
+        'contextWorkspaceType: ${json.encode(analysisData.contextWorkspaceType.toString())}',
+      );
+      li(
+        'numberOfPackagesPerWorkspace: ${json.encode(analysisData.numberOfPackagesInWorkspace.toString())}',
+      );
       li('immediateFileCount: ${json.encode(analysisData.immediateFileCount)}');
       li(
         'immediateFileLineCount: ${json.encode(analysisData.immediateFileLineCount)}',

pkg/analysis_server/lib/src/analytics/context_structure.dart

@@ -47,6 +47,16 @@ class ContextStructure {
   /// [transitiveFileUniqueCount].
   final int transitiveFileUniqueLineCount;
 
+  /// The type of the workspaces in all of the contexts. A list of 3 elements,
+  /// index 0 - number of Blaze/GN/Basic workspace
+  /// index 1 - number of workspaces with one package
+  /// index 2 - number of Pub workspaces
+  final List<int> contextWorkspaceType;
+
+  /// The number of packages in the workspace. This value is calculated only
+  /// for Pub workspaces (monorepo).
+  final PercentileCalculator numberOfPackagesInWorkspace;
+
   final PercentileCalculator libraryCycleLibraryCounts;
   final PercentileCalculator libraryCycleLineCounts;
 
@@ -61,10 +71,15 @@ class ContextStructure {
     required this.transitiveFileUniqueLineCount,
     required List<int> libraryCycleLibraryCounts,
     required List<int> libraryCycleLineCounts,
+    this.contextWorkspaceType = const <int>[0, 0, 0],
+    List<int> numberOfPackagesInWorkspace = const <int>[],
   }) : libraryCycleLibraryCounts = PercentileCalculator.from(
          libraryCycleLibraryCounts,
        ),
        libraryCycleLineCounts = PercentileCalculator.from(
          libraryCycleLineCounts,
+       ),
+       numberOfPackagesInWorkspace = PercentileCalculator.from(
+         numberOfPackagesInWorkspace,
        );
 }

pkg/analyzer/lib/src/workspace/pub.dart

@@ -180,6 +180,10 @@ class PackageConfigWorkspace extends SimpleWorkspace {
   /// The contents of the package config file.
   late final String? _packageConfigContent;
 
+  /// Indicates whether this is a PubWorkspace as per
+  /// https://dart.dev/tools/pub/workspaces
+  bool _isPubWorkspace = false;
+
   final Map<String, WorkspacePackageImpl> _workspacePackages = {};
 
   factory PackageConfigWorkspace(
@@ -208,6 +212,15 @@ class PackageConfigWorkspace extends SimpleWorkspace {
     this.packageConfigFile,
   ) {
     _packageConfigContent = packageConfigFile.readAsStringSync();
+    var pubspecFile = provider
+        .getFolder(root)
+        .getChildAssumingFile(file_paths.pubspecYaml);
+    if (pubspecFile.exists) {
+      var pubspec = Pubspec.parse(pubspecFile.readAsStringSync());
+      if (pubspec.workspace != null) {
+        _isPubWorkspace = true;
+      }
+    }
   }
 
   Iterable<WorkspacePackageImpl> get allPackages =>
@@ -218,6 +231,8 @@ class PackageConfigWorkspace extends SimpleWorkspace {
     return _fileContentOrNull(packageConfigFile) == _packageConfigContent;
   }
 
+  bool get isPubWorkspace => _isPubWorkspace;
+
   @override
   UriResolver get packageUriResolver {
     return PackageConfigPackageUriResolver(

pkg/analyzer/test/src/workspace/pub_test.dart

@@ -549,6 +549,44 @@ class PackageConfigWorkspaceTest with ResourceProviderMixin {
     );
   }
 
+  void test_multiple_packages_pub_workspace() {
+    var aFilePath = '/workspace/a/lib/a.dart';
+    var bFilePath = '/workspace/b/b.dart';
+    _addResources(['/workspace/a/lib/', '/workspace/b/', aFilePath, bFilePath]);
+    newPubspecYamlFile('/workspace', '''
+name: works
+workspace:
+- a
+- b
+''');
+    newPubspecYamlFile('/workspace/a', 'name: a');
+    PackageConfigWorkspace workspace = _createWorkspace('/workspace', [
+      'project',
+      'foo',
+    ]);
+
+    expect(workspace.root, convertPath('/workspace'));
+    workspace.findPackageFor(convertPath(aFilePath));
+    workspace.findPackageFor(convertPath(bFilePath));
+    expect(workspace.allPackages.length, 2);
+    expect(workspace.isPubWorkspace, true);
+  }
+
+  void test_single_package_workspace() {
+    var aFilePath = '/workspace/a/lib/a.dart';
+    _addResources(['/workspace/a/lib/', aFilePath]);
+    newPubspecYamlFile('/workspace/a', 'name: a');
+    PackageConfigWorkspace workspace = _createWorkspace('/workspace', [
+      'project',
+      'foo',
+    ]);
+
+    expect(workspace.root, convertPath('/workspace'));
+    workspace.findPackageFor(convertPath(aFilePath));
+    expect(workspace.allPackages.length, 1);
+    expect(workspace.isPubWorkspace, false);
+  }
+
   void _addResources(List<String> paths) {
     for (String path in paths) {
       if (path.endsWith('/')) {