CQ. Remove unnecessary 'async' where no 'await'.

Change-Id: I58f56c098c9cec753325ab56d0aad37e1fde0ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403082
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/benchmark/integration/driver.dart

@@ -70,7 +70,7 @@ class Driver extends IntegrationTest {
   /// Launch the analysis server.
   ///
   /// Return a [Future] that completes when analysis server has started.
-  Future<void> startServer() async {
+  Future<void> startServer() {
     logger.log(Level.FINE, 'starting server');
     server = Server();
     var serverConnected = Completer<void>();

pkg/analysis_server/lib/src/cider/completion.dart

@@ -55,11 +55,11 @@ class CiderCompletionComputer {
     required int column,
     @visibleForTesting
     void Function(ResolvedForCompletionResultImpl)? testResolvedUnit,
-  }) async {
+  }) {
     return _performanceRoot.runAsync('completion', (performance) async {
       var resolvedUnit = await performance.runAsync('resolution', (
         performance,
-      ) async {
+      ) {
         return _fileResolver.resolveForCompletion(
           completionLine: line,
           completionColumn: column,

pkg/analysis_server/lib/src/context_manager.dart

@@ -553,7 +553,7 @@ class ContextManagerImpl implements ContextManager {
   /// rebuild will occur only once it has exited.
   ///
   /// Returns a [Future] that completes once the requested rebuild completes.
-  Future<void> _createAnalysisContexts() async {
+  Future<void> _createAnalysisContexts() {
     /// A helper that performs a context rebuild while monitoring the included
     /// paths for changes until the contexts file watchers are ready.
     ///

pkg/analysis_server/lib/src/lsp/handlers/handler_code_actions.dart

@@ -39,7 +39,7 @@ class CodeActionHandler
     CodeActionParams params,
     MessageInfo message,
     CancellationToken token,
-  ) async {
+  ) {
     var performance = message.performance;
 
     var textDocument = params.textDocument;

pkg/analysis_server/lib/src/lsp/handlers/handler_semantic_tokens.dart

@@ -58,7 +58,7 @@ abstract class AbstractSemanticTokensHandler<T>
     TextDocumentIdentifier textDocument,
     CancellationToken token, {
     Range? range,
-  }) async {
+  }) {
     var path = pathOfDoc(textDocument);
 
     return path.mapResult((path) async {

pkg/analysis_server/lib/src/lsp/temporary_overlay_operation.dart

@@ -86,7 +86,7 @@ abstract class TemporaryOverlayOperation {
   /// temporary overlays and re-enabled after the overlays are restored.
   Future<T> lockRequestsWithTemporaryOverlays<T>(
     Future<T> Function() operation,
-  ) async {
+  ) {
     return server.lockRequestsWhile(() async {
       // Wait for any in-progress analysis to complete before we start
       // suppressing analysis results.

pkg/analysis_server/lib/src/search/element_references.dart

@@ -68,9 +68,7 @@ class ElementReferencesComputer {
   }
 
   /// Returns a [Future] completing with a [List] of references to [element].
-  Future<List<SearchMatch>> _findSingleElementReferences(
-    Element2 element,
-  ) async {
+  Future<List<SearchMatch>> _findSingleElementReferences(Element2 element) {
     return searchEngine.searchReferences(element);
   }
 

pkg/analysis_server/lib/src/server/driver.dart

@@ -512,7 +512,7 @@ class Driver implements ServerStarter {
 
     capture(instrumentationService, () {
       var stdioServer = LspStdioAnalysisServer(socketServer);
-      stdioServer.serveStdio().then((_) async {
+      stdioServer.serveStdio().then((_) {
         // Only shutdown the server and exit if the server is not already
         // handling the shutdown.
         if (!socketServer.analysisServer!.willExit) {

pkg/analysis_server/lib/src/server/http_server.dart

@@ -93,7 +93,7 @@ class HttpAnalysisServer {
 
   /// Attach a listener to a newly created HTTP server.
   void _handleServer(HttpServer httpServer) {
-    httpServer.listen((HttpRequest request) async {
+    httpServer.listen((HttpRequest request) {
       var updateValues = request.headers[HttpHeaders.upgradeHeader];
       if (request.method == 'GET') {
         _httpHandler.handleGetRequest(request);

pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart

@@ -133,7 +133,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandAssert(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(kind, processor.findAssertExpression, (expr) {
       return 'assert(${processor.utils.getNodeText(expr)});';
     }, withBraces: false);
@@ -142,7 +142,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandElse(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(
       kind,
       processor.findBoolExpression,
@@ -153,7 +153,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandFor(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(kind, processor.findIterableExpression, (expr) {
       var value = processor.newVariable('value');
       return 'for (var $value in ${processor.utils.getNodeText(expr)})';
@@ -163,7 +163,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandFori(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(kind, processor.findIntExpression, (expr) {
       var index = processor.newVariable('i');
       return 'for (int $index = 0; $index < ${processor.utils.getNodeText(expr)}; $index++)';
@@ -173,7 +173,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandIf(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(
       kind,
       processor.findBoolExpression,
@@ -184,7 +184,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandNegate(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(
       kind,
       processor.findBoolExpression,
@@ -196,7 +196,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandNotNull(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(kind, processor.findObjectExpression, (expr) {
       return expr is NullLiteral
           ? 'if (false)'
@@ -207,7 +207,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandNull(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(kind, processor.findObjectExpression, (expr) {
       return expr is NullLiteral
           ? 'if (true)'
@@ -218,7 +218,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandParen(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(
       kind,
       processor.findObjectExpression,
@@ -230,7 +230,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandReturn(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(
       kind,
       processor.findObjectExpression,
@@ -242,7 +242,7 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandSwitch(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(
       kind,
       processor.findObjectExpression,
@@ -253,21 +253,21 @@ abstract final class DartPostfixCompletion {
   static Future<PostfixCompletion?> expandTry(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expandTry(kind, processor.findStatement);
   }
 
   static Future<PostfixCompletion?> expandTryon(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expandTry(kind, processor.findStatement, withOn: true);
   }
 
   static Future<PostfixCompletion?> expandWhile(
     PostfixCompletionProcessor processor,
     PostfixCompletionKind kind,
-  ) async {
+  ) {
     return processor.expand(
       kind,
       processor.findBoolExpression,