[analysis_server] Include declared identifiers and destructed variables in inline values

Fixes Dart-Code/Dart-Code#5547

Change-Id: I3ccf2d500d704a44fc96ba802837c11893e7f3eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434860
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>

Author: DanTup

pkg/analysis_server/lib/src/lsp/handlers/handler_inline_value.dart

@@ -290,6 +290,28 @@ class _InlineValueVisitor extends GeneralizingAstVisitor<void> {
     super.visitBlock(node);
   }
 
+  @override
+  void visitDeclaredIdentifier(DeclaredIdentifier node) {
+    var name = node.name;
+    collector.recordVariableLookup(
+      node.declaredElement2,
+      name.offset,
+      name.length,
+    );
+    super.visitDeclaredIdentifier(node);
+  }
+
+  @override
+  void visitDeclaredVariablePattern(DeclaredVariablePattern node) {
+    var name = node.name;
+    collector.recordVariableLookup(
+      node.declaredElement2,
+      name.offset,
+      name.length,
+    );
+    super.visitDeclaredVariablePattern(node);
+  }
+
   @override
   void visitFormalParameter(FormalParameter node) {
     var name = node.name;

pkg/analysis_server/test/lsp/inline_value_test.dart

@@ -405,6 +405,30 @@ void f() {
     await verify_values(code, ofType: InlineValueVariableLookup);
   }
 
+  Future<void> test_variable_forIn() async {
+    code = TestCode.parse(r'''
+void f(List<int> ints) {
+  for (var /*[0*/i/*0]*/ in /*[1*/ints/*1]*/) {
+    ^
+  }
+}
+''');
+
+    await verify_values(code, ofType: InlineValueVariableLookup);
+  }
+
+  Future<void> test_variable_forIn_destructure() async {
+    code = TestCode.parse(r'''
+void f(List<(int, int)> records) {
+  for (var (/*[0*/x/*0]*/, /*[1*/y/*1]*/) in /*[2*/records/*2]*/) {
+    ^
+  }
+}
+''');
+
+    await verify_values(code, ofType: InlineValueVariableLookup);
+  }
+
   /// Lists are included, iterables are not.
   Future<void> test_variable_iterables() async {
     experimentalInlineValuesProperties = true;