Add method and constructor formal parameter tests to class_test.

Change-Id: Ia30dbacc29a425adf7ceb3ca6e7e4826183a49dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451141
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: fshcheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -849,6 +849,15 @@ class ConstructorElementImpl extends ExecutableElementImpl
       previous.addFragment(current);
       return current;
     });
+    TypeParameterFragmentImpl._linkFragments(
+      fragments,
+      getFragments: (f) => f.typeParameters,
+    );
+
+    FormalParameterFragmentImpl._linkFragments(
+      fragments,
+      getFragments: (f) => f.formalParameters,
+    );
   }
 
   @override
@@ -8301,6 +8310,10 @@ class MethodElementImpl extends ExecutableElementImpl
       fragments,
       getFragments: (f) => f.typeParameters,
     );
+    FormalParameterFragmentImpl._linkFragments(
+      fragments,
+      getFragments: (f) => f.formalParameters,
+    );
   }
 }
 

pkg/analyzer/lib/src/summary2/bundle_reader.dart

@@ -351,8 +351,6 @@ class LibraryReader {
       element.linkFragments(fragments);
       element.readModifiers(_reader);
 
-      // TODO(scheglov): type parameters
-      // TODO(scheglov): formal parameters
       element.deferReadResolution(
         _createDeferredReadResolutionCallback((reader) {
           var enclosingElement = element.enclosingElement;
@@ -914,12 +912,9 @@ class LibraryReader {
         firstFragment: fragments.first,
       );
       element.linkFragments(fragments);
-
       element.readModifiers(_reader);
       element.typeInferenceError = _readTopLevelInferenceError();
 
-      // TODO(scheglov): type parameters
-      // TODO(scheglov): formal parameters
       element.deferReadResolution(
         _createDeferredReadResolutionCallback((reader) {
           var enclosingElement = element.enclosingElement;

pkg/analyzer/lib/src/summary2/element_builder.dart

@@ -311,6 +311,18 @@ class ElementBuilder {
 
     if (fragment.isAugmentation && lastFragment is ConstructorFragmentImpl) {
       lastFragment.addFragment(fragment);
+
+      _linkTypeParameters(
+        lastFragments: lastFragment.typeParameters,
+        fragments: fragment.typeParameters,
+        add: fragment.addTypeParameter,
+      );
+
+      fragment.formalParameters = _linkFormalParameters(
+        previousFragments: lastFragment.formalParameters,
+        currentFragments: fragment.formalParameters,
+      );
+
       return;
     }
 
@@ -497,6 +509,11 @@ class ElementBuilder {
         add: fragment.addTypeParameter,
       );
 
+      fragment.formalParameters = _linkFormalParameters(
+        previousFragments: lastFragment.formalParameters,
+        currentFragments: fragment.formalParameters,
+      );
+
       return;
     }