[primary constructors] support for library_private_types_in_public_api

Fixes: #61989

Change-Id: I893e0ec4255376f2084197c0936211095edb19f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/462865
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/linter/lib/src/rules/library_private_types_in_public_api.dart

@@ -44,18 +44,22 @@ class Validator extends SimpleAstVisitor<void> {
 
   @override
   void visitClassDeclaration(ClassDeclaration node) {
-    if (Identifier.isPrivateName(node.namePart.typeName.lexeme)) {
+    var namePart = node.namePart;
+    if (isPrivateName(namePart.typeName.lexeme)) {
       return;
     }
-    node.namePart.typeParameters?.accept(this);
+    namePart.typeParameters?.accept(this);
     if (node.body case BlockClassBody body) {
       body.members.accept(this);
     }
+    if (namePart is PrimaryConstructorDeclaration) {
+      visitPrimaryConstructorDeclaration(namePart);
+    }
   }
 
   @override
   void visitClassTypeAlias(ClassTypeAlias node) {
-    if (Identifier.isPrivateName(node.name.lexeme)) {
+    if (isPrivateName(node.name.lexeme)) {
       return;
     }
     node.superclass.accept(this);
@@ -64,18 +68,8 @@ class Validator extends SimpleAstVisitor<void> {
 
   @override
   void visitConstructorDeclaration(ConstructorDeclaration node) {
-    var name = node.name;
-    if (name != null && Identifier.isPrivateName(name.lexeme)) {
-      return;
-    }
-
-    var parent = node.parent?.parent;
-
-    // Enum constructors are effectively private so don't visit their params.
-    if (parent is EnumDeclaration) return;
-
-    // Select modified class types are also effectively private.
-    if (parent != null && parent.isEffectivelyPrivate) return;
+    if (isPrivateName(node.name?.lexeme)) return;
+    if (isEffectivelyPrivate(node)) return;
 
     node.parameters.accept(this);
   }
@@ -239,6 +233,14 @@ class Validator extends SimpleAstVisitor<void> {
     node.typeArguments?.accept(this);
   }
 
+  @override
+  void visitPrimaryConstructorDeclaration(PrimaryConstructorDeclaration node) {
+    if (isPrivateName(node.constructorName?.name.lexeme)) return;
+    if (isEffectivelyPrivate(node)) return;
+
+    node.formalParameters.accept(this);
+  }
+
   @override
   void visitSimpleFormalParameter(SimpleFormalParameter node) {
     var name = node.name;
@@ -295,6 +297,16 @@ class Validator extends SimpleAstVisitor<void> {
     node.typeParameters.accept(this);
   }
 
+  static bool isEffectivelyPrivate(AstNode node) {
+    var parent = node.parent?.parent;
+
+    // Enum constructors are effectively private so don't visit their params.
+    if (parent is EnumDeclaration) return true;
+
+    // Select modified class types are also effectively private.
+    return parent != null && parent.isEffectivelyPrivate;
+  }
+
   /// Return `true` if the given [element] is private or is defined in a private
   /// library.
   static bool isPrivate(Element element) => isPrivateName(element.name);

pkg/linter/test/rules/library_private_types_in_public_api_test.dart

@@ -563,6 +563,40 @@ class _P {}
     );
   }
 
+  test_primaryConstructor_declaring_privateParameterType() async {
+    await assertDiagnostics(
+      r'''
+class C(_P p);
+class _P {}
+''',
+      [lint(8, 2)],
+    );
+  }
+
+  test_primaryConstructor_declaring_publicParameterType() async {
+    await assertNoDiagnostics(r'''
+class C(P p);
+class P {}
+''');
+  }
+
+  test_primaryConstructor_named_privateParameterType() async {
+    await assertDiagnostics(
+      r'''
+class C.named(_P p);
+class _P {}
+''',
+      [lint(14, 2)],
+    );
+  }
+
+  test_primaryConstructor_named_publicParameterType() async {
+    await assertNoDiagnostics(r'''
+class C.named(P p);
+class P {}
+''');
+  }
+
   test_topLevelGetter_private_privateReturnType() async {
     await assertNoDiagnostics(r'''
 _P get _g => _P();