DAS AOT: check artifact exists; remove negated flag

srawlins · Commit Queue · commit a67b8c503efb · 2025-04-28T19:28:28.000-07:00
Change-Id: Ic222050fd5a2e091ab8e2063c018fa8707614168 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424705 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
diff --git a/pkg/dartdev/lib/src/commands/language_server.dart b/pkg/dartdev/lib/src/commands/language_server.dart
@@ -50,6 +50,9 @@ For more information about the server's capabilities and configuration, see:
     }
     try {
       if (argResults!.flag(_useAotSnapshotFlag)) {
+        if (!Sdk.checkArtifactExists(sdk.dartAotRuntime)) {
+          return _genericErrorExitCode;
+        }
         args.remove('--$_useAotSnapshotFlag');
         VmInteropHandler.run(
           sdk.dartAotRuntime,
@@ -75,4 +78,6 @@ For more information about the server's capabilities and configuration, see:
   }
 
   static const _useAotSnapshotFlag = 'use-aot-snapshot';
+
+  static const _genericErrorExitCode = 255;
 }

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,9 @@ For more information about the server's capabilities and configuration, see:`
`50`	`50`	`}`
`51`	`51`	`try {`
`52`	`52`	`if (argResults!.flag(_useAotSnapshotFlag)) {`
	`53`	`+ if (!Sdk.checkArtifactExists(sdk.dartAotRuntime)) {`
	`54`	`+ return _genericErrorExitCode;`
	`55`	`+ }`
`53`	`56`	`args.remove('--$_useAotSnapshotFlag');`
`54`	`57`	`VmInteropHandler.run(`
`55`	`58`	`sdk.dartAotRuntime,`
`@@ -75,4 +78,6 @@ For more information about the server's capabilities and configuration, see:`
`75`	`78`	`}`
`76`	`79`
`77`	`80`	`static const _useAotSnapshotFlag = 'use-aot-snapshot';`
	`81`	`+`
	`82`	`+ static const _genericErrorExitCode = 255;`
`78`	`83`	`}`