[analysis_server] Fix private extensions showing up in other libraries

Fixes #61159

Change-Id: I13dfc3b0dc7ada94a6dddb72254d537c121d4fc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444320
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: DanTup

pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart

@@ -464,41 +464,43 @@ class DeclarationHelper {
         (extendedType is InterfaceType) ? extendedType.element : null;
     if (includeMethods) {
       for (var method in extension.methods) {
-        if (!method.isStatic) {
-          if (method.isOperator) {
-            continue;
-          }
-          _suggestMethod(
-            method: method,
-            importData: importData,
-            referencingInterface: referencingInterface,
-          );
+        if (method.isStatic ||
+            method.isOperator ||
+            !method.isVisibleIn(request.libraryElement)) {
+          continue;
         }
+        _suggestMethod(
+          method: method,
+          importData: importData,
+          referencingInterface: referencingInterface,
+        );
       }
     }
     for (var accessor in extension.getters) {
-      if (excludedGetters.contains(accessor.name)) {
+      if (excludedGetters.contains(accessor.name) ||
+          accessor.isStatic ||
+          !accessor.isVisibleIn(request.libraryElement)) {
         continue;
       }
-      if (!accessor.isStatic) {
+      _suggestProperty(
+        accessor: accessor,
+        referencingInterface: referencingInterface,
+        importData: importData,
+      );
+    }
+    if (includeSetters) {
+      for (var accessor in extension.setters) {
+        if (accessor.isStatic ||
+            !accessor.isVisibleIn(request.libraryElement)) {
+          continue;
+        }
         _suggestProperty(
           accessor: accessor,
           referencingInterface: referencingInterface,
           importData: importData,
         );
       }
     }
-    if (includeSetters) {
-      for (var accessor in extension.setters) {
-        if (!accessor.isStatic) {
-          _suggestProperty(
-            accessor: accessor,
-            referencingInterface: referencingInterface,
-            importData: importData,
-          );
-        }
-      }
-    }
   }
 
   /// Adds suggestions for any constructors that are visible within the not yet
@@ -805,49 +807,53 @@ class DeclarationHelper {
       var extension = instantiatedExtension.extension;
       if (includeMethods) {
         for (var method in extension.methods) {
-          if (!method.isStatic) {
-            if (method.isOperator) {
-              continue;
-            }
-            _suggestMethod(
-              method: method,
-              isKeywordNeeded: isKeywordNeeded,
-              isTypeNeeded: isTypeNeeded,
-            );
+          if (method.isStatic ||
+              method.isOperator ||
+              !method.isVisibleIn(libraryElement)) {
+            continue;
           }
+          _suggestMethod(
+            method: method,
+            isKeywordNeeded: isKeywordNeeded,
+            isTypeNeeded: isTypeNeeded,
+          );
         }
       }
       for (var getter in extension.getters) {
         if (excludedGetters.contains(getter.name)) {
           continue;
         }
         if (!getter.isSynthetic) {
-          _suggestProperty(
-            accessor: getter,
-            isKeywordNeeded: isKeywordNeeded,
-            isTypeNeeded: isTypeNeeded,
-          );
+          if (getter.isVisibleIn(libraryElement)) {
+            _suggestProperty(
+              accessor: getter,
+              isKeywordNeeded: isKeywordNeeded,
+              isTypeNeeded: isTypeNeeded,
+            );
+          }
         } else {
           // All fields induce a getter.
           var variable = getter.variable;
           if (variable is FieldElement) {
-            _suggestField(
-              field: variable,
-              isKeywordNeeded: isKeywordNeeded,
-              isTypeNeeded: isTypeNeeded,
-            );
+            if (variable.isVisibleIn(libraryElement)) {
+              _suggestField(
+                field: variable,
+                isKeywordNeeded: isKeywordNeeded,
+                isTypeNeeded: isTypeNeeded,
+              );
+            }
           }
         }
       }
-      for (var setter in extension.setters) {
-        if (!setter.isSynthetic) {
-          if (includeSetters) {
-            _suggestProperty(accessor: setter);
-          }
-        } else {
+      if (includeSetters) {
+        for (var setter in extension.setters) {
           // Avoid visiting a field twice. All fields induce a getter, but only
-          // non-final fields induce a setter, so we don't add a suggestion for a
-          // synthetic setter.
+          // non-final fields induce a setter, so we don't add a suggestion for
+          // a synthetic setter.
+          if (setter.isSynthetic || !setter.isVisibleIn(libraryElement)) {
+            continue;
+          }
+          _suggestProperty(accessor: setter);
         }
       }
     }

pkg/analysis_server/test/src/services/completion/dart/completion_test.dart

@@ -331,6 +331,178 @@ extension E on String {
 ''');
     assertHasCompletion('m');
   }
+
+  Future<void> test_privateGetter_accessible() async {
+    await getTestCodeSuggestions('''
+extension E on String {
+  String get _privateGetter => '';
+}
+
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasCompletion('_privateGetter');
+  }
+
+  Future<void> test_privateGetter_notAccessible_imported() async {
+    newFile(convertPath('$testPackageLibPath/extensions.dart'), '''
+extension E on String {
+  String get _privateGetter => '';
+}
+''');
+    await getTestCodeSuggestions('''
+import 'extensions.dart';
+
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasNoCompletion('_privateGetter');
+  }
+
+  Future<void> test_privateGetter_notAccessible_notImported() async {
+    newFile(convertPath('$testPackageLibPath/extensions.dart'), '''
+extension E on String {
+  String get _privateGetter => '';
+}
+''');
+    await getTestCodeSuggestions('''
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasNoCompletion('_privateGetter');
+  }
+
+  Future<void> test_privateMethod_accessible() async {
+    await getTestCodeSuggestions('''
+extension E on String {
+  void _privateMethod() {}
+}
+
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasCompletion('_privateMethod');
+  }
+
+  Future<void> test_privateMethod_notAccessible_mported() async {
+    newFile(convertPath('$testPackageLibPath/extensions.dart'), '''
+extension E on String {
+  void _privateMethod() {}
+}
+''');
+    await getTestCodeSuggestions('''
+import 'extensions.dart';
+
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasNoCompletion('_privateMethod');
+  }
+
+  Future<void> test_privateMethod_notAccessible_notImported() async {
+    newFile(convertPath('$testPackageLibPath/extensions.dart'), '''
+extension E on String {
+  void _privateMethod() {}
+}
+''');
+    await getTestCodeSuggestions('''
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasNoCompletion('_privateMethod');
+  }
+
+  Future<void> test_privateSetter_accessible() async {
+    await getTestCodeSuggestions('''
+extension E on String {
+  set _privateSetter(String _) {}
+}
+
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasCompletion('_privateSetter');
+  }
+
+  Future<void> test_privateSetter_notAccessible_imported() async {
+    newFile(convertPath('$testPackageLibPath/extensions.dart'), '''
+extension E on String {
+  set _privateSetter(String _) {}
+}
+''');
+    await getTestCodeSuggestions('''
+import 'extensions.dart';
+
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasNoCompletion('_privateSetter');
+  }
+
+  Future<void> test_privateSetter_notAccessible_notImported() async {
+    newFile(convertPath('$testPackageLibPath/extensions.dart'), '''
+extension E on String {
+  set _privateSetter(String _) {}
+}
+''');
+    await getTestCodeSuggestions('''
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasNoCompletion('_privateSetter');
+  }
+
+  Future<void> test_privateVariable_accessible() async {
+    await getTestCodeSuggestions('''
+extension E on String {
+  String _privateVariable = '';
+}
+
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasCompletion('_privateVariable');
+  }
+
+  Future<void> test_privateVariable_notAccessible_imported() async {
+    newFile(convertPath('$testPackageLibPath/extensions.dart'), '''
+extension E on String {
+  String _privateVariable = '';
+}
+''');
+    await getTestCodeSuggestions('''
+import 'extensions.dart';
+
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasNoCompletion('_privateVariable');
+  }
+
+  Future<void> test_privateVariable_notAccessible_notImported() async {
+    newFile(convertPath('$testPackageLibPath/extensions.dart'), '''
+extension E on String {
+  String _privateVariable = '';
+}
+''');
+    await getTestCodeSuggestions('''
+void f(String s) {
+  s.^;
+}
+''');
+    assertHasNoCompletion('_privateVariable');
+  }
 }
 
 @reflectiveTest
@@ -560,7 +732,7 @@ class B implements A {
 
   @failingTest
   Future<void> test_unnamedConstructor_inDifferentLibrary() async {
-    newFile('/project/bin/b.dart', '''
+    newFile('$testPackageLibPath/b.dart', '''
 class B implements A {
   B();
 }
@@ -671,7 +843,7 @@ void g() {}
 @reflectiveTest
 class SuperConstructorInvocationCompletionTest extends CompletionTestCase {
   Future<void> test_namedConstructor_notVisible() async {
-    newFile('/project/bin/a.dart', '''
+    newFile('$testPackageLibPath/a.dart', '''
 class A {
   A._() {}
 }