Skip to content

Commit a8a2303

Browse files
natebiggsCommit Queue
authored andcommitted
[dart2wasm] Fix wasm unit test structure.
Previously these were being run with the standard "pkg" unit test suite. All the other backends have their own unit test suite so this introduces one for dart2wasm. This ensures the tests run with the correct fileset (including d8). Change-Id: I29cd0048a4d6731da3a20110f6e496fe7da0c3b6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/454760 Commit-Queue: Nate Biggs <[email protected]> Reviewed-by: Martin Kustermann <[email protected]>
1 parent cb88626 commit a8a2303

File tree

1 file changed

+23
-3
lines changed

1 file changed

+23
-3
lines changed

tools/bots/test_matrix.json

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,17 @@
215215
"use-sdk": true
216216
}
217217
},
218+
"wasm-unittest-asserts-(linux|mac)": {
219+
"options": {
220+
"builder-tag": "wasm",
221+
"compiler": "dartk",
222+
"enable-asserts": true,
223+
"mode": "release",
224+
"runtime": "vm",
225+
"timeout": 240,
226+
"use-sdk": true
227+
}
228+
},
218229
"web-dev-unittest-asserts-(linux|win)": {
219230
"options": {
220231
"builder-tag": "ddc",
@@ -2663,11 +2674,20 @@
26632674
},
26642675
{
26652676
"name": "dart2wasm unit tests",
2677+
"arguments": [
2678+
"-nwasm-unittest-asserts-linux",
2679+
"pkg/dart2wasm"
2680+
],
2681+
"shards": 1,
2682+
"fileset": "dart2wasm_hostasserts"
2683+
},
2684+
{
2685+
"name": "dart2wasm dry run tests",
26662686
"script": "out/ReleaseX64/dart-sdk/bin/dart",
26672687
"testRunner": true,
26682688
"arguments": [
26692689
"pkg/dart2wasm/test/dry_run/dry_run_test.dart",
2670-
"-ndart2wasm-asserts-linux-chrome"
2690+
"-nwasm-unittest-asserts-linux"
26712691
]
26722692
}
26732693
]
@@ -3111,7 +3131,7 @@
31113131
"name": "package unit tests",
31123132
"arguments": [
31133133
"-nunittest-asserts-${mode}-${system}-${arch}",
3114-
"pkg/pkg/(?!(analyzer*|analysis_server|analysis_server_plugin|compiler|dev_compiler|js_runtime|front_end|kernel|frontend_server|nnbd_migration|dartdev/test/native_assets|vm_service)/)"
3134+
"pkg/pkg/(?!(analyzer*|analysis_server|analysis_server_plugin|compiler|dart2wasm|dev_compiler|js_runtime|front_end|kernel|frontend_server|nnbd_migration|dartdev/test/native_assets|vm_service)/)"
31153135
],
31163136
"shards": 3,
31173137
"fileset": "vm"
@@ -3227,7 +3247,7 @@
32273247
"name": "package unit tests",
32283248
"arguments": [
32293249
"-nunittest-asserts-${mode}-${system}-${arch}",
3230-
"pkg/pkg/(?!(analyzer*|analysis_server|analysis_server_plugin|compiler|dev_compiler|js_runtime|front_end|kernel|frontend_server|nnbd_migration|dartdev/test/native_assets|vm_service)/)"
3250+
"pkg/pkg/(?!(analyzer*|analysis_server|analysis_server_plugin|compiler|dart2wasm|dev_compiler|js_runtime|front_end|kernel|frontend_server|nnbd_migration|dartdev/test/native_assets|vm_service)/)"
32313251
]
32323252
}
32333253
]

0 commit comments

Comments
 (0)