[element model] utility method migration/cleanup

Some prep work for `use_build_context_synchronously` and some dead code removal.

Change-Id: I36dd07adc3b8e58eb4b858e891c146bc75f53703
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392080
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: pq

pkg/linter/lib/src/extensions.dart

@@ -27,16 +27,6 @@ class EnumLikeClassDescription {
   Map<DartObject, Set<FieldElement2>> get enumConstants => {..._enumConstants};
 }
 
-extension on SetterElement {
-  /// Return name in a format suitable for string comparison.
-  String? get canonicalName {
-    var name = name3;
-    if (name == null) return null;
-    // TODO(pq): remove when `name3` consistently does not include a trailing `=`.
-    return name.endsWith('=') ? name.substring(0, name.length - 1) : name;
-  }
-}
-
 extension AstNodeExtension on AstNode {
   Iterable<AstNode> get childNodes => childEntities.whereType<AstNode>();
 
@@ -289,20 +279,7 @@ extension ClassMemberListExtension on List<ClassMember> {
       .firstWhereOrNull((node) => node.name.lexeme == name);
 }
 
-extension ConstructorElementExtension on ConstructorElement {
-  /// Returns whether `this` is the same element as the [className] constructor
-  /// named [constructorName] declared in [uri].
-  bool isSameAs({
-    required String uri,
-    required String className,
-    required String constructorName,
-  }) =>
-      library.name == uri &&
-      enclosingElement3.name == className &&
-      name == constructorName;
-}
-
-extension ConstructorElementExtension2 on ConstructorElement2 {
+extension ConstructorElementExtension on ConstructorElement2 {
   /// Returns whether `this` is the same element as the [className] constructor
   /// named [constructorName] declared in [uri].
   bool isSameAs({
@@ -581,13 +558,6 @@ extension InhertanceManager3Extension on InheritanceManager3 {
   }
 }
 
-extension InterfaceElementExtension on InterfaceElement {
-  /// Returns whether this element is exactly [otherName] declared in
-  /// [otherLibrary].
-  bool isClass(String otherName, String otherLibrary) =>
-      name == otherName && library.name == otherLibrary;
-}
-
 extension InterfaceTypeExtension on InterfaceType {
   /// Returns the collection of all interfaces that this type implements,
   /// including itself.
@@ -614,8 +584,9 @@ extension InterfaceTypeExtension on InterfaceType {
     return interfaceTypes;
   }
 
-  GetterElement? getGetter2(String name) =>
-      getters.firstWhereOrNull((s) => s.name3 == name);
+  GetterElement? getGetter2(String name, {LibraryElement2? library}) =>
+      getters.firstWhereOrNull((s) =>
+          s.name3 == name && (library == null || (s.library2 == library)));
 
   SetterElement? getSetter2(String name) =>
       setters.firstWhereOrNull((s) => s.canonicalName == name);
@@ -730,6 +701,16 @@ extension MethodDeclarationExtension on MethodDeclaration {
   }
 }
 
+extension SetterElementExtension on SetterElement {
+  /// Return name in a format suitable for string comparison.
+  String? get canonicalName {
+    var name = name3;
+    if (name == null) return null;
+    // TODO(pq): remove when `name3` consistently does not include a trailing `=`.
+    return name.endsWith('=') ? name.substring(0, name.length - 1) : name;
+  }
+}
+
 extension StringExtension on String {
   String toAbsoluteNormalizedPath() {
     var pathContext = PhysicalResourceProvider.INSTANCE.pathContext;

pkg/linter/lib/src/util/flutter_utils.dart

@@ -40,6 +40,8 @@ bool isKDebugMode(Element2? element) => _flutter.isKDebugMode(element);
 
 bool isState(InterfaceElement element) => _flutter.isState(element);
 
+bool isState2(InterfaceElement2 element) => _flutter.isState2(element);
+
 bool isStatefulWidget(ClassElement2? element) =>
     element != null && _flutter.isStatefulWidget(element);
 
@@ -138,23 +140,28 @@ class _Flutter {
       element.allSupertypes
           .any((type) => isExactly(type.element, _nameState, _uriFramework));
 
+  bool isState2(InterfaceElement2 element) =>
+      isExactly2(element, _nameState, _uriFramework) ||
+      element.allSupertypes
+          .any((type) => isExactly2(type.element3, _nameState, _uriFramework));
+
   bool isStatefulWidget(ClassElement2 element) =>
       isExactly2(element, _nameStatefulWidget, _uriFramework) ||
       element.allSupertypes.any((type) =>
           isExactly(type.element, _nameStatefulWidget, _uriFramework));
 
-  bool isWidget(InterfaceElement element) {
-    if (isExactly(element, _nameWidget, _uriFramework)) {
+  bool isWidget(InterfaceElement2 element) {
+    if (isExactly2(element, _nameWidget, _uriFramework)) {
       return true;
     }
     for (var type in element.allSupertypes) {
-      if (isExactly(type.element, _nameWidget, _uriFramework)) {
+      if (isExactly2(type.element3, _nameWidget, _uriFramework)) {
         return true;
       }
     }
     return false;
   }
 
   bool isWidgetType(DartType? type) =>
-      type is InterfaceType && isWidget(type.element);
+      type is InterfaceType && isWidget(type.element3);
 }