Skip to content

Commit a8e9cc4

Browse files
rmacnak-googleCommit Queue
authored andcommitted
[standalone] Remove kAsanDefaultOptions.
The test harness sets options via ASAN_OPTIONS. This makes our treatment of ASAN consistent with the other sanitizers. Also fix a leak through RetainedReasonsWriter that this unmasked. TEST=ci Change-Id: I96cc6018b4859977d2bb7290b8822c91d99705cb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394665 Reviewed-by: Alexander Aprelev <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
1 parent 9e86286 commit a8e9cc4

File tree

3 files changed

+4
-31
lines changed

3 files changed

+4
-31
lines changed

runtime/bin/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,6 @@ template("build_gen_snapshot") {
215215
defines = [ "EXCLUDE_CFE_AND_KERNEL_PLATFORM" ]
216216

217217
sources = [
218-
"address_sanitizer.cc",
219218
"builtin.cc",
220219
"builtin.h",
221220
"error_exit.cc",

runtime/bin/address_sanitizer.cc

Lines changed: 0 additions & 28 deletions
This file was deleted.

runtime/vm/compiler/aot/precompiler.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,12 @@ struct RetainReasons : public AllStatic {
176176
"signature of entry point function";
177177
};
178178

179-
class RetainedReasonsWriter : public ValueObject {
179+
class RetainedReasonsWriter : public StackResource {
180180
public:
181181
explicit RetainedReasonsWriter(Zone* zone)
182-
: zone_(zone), retained_reasons_map_(zone) {}
182+
: StackResource(Thread::Current()),
183+
zone_(zone),
184+
retained_reasons_map_(zone) {}
183185

184186
bool Init(const char* filename) {
185187
if (filename == nullptr) return false;

0 commit comments

Comments
 (0)