[vm,dyn_modules] Add bytecode closures to the ClosureFunctionCache.

This allows Debugger::FindNextFit to locate source positions within
inner closures.

TEST=pkg/vm_service/test

Cq-Include-Trybots: luci.dart.try:vm-dyn-linux-debug-x64-try,vm-aot-dyn-linux-debug-x64-try,vm-aot-dyn-linux-product-x64-try,vm-dyn-mac-debug-arm64-try
Change-Id: I57cf3073e2013c1e395f3897fd73d1f3073922ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449541
Reviewed-by: Alexander Markov <[email protected]>
Commit-Queue: Tess Strickland <[email protected]>

Author: sstrickl

runtime/vm/bytecode_reader.cc

@@ -317,6 +317,8 @@ void BytecodeReaderHelper::ReadCode(const Function& function,
           KernelBytecodeDisassembler::Disassemble(closure);
         }
       }
+
+      ClosureFunctionsCache::AddClosureFunctionLocked(closure);
     }
   }
 }

runtime/vm/closure_functions_cache.cc

@@ -26,6 +26,7 @@ using FunctionHashMap = UnorderedHashMap<FunctionHashMapTraits>;
 FunctionPtr ClosureFunctionsCache::LookupClosureFunction(
     const Function& member_function,
     intptr_t kernel_offset) {
+  ASSERT(!member_function.HasBytecode());
   auto thread = Thread::Current();
   SafepointReadRwLocker ml(thread, thread->isolate_group()->program_lock());
   return LookupClosureFunctionLocked(member_function, kernel_offset);
@@ -34,6 +35,7 @@ FunctionPtr ClosureFunctionsCache::LookupClosureFunction(
 FunctionPtr ClosureFunctionsCache::LookupClosureFunctionLocked(
     const Function& member_function,
     intptr_t kernel_offset) {
+  ASSERT(!member_function.HasBytecode());
   auto thread = Thread::Current();
   auto zone = thread->zone();
   auto object_store = thread->isolate_group()->object_store();
@@ -86,7 +88,7 @@ void ClosureFunctionsCache::AddClosureFunctionLocked(
          function.IsNonImplicitClosureFunction());
   closures.Add(function, Heap::kOld);
 
-  if (allow_implicit_closure_functions) {
+  if (allow_implicit_closure_functions || function.HasBytecode()) {
     return;
   }