linter: Use new DiagnosticCode name

Work towards #60635

Change-Id: I3f53e1c7db21047665e1a286673d624c2d48c834
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425684
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/linter/lib/src/rules/always_specify_types.dart

@@ -196,28 +196,28 @@ class _Visitor extends SimpleAstVisitor<void> {
       var singleType = types.length == 1;
 
       List<Object> arguments;
-      ErrorCode errorCode;
+      DiagnosticCode lintCode;
       if (types.isEmpty) {
         arguments = [];
-        errorCode = LinterLintCode.always_specify_types_add_type;
+        lintCode = LinterLintCode.always_specify_types_add_type;
       } else if (keyword.type == Keyword.VAR) {
         if (singleType) {
           arguments = [keyword.lexeme, types.first];
-          errorCode = LinterLintCode.always_specify_types_replace_keyword;
+          lintCode = LinterLintCode.always_specify_types_replace_keyword;
         } else {
           arguments = [];
-          errorCode = LinterLintCode.always_specify_types_split_to_types;
+          lintCode = LinterLintCode.always_specify_types_split_to_types;
         }
       } else {
         if (singleType) {
           arguments = [types.first];
-          errorCode = LinterLintCode.always_specify_types_specify_type;
+          lintCode = LinterLintCode.always_specify_types_specify_type;
         } else {
           arguments = [];
-          errorCode = LinterLintCode.always_specify_types_add_type;
+          lintCode = LinterLintCode.always_specify_types_add_type;
         }
       }
-      rule.reportAtToken(keyword, arguments: arguments, errorCode: errorCode);
+      rule.reportAtToken(keyword, arguments: arguments, errorCode: lintCode);
     }
   }
 

pkg/linter/test/formatter_test.dart

@@ -34,7 +34,7 @@ void defineTests() {
 
         var type = MockDiagnosticType()..displayName = 'test';
 
-        var code = TestErrorCode('mock_code', 'MSG')..type = type;
+        var code = TestDiagnosticCode('mock_code', 'MSG')..type = type;
 
         await d.dir('project', [
           d.file('foo.dart', '''

pkg/linter/test/mocks.dart

@@ -80,14 +80,14 @@ class MockSource extends BasicSource {
   dynamic noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
 }
 
-class TestErrorCode extends ErrorCode {
+class TestDiagnosticCode extends DiagnosticCode {
   @override
   late ErrorSeverity errorSeverity;
 
   @override
   late DiagnosticType type;
 
-  TestErrorCode(String name, String message)
+  TestDiagnosticCode(String name, String message)
     : super(
         problemMessage: message,
         name: name,

pkg/linter/test/rule_test_support.dart

@@ -35,7 +35,7 @@ export 'package:analyzer/src/test_utilities/package_config_file_builder.dart';
 export 'package:linter/src/lint_names.dart';
 
 ExpectedDiagnostic error(
-  ErrorCode code,
+  DiagnosticCode code,
   int offset,
   int length, {
   Pattern? messageContains,
@@ -518,7 +518,9 @@ abstract class _ContextResolutionTest
   late ResolvedUnitResult result;
 
   /// Error codes that by default should be ignored in test expectations.
-  List<ErrorCode> get ignoredErrorCodes => [WarningCode.UNUSED_LOCAL_VARIABLE];
+  List<DiagnosticCode> get ignoredErrorCodes => [
+    WarningCode.UNUSED_LOCAL_VARIABLE,
+  ];
 
   /// The path to the root of the external packages.
   @override
@@ -609,7 +611,7 @@ abstract class _ContextResolutionTest
 
 /// A description of an expected error.
 final class _ExpectedError extends ExpectedDiagnostic {
-  final ErrorCode _code;
+  final DiagnosticCode _code;
 
   _ExpectedError(this._code, int offset, int length, {Pattern? messageContains})
     : super(

pkg/linter/test/rules/always_put_control_body_on_new_line_test.dart

@@ -16,7 +16,7 @@ void main() {
 @reflectiveTest
 class AlwaysPutControlBodyOnNewLineTest extends LintRuleTest {
   @override
-  List<ErrorCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredErrorCodes => [
     WarningCode.DEAD_CODE,
     WarningCode.UNUSED_LOCAL_VARIABLE,
   ];

pkg/linter/test/rules/avoid_catches_without_on_clauses_test.dart

@@ -19,7 +19,7 @@ class AvoidCatchesWithoutOnClausesTest extends LintRuleTest {
   bool get addFlutterPackageDep => true;
 
   @override
-  List<ErrorCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredErrorCodes => [
     WarningCode.UNUSED_ELEMENT,
     WarningCode.UNUSED_LOCAL_VARIABLE,
   ];

pkg/linter/test/rules/avoid_private_typedef_functions_test.dart

@@ -16,7 +16,7 @@ void main() {
 @reflectiveTest
 class AvoidPrivateTypedefFunctionsTest extends LintRuleTest {
   @override
-  List<ErrorCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredErrorCodes => [
     WarningCode.UNUSED_ELEMENT,
     WarningCode.UNUSED_FIELD,
     WarningCode.UNUSED_LOCAL_VARIABLE,

pkg/linter/test/rules/avoid_returning_null_for_void_test.dart

@@ -16,7 +16,7 @@ void main() {
 @reflectiveTest
 class AvoidReturningNullForVoidTest extends LintRuleTest {
   @override
-  List<ErrorCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredErrorCodes => [
     WarningCode.UNUSED_ELEMENT,
     WarningCode.UNUSED_LOCAL_VARIABLE,
   ];

pkg/linter/test/rules/avoid_shadowing_type_parameters_test.dart

@@ -16,7 +16,7 @@ void main() {
 @reflectiveTest
 class AvoidShadowingTypeParametersTest extends LintRuleTest {
   @override
-  List<ErrorCode> get ignoredErrorCodes => [
+  List<DiagnosticCode> get ignoredErrorCodes => [
     WarningCode.UNUSED_ELEMENT,
     WarningCode.UNUSED_LOCAL_VARIABLE,
   ];

pkg/linter/test/rules/combinators_ordering_test.dart

@@ -16,7 +16,7 @@ void main() {
 @reflectiveTest
 class CombinatorsOrderingTest extends LintRuleTest {
   @override
-  List<ErrorCode> get ignoredErrorCodes => [WarningCode.UNUSED_IMPORT];
+  List<DiagnosticCode> get ignoredErrorCodes => [WarningCode.UNUSED_IMPORT];
 
   @override
   String get lintRule => LintNames.combinators_ordering;