analyzer: Improve isDeprecatedWithKind

From comments on https://dart-review.googlesource.com/c/sdk/+/450971:

* Use `trackedIndirectly` on `isDeprecatedWithKind`.
* In member.dart, `isDeprecatedWithKind` should just refer to
  `baseElement`.

Change-Id: Ia58b3d84732d9bb7c2b05b8e72694e837c2feba1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451602
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/dart/element/element.dart

@@ -1947,7 +1947,7 @@ abstract class ElementImpl implements Element {
   }
 
   @override
-  @trackedIncludedInId
+  @trackedIndirectly
   bool isDeprecatedWithKind(String kind) => metadata.annotations
       .where((e) => e.isDeprecated)
       .any((e) => e.deprecationKind == kind);

pkg/analyzer/lib/src/dart/element/member.dart

@@ -252,9 +252,8 @@ abstract class SubstitutedElementImpl implements Element {
   }
 
   @override
-  bool isDeprecatedWithKind(String kind) => metadata.annotations
-      .where((e) => e.isDeprecated)
-      .any((e) => e.deprecationKind == kind);
+  bool isDeprecatedWithKind(String kind) =>
+      baseElement.isDeprecatedWithKind(kind);
 
   @override
   Element? thisOrAncestorMatching(bool Function(Element e) predicate) {