Handle new module format in debugger_test

- Since libraries can't be exposed anymore with the new module
format, relies on "this" and the JS foreign function to get the
current library so we can only test the formatting of libraries.
Patches in a link function to match the behavior of the new
module system.
- Cleans up some unnecessary code to support old type system.
- Adds a status file to skip this test in d8 (it's currently
failing).

Change-Id: Ib8c503c5971a96e459d952602ff0ce2004d72878
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389589
Reviewed-by: Nicholas Shahan <[email protected]>
Commit-Queue: Srujan Gaddam <[email protected]>

Author: srujzs

tests/dartdevc/dartdevc.status

@@ -0,0 +1,6 @@
+# Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+# for details. All rights reserved. Use of this source code is governed by a
+# BSD-style license that can be found in the LICENSE file.
+
+[ $runtime == d8 ]
+debugger/debugger_test: SkipByDesign # Uses the DOM

tests/dartdevc/debugger/debugger_test.dart

@@ -16,6 +16,7 @@ import 'package:expect/legacy/minitest.dart'; // ignore: deprecated_member_use_f
 import 'package:js/js.dart' as pkgJs;
 
 import 'dart:_debugger' as _debugger;
+import 'dart:_foreign_helper' as _foreign_helper;
 
 class TestClass {
   String name = 'test class';
@@ -55,6 +56,9 @@ class FormattedObject {
   JSAny? config;
 }
 
+@JS()
+external JSAny? get dartDevEmbedder;
+
 @JS('JSON.stringify')
 external String? stringify(JSAny? value, [JSFunction replacer, int space]);
 
@@ -106,10 +110,6 @@ JSAny? replacer(String key, JSAny? externalValue) {
     if (new RegExp(r'[.](js|dart|html)').hasMatch(value)) {
       return '<FILE>'.toJS;
     }
-    // Normalize the name of the `Event` type as it appears in this test.
-    // The new type system preserves the original name from the Dart source.
-    // TODO(48585): Remove when no longer running with the old type system.
-    return value.replaceAll(r'Event$', 'Event').toJS;
   }
   return externalValue;
 }
@@ -149,6 +149,14 @@ List<FormattedObject> extractNestedFormattedObjects(JSAny json) {
   return ret;
 }
 
+JSObject getCurrentLibrary() =>
+    // With the new module format, we can't get the current library, so this is
+    // a workaround to fetch it. Note that this is run in the top-level scope.
+    // We can't use interop for this, as the lowering would be emitted as
+    // `dart.global.eval('this')`, which does not evaluate to the same value as
+    // `eval('this')`.
+    _foreign_helper.JS('', 'this');
+
 main() async {
   asyncStart();
   if (devtoolsFormatters == null) {
@@ -315,13 +323,22 @@ window.PackageJSClass = function PackageJSClass(x) {
     expect(_devtoolsFormatter.header(object, null), isNull);
   });
 
-  group('Module formatting', () {
-    var moduleNames = _debugger.getModuleNames();
-    var testModuleName = "debugger_test";
-    expect(moduleNames.contains(testModuleName), isTrue);
-
-    addAllNestedFormatterGoldens(
-        'Test library Module', _debugger.getModuleLibraries(testModuleName));
+  group('Library formatting', () {
+    final lib = getCurrentLibrary();
+    if (dartDevEmbedder == null) {
+      // The new module format adds a `link` function to every library. Patch
+      // something like that in so we can have a consistent golden file for all
+      // module formats.
+      lib['link'] = () {}.toJS;
+    }
+    addFormatterGoldens(
+        'Test library',
+        // TODO(srujzs): We have to construct a `Library` manually here,
+        // whereas the `LibraryModuleFormatter` does that for us automatically
+        // when we format the module. We should add properties to libraries so
+        // that we can detect them as a library. Once we have support for that,
+        // revisit this and the formatter code.
+        _debugger.Library('debugger_test', lib));
   });
 
   group('StackTrace formatting', () {
@@ -355,13 +372,14 @@ window.PackageJSClass = function PackageJSClass(x) {
   });
 
   test('verify golden match', () {
-    // Warning: all other test groups must have run for this test to be meaningful
+    // Warning: all other test groups must have run for this test to be
+    // meaningful
     var actualStr = actual.toString().trim();
 
     if (actualStr != golden) {
       var helpMessage =
           'Debugger output does not match the golden data found in:\n'
-          'tests/dartdevc/debugger/debugger_test_golden.txt\n'
+          'tests/dartdevc/debugger/debugger_test_golden.txt.\n'
           'The new golden data is copied to the clipboard when you click on '
           'this window.\n'
           'Please update the golden file with the following output and review '

tests/dartdevc/debugger/debugger_test_golden.txt

@@ -5136,17 +5136,17 @@ Value:
     }
 ]
 -----------------------------------
-Test: Test library Module header
+Test: Test library formatting header
 Value:
 [
     "span",
     {
         "style": "background-color: #d9edf7;color: black"
     },
-    "Library Module: debugger_test"
+    "debugger_test"
 ]
 -----------------------------------
-Test: Test library Module body
+Test: Test library formatting body
 Value:
 [
     "ol",
@@ -5161,7 +5161,14 @@ Value:
         [
             "span",
             {
-                "style": ""
+                "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
+            },
+            "TestClass: "
+        ],
+        [
+            "span",
+            {
+                "style": "margin-left: 13px"
             },
             [
                 "object",
@@ -5171,26 +5178,7 @@ Value:
                 }
             ]
         ]
-    ]
-]
------------------------------------
-Test: Test library Module child 0 formatting header
-Value:
-[
-    "span",
-    {
-        "style": "background-color: #d9edf7;color: black"
-    },
-    "<FILE>"
-]
------------------------------------
-Test: Test library Module child 0 formatting body
-Value:
-[
-    "ol",
-    {
-        "style": "list-style-type: none;padding-left: 0px;margin-top: 0px;margin-bottom: 0px;margin-left: 12px;"
-    },
+    ],
     [
         "li",
         {
@@ -5201,7 +5189,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "TestClass: "
+            "TestGenericClass: "
         ],
         [
             "span",
@@ -5227,7 +5215,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "TestGenericClass: "
+            "FormattedObject: "
         ],
         [
             "span",
@@ -5253,7 +5241,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "FormattedObject: "
+            "PackageJSClass: "
         ],
         [
             "span",
@@ -5279,7 +5267,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "PackageJSClass: "
+            "FormattedJSObject|constructor#_: "
         ],
         [
             "span",
@@ -5305,7 +5293,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "FormattedJSObject|constructor#_: "
+            "FormattedJSObject|constructor#_#_#tearOff: "
         ],
         [
             "span",
@@ -5331,7 +5319,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "FormattedJSObject|constructor#_#_#tearOff: "
+            "Prototype|constructor#_: "
         ],
         [
             "span",
@@ -5357,7 +5345,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "Prototype|constructor#_: "
+            "Prototype|constructor#_#_#tearOff: "
         ],
         [
             "span",
@@ -5383,7 +5371,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "Prototype|constructor#_#_#tearOff: "
+            "FooBar|constructor#_: "
         ],
         [
             "span",
@@ -5409,7 +5397,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "FooBar|constructor#_: "
+            "FooBar|constructor#_#_#tearOff: "
         ],
         [
             "span",
@@ -5435,7 +5423,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "FooBar|constructor#_#_#tearOff: "
+            "unsafeCast: "
         ],
         [
             "span",
@@ -5461,7 +5449,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "unsafeCast: "
+            "replacer: "
         ],
         [
             "span",
@@ -5487,7 +5475,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "replacer: "
+            "format: "
         ],
         [
             "span",
@@ -5513,7 +5501,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "format: "
+            "extractNestedFormattedObjects: "
         ],
         [
             "span",
@@ -5539,7 +5527,7 @@ Value:
             {
                 "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
             },
-            "extractNestedFormattedObjects: "
+            "getCurrentLibrary: "
         ],
         [
             "span",
@@ -5580,6 +5568,32 @@ Value:
                 }
             ]
         ]
+    ],
+    [
+        "li",
+        {
+            "style": "padding-left: 13px;"
+        },
+        [
+            "span",
+            {
+                "style": "background-color: thistle; color: rgb(136, 19, 145); margin-right: -13px"
+            },
+            "link: "
+        ],
+        [
+            "span",
+            {
+                "style": "margin-left: 13px"
+            },
+            [
+                "object",
+                {
+                    "object": "<OBJECT>",
+                    "config": {}
+                }
+            ]
+        ]
     ]
 ]
 -----------------------------------