[kernel] BinaryReader takes Uint8List, not List<int>

In AOT this makes reading faster:

Output from `out/ReleaseX64/dart pkg/front_end/tool/benchmarker.dart --iterations=10 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.1 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.2 --arguments="--warmups=10" --arguments="--iterations=5" --arguments="AstFromBinaryEager" --arguments="out/ReleaseX64/vm_platform_strong.dill"`:

```
msec task-clock:u: -8.6925% +/- 0.5737% (-167.09 +/- 11.03)
page-faults:u: 0.1410% +/- 0.0051% (243.00 +/- 8.71)
cycles:u: -10.2918% +/- 0.6161% (-732576747.50 +/- 43853449.16)
instructions:u: -14.4988% +/- 0.0004% (-1636799813.90 +/- 39902.18)
branch-misses:u: -3.4891% +/- 2.1142% (-1166085.00 +/- 706582.35)
seconds time elapsed: -8.7005% +/- 0.5634% (-0.17 +/- 0.01)
seconds user: -9.9752% +/- 1.5104% (-0.17 +/- 0.03)
```

Stats running manually (run as e.g. `out/ReleaseX64/dart-sdk/bin/dartaotruntime pkg/front_end/test/kernel_binary_bench.aot.1 --warmups=10 --iterations=5 AstFromBinaryEager out/ReleaseX64/vm_platform_strong.dill`):

```
AstFromBinaryEagerCold: -12.5174% +/- 3.10688%
AstFromBinaryEagerWarmup: -8.33675% +/- 2.62433%
AstFromBinaryEager: -10.3432% +/- 3.68375%
```

I don't expect there to be much of a change (if any) in JIT as the actual type was in practise always Uint8List anyway.

TEST=Existing tests.

Change-Id: I86b16ed207343848dee2e376f42598c223bbc48f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393740
Reviewed-by: Mayank Patke <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Jens Johansen <[email protected]>
Reviewed-by: Morgan :) <[email protected]>
Reviewed-by: Srujan Gaddam <[email protected]>
Reviewed-by: Alexander Aprelev <[email protected]>

Author: jensjoha

pkg/build_integration/lib/file_system/multi_root.dart

@@ -85,7 +85,7 @@ class MultiRootFileSystemEntity implements FileSystemEntity {
   Future<Uint8List> readAsBytes() async => (await delegate).readAsBytes();
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() async =>
+  Future<Uint8List> readAsBytesAsyncIfPossible() async =>
       (await delegate).readAsBytes();
 
   @override
@@ -109,7 +109,7 @@ class MissingFileSystemEntity implements FileSystemEntity {
       Future.error(FileSystemException(uri, 'File not found'));
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() => readAsBytes();
+  Future<Uint8List> readAsBytesAsyncIfPossible() => readAsBytes();
 
   @override
   Future<String> readAsString() =>

pkg/build_integration/lib/file_system/single_root.dart

@@ -73,7 +73,7 @@ class SingleRootFileSystemEntity implements FileSystemEntity {
   Future<Uint8List> readAsBytes() async => delegate.readAsBytes();
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() async =>
+  Future<Uint8List> readAsBytesAsyncIfPossible() async =>
       delegate.readAsBytesAsyncIfPossible();
 
   @override

pkg/compiler/lib/src/kernel/front_end_adapter.dart

@@ -68,7 +68,7 @@ class _CompilerFileSystemEntity implements fe.FileSystemEntity {
   }
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() => readAsBytes();
+  Future<Uint8List> readAsBytesAsyncIfPossible() => readAsBytes();
 
   @override
   Future<bool> exists() async {

pkg/compiler/lib/src/phase/load_kernel.dart

@@ -417,7 +417,7 @@ Future<Output?> run(Input input) async {
   if (component == null) return null;
   if (input.forceSerialization) {
     // TODO(johnniwinther): Remove this when #34942 is fixed.
-    List<int> data = fe.serializeComponent(component);
+    Uint8List data = fe.serializeComponent(component);
     component = ir.Component();
     BinaryBuilder(data).readComponent(component);
     // Ensure we use the new deserialized entry point library.

pkg/compiler/lib/src/serialization/strategies.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
+import 'dart:typed_data';
 
 import 'package:front_end/src/api_unstable/dart2js.dart' as ir
     show serializeComponent, ByteSink;
@@ -22,7 +23,7 @@ import 'task.dart';
 abstract class SerializationStrategy<T> {
   const SerializationStrategy();
 
-  List<int> unpackAndSerializeComponent(GlobalTypeInferenceResults results) {
+  Uint8List unpackAndSerializeComponent(GlobalTypeInferenceResults results) {
     JClosedWorld closedWorld = results.closedWorld;
     ir.Component component = closedWorld.elementMap.programEnv.mainComponent;
     return serializeComponent(component);
@@ -33,11 +34,11 @@ abstract class SerializationStrategy<T> {
       CompilerOptions options,
       SerializationIndices indices);
 
-  List<int> serializeComponent(ir.Component component) {
+  Uint8List serializeComponent(ir.Component component) {
     return ir.serializeComponent(component);
   }
 
-  ir.Component deserializeComponent(List<int> data) {
+  ir.Component deserializeComponent(Uint8List data) {
     ir.Component component = ir.Component();
     BinaryBuilder(data).readComponent(component);
     return component;

pkg/compiler/test/serialization/serialization_test_helper.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
+import 'dart:typed_data';
 
 import 'package:compiler/compiler_api.dart' as api;
 import 'package:compiler/src/commandline_options.dart';
@@ -273,7 +274,7 @@ JClosedWorld cloneClosedWorld(Compiler compiler, JClosedWorld closedWorld,
     SerializationStrategy strategy) {
   SerializationIndices indices = SerializationIndices();
   ir.Component component = closedWorld.elementMap.programEnv.mainComponent;
-  List<int> irData = strategy.serializeComponent(component);
+  Uint8List irData = strategy.serializeComponent(component);
   final closedWorldData = strategy.serializeClosedWorld(
       closedWorld, compiler.options, indices) as List<int>;
   print('data size: ${closedWorldData.length}');
@@ -302,7 +303,7 @@ JClosedWorld cloneClosedWorld(Compiler compiler, JClosedWorld closedWorld,
 GlobalTypeInferenceResults cloneInferenceResults(Compiler compiler,
     GlobalTypeInferenceResults results, SerializationStrategy strategy) {
   SerializationIndices indices = SerializationIndices(testMode: true);
-  List<int> irData = strategy.unpackAndSerializeComponent(results);
+  Uint8List irData = strategy.unpackAndSerializeComponent(results);
   final closedWorldData = strategy.serializeClosedWorld(
       results.closedWorld, compiler.options, indices) as List<int>;
   ir.Component newComponent = strategy.deserializeComponent(irData);

pkg/dev_compiler/lib/src/kernel/asset_file_system.dart

@@ -98,7 +98,7 @@ class AssetFileSystemEntity implements FileSystemEntity {
   }
 
   @override
-  Future<List<int>> readAsBytesAsyncIfPossible() => readAsBytes();
+  Future<Uint8List> readAsBytesAsyncIfPossible() => readAsBytes();
 
   @override
   Future<String> readAsString() async {

pkg/front_end/lib/src/api_prototype/file_system.dart

@@ -81,7 +81,7 @@ abstract class FileSystemEntity {
   /// If an error occurs while attempting to read the file (e.g. because no such
   /// file exists, or the entity is a directory), the future is completed with
   /// [FileSystemException].
-  Future<List<int>> readAsBytesAsyncIfPossible();
+  Future<Uint8List> readAsBytesAsyncIfPossible();
 
   /// Attempts to access this file system entity as a file and read its contents
   /// as a string.

pkg/front_end/lib/src/api_prototype/kernel_generator.dart

@@ -5,6 +5,8 @@
 /// Defines the front-end API for converting source code to Dart Kernel objects.
 library front_end.kernel_generator;
 
+import 'dart:typed_data';
+
 import 'package:_fe_analyzer_shared/src/messages/codes.dart'
     show messageMissingMain, noLength;
 import 'package:_fe_analyzer_shared/src/messages/severity.dart' show Severity;
@@ -109,7 +111,7 @@ Future<CompilerResult> kernelForModule(
 /// Result object for [kernelForProgram] and [kernelForModule].
 abstract class CompilerResult {
   /// The generated summary bytes, if it was requested.
-  List<int>? get summary;
+  Uint8List? get summary;
 
   /// The generated component, if it was requested.
   Component? get component;

pkg/front_end/lib/src/api_prototype/memory_file_system.dart

@@ -105,7 +105,7 @@ class MemoryFileSystemEntity implements FileSystemEntity {
 
   @override
   // Coverage-ignore(suite): Not run.
-  Future<List<int>> readAsBytesAsyncIfPossible() => readAsBytes();
+  Future<Uint8List> readAsBytesAsyncIfPossible() => readAsBytes();
 
   @override
   // Coverage-ignore(suite): Not run.